Skip to content

cellular: Error messages #6632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from Apr 16, 2018
Merged

cellular: Error messages #6632

merged 3 commits into from Apr 16, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 13, 2018

Description

Error messages modified to give more information about failure causes

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@ghost ghost changed the title Error messages cellular: Error messages Apr 13, 2018
@ghost
Copy link
Author

ghost commented Apr 13, 2018

@AriParkkila please review

AriParkkila
AriParkkila reviewed Apr 13, 2018
View reviewed changes
Copy link

@AriParkkila AriParkkila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jarvte please review

jarvte
jarvte approved these changes Apr 13, 2018
View reviewed changes
features/cellular/framework/AT/AT_CellularNetwork.cpp Outdated
@@ -97,6 +98,20 @@ void AT_CellularNetwork::read_reg_params_and_compare(RegistrationType type)
int lac = -1, cell_id = -1, act = -1;

read_reg_params(type, reg_status, lac, cell_id, act);

switch (reg_status) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could add this inside #if MBED_CONF_MBED_TRACE_ENABLE so when trace not enabled no extra code is generated

features/cellular/framework/AT/AT_CellularSIM.cpp Outdated
}


CellularSIM::SimState AT_CellularSIM::trace_sim_errors(void)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could add this inside #if MBED_CONF_MBED_TRACE_ENABLE so when trace not enabled no extra code is generated

@0xc0170 0xc0170 requested a review from jarvte April 13, 2018 10:55
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 16, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 16, 2018

Build : SUCCESS

Build number : 1750
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6632/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 16, 2018

Test : FAILURE

Build number : 1555
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6632/1555

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 16, 2018

Unexpected error, restarting

/morph test

@mbed-ci
Copy link

mbed-ci commented Apr 16, 2018

Exporter Build : SUCCESS

Build number : 1387
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6632/

@mbed-ci
Copy link

mbed-ci commented Apr 16, 2018

Test : SUCCESS

Build number : 1559
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6632/1559

@cmonr cmonr merged commit 7f9e69d into ARMmbed:master Apr 16, 2018
@adbridge
Copy link
Contributor

This is based on top of changes introduced in #6496 which is for 5.9

@ghost ghost deleted the error_messages branch July 11, 2018 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-version: 5.9.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0xc0170 @mbed-ci @adbridge @AriParkkila @jarvte @cmonr