Make event queue use RTOS tick count #6693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @kivaisan |
Event queue was using its own Timer or LowPowerTimer objects to derive millisecond tick counts. This is unnecessary in RTOS builds, where the RTOS is maintaining a tick count. It also makes more sense to use the actual RTOS tick count, as the values are being used to compute tick timeouts for RTOS calls. Computing these RTOS tick delays with a separate timer could conceivably lead to rounding errors. Fixes: ARMmbed#5378
geky
reviewed
Apr 20, 2018
| @@ -23,7 +23,7 @@ | |||
| "value": 256 | |||
| }, | |||
| "use-lowpower-timer-ticker": { | |||
| "help": "Enable use of low power timer and ticker classes. May reduce the accuracy of the event queue.", | |||
| "help": "Enable use of low power timer and ticker classes in non-RTOS builds. May reduce the accuracy of the event queue. In RTOS builds, the RTOS tick count is used, and this configuration option has no effect.", | |||
There was a problem hiding this comment.
So is there a "lowpower timer" option for the RTOS? (@bulislaw?)
If so we should probably note that here
|
@MikeDK fyi |
bulislaw
approved these changes
Apr 23, 2018
|
/morph build |
Build : SUCCESSBuild number : 1851 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1495 |
Test : SUCCESSBuild number : 1659 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Event queue was using its own
TimerorLowPowerTimerobjects to derive millisecond tick counts. This is unnecessary in RTOS builds, where the RTOS is maintaining a tick count.It also makes more sense to use the actual RTOS tick count, as the values are being used to compute tick timeouts for RTOS calls. Computing these RTOS tick delays with a separate timer could conceivably lead to rounding errors.
Fixes: #5378
See also: #6653 and #6698
Pull request type
[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change