Make poll() use RTOS tick count #6698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amq - should still work for you, I hope. |
geky
previously approved these changes
Apr 23, 2018
platform/mbed_poll.cpp
Outdated
| if (timeout > 0) { | ||
| start_time = Kernel::get_ms_count(); | ||
| } | ||
| #define time_elapsed() int64_t(Kernel::get_ms_count() - start_time) |
There was a problem hiding this comment.
Nit: Should this be in all-caps as a macro?
RTOS maintains a tick count - use it, avoiding issues with sleep and low power timers.
|
@geky leave approve/request changes please |
geky
approved these changes
Apr 23, 2018
geky
approved these changes
Apr 23, 2018
bulislaw
approved these changes
Apr 23, 2018
0xc0170
approved these changes
Apr 25, 2018
|
/morph build |
Build : SUCCESSBuild number : 1853 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 1497 |
|
/morph export-build |
Test : SUCCESSBuild number : 1661 |
Exporter Build : SUCCESSBuild number : 1500 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RTOS maintains a tick count - use it, avoiding issues with sleep and low power timers.
This follows on from similar changes in #6653 and #6693
Supersedes #6418 for RTOS builds.
Pull request type
[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change