CM3DS Maintenance Pull Request: Cleaning #6696
Conversation
|
Changes looks good to me, but the commit 627c037803d9c16a2a987a83831ed0a95464d8b3 - do you think that one should be split (introduces lot of changes that not all of them are related) |
|
Thanks. |
This commit does not bring functional changes. Here is the list of changes: - merge CMSDK_CM3DS.h and SMM_MPS2.h into CM3DS.h - remove unused code - split copyright headers from first comment of each file Change-Id: I79b7ee01689439b7d2fde9d13035a5edf17f69ff Signed-off-by: Hugues de Valon <[email protected]>
This commit changes the clock frequency to the good value of 25 MHz. Change-Id: I18e559718619e3b1942c42fda2413b690c7b5852 Signed-off-by: Hugues de Valon <[email protected]>
This commit changes the code to fix the compiler warnings on ARM, GCC_ARM and IAR. Change-Id: I92676d2cc85daacde9f43f1898377a2cea750c50 Signed-off-by: Hugues de Valon <[email protected]>
This commit changes the conversion function to do all the calculation inside the HAL in ticks instead of microseconds. The conversion will be done in Mbed OS side. As SystemCoreClock is not a constant, it can not be used to initialise the ticker_info_t structure. Change-Id: I8fd4bf20dc5be8b965aca45f800a631275ccc724 Signed-off-by: Hugues de Valon <[email protected]>
|
I have just split the commit into 3, 9f107d2 is still quite big but more splitting would not be beneficial in my opinion. |
|
/morph build |
Build : SUCCESSBuild number : 1860 Triggering tests/morph test |
Test : SUCCESSBuild number : 1670 |
Exporter Build : SUCCESSBuild number : 1507 |
cmonr
added
release-version: 5.8.4
release-version: 5.9.0-rc1
and removed
release-version: 5.8.4
labels
|
Considering this as a refactor in leiu of a fix, and marking the release version as appropriate. |
As it was discussed in this overarching pull request #6119 and now that all of the preceding pull requests have been merged:
I am able to issue this last pull request.
It introduces four commits targeting CM3DS.
The pull request has been tested with the mbed OS Cloud Client example on all 3 compilers supported:
ARM,GCC_ARMandIAR. Greentea tests were executed successfully forGCC_ARM(gcc_tests.txt).