Update watchdog tests -- allow shorter timeouts #6709

fkjagodzinski · 2018-04-23T15:37:52Z

Description

Added a mechanism which will prevent an initialised watchdog from resetting the device during final greentea communication.

This change lowers the minimal testable timeout value from 500 ms to 50 ms, which is necessary to test all the partners' boards, as some of them only support timeout values up to 150 ms.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

CC @scartmell-arm @jamesbeyond @0xc0170 @bulislaw

jamesbeyond

look good to me

0xc0170 · 2018-04-26T13:56:52Z

/morph build

0xc0170 · 2018-04-26T14:10:12Z

@fkjagodzinski There is a build failure in the jenkins CI, please can you review? When was this branch rebased the last time? Or did you define that config anywhere in this branch?

mbed-ci · 2018-04-26T14:27:51Z

Build : SUCCESS

Build number : 1864
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6709/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

fkjagodzinski · 2018-04-26T15:06:40Z

@fkjagodzinski There is a build failure in the jenkins CI, please can you review? When was this branch rebased the last time? Or did you define that config anywhere in this branch?

@0xc0170 I don't understand the cause of this failure. The only two files this PR changes are:

$ git diff upstream/feature-watchdog origin/test_update-feature-watchdog --name-only
TESTS/mbed_drivers/watchdog/main.cpp
TESTS/mbed_hal/watchdog/main.cpp

mbed-ci · 2018-04-26T18:33:10Z

Exporter Build : SUCCESS

Build number : 1512
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6709/

mbed-ci · 2018-04-27T01:32:44Z

Test : FAILURE

Build number : 1676
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6709/1676

0xc0170 · 2018-04-27T07:23:01Z

@scartmell-arm When was the destination branch rebased teh last time? Can you please rebase and we rerun tests?

fkjagodzinski · 2018-05-07T08:32:16Z

Rebased to current feature-watchdog, 29d6dca.

cmonr · 2018-05-07T15:47:24Z

/morph build

mbed-ci · 2018-05-07T16:27:20Z

Build : SUCCESS

Build number : 1928
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6709/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-07T17:47:33Z

Test : SUCCESS

Build number : 1750
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6709/1750

mbed-ci · 2018-05-07T19:42:12Z

Exporter Build : SUCCESS

Build number : 1574
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6709/

fkjagodzinski · 2018-05-15T14:06:55Z

I updated the default timeout value used in several tests to 100 ms:

tests-mbed_drivers-watchdog,
tests-mbed_drivers-watchdog_reset,
tests-mbed_hal-watchdog,
tests-mbed_hal-watchdog_reset.

Regarding the tests-mbed_hal-watchdog_timing, I'll update this test in a separate PR according to @scartmell-arm suggestion.

fkjagodzinski · 2018-05-18T07:25:04Z

@scartmell-arm, I consider this PR ready, unless you have some comments, of course. As I mentioned above I'll prepare another one for the timing test.

cmonr · 2018-05-21T16:22:51Z

@scartmell-arm ?

cmonr · 2018-05-21T22:05:11Z

/morph build

mbed-ci · 2018-05-22T00:29:42Z

Build : FAILURE

Build number : 2090
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6709/

fkjagodzinski · 2018-05-22T08:51:09Z

For several targets the IAR linker fails to process mbed-os-example-lorawan. @0xc0170, @cmonr How can we fix this, should the feature branch be rebased?

0xc0170 · 2018-05-22T09:53:15Z

@fkjagodzinski I noticed this error on another feature branch. yes, needs to be rebased to get the fix in.

@scartmell-arm Can you please rebase?

0xc0170 · 2018-05-22T11:56:06Z

@fkjagodzinski The feature branch was rebased, this needs now resolving the conflicts

Added a mechanism which will prevent an initialised watchdog from resetting the device during final greentea communication. This allows testing watchdog timeouts as short as 50 ms.

fkjagodzinski · 2018-05-22T12:35:11Z

Rebased to current feature-watchdog, 2b01e51.

0xc0170 · 2018-05-22T14:20:42Z

/morph build

mbed-ci · 2018-05-22T15:49:31Z

Build : SUCCESS

Build number : 2103
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6709/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-22T17:37:46Z

Test : SUCCESS

Build number : 1908
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6709/1908

mbed-ci · 2018-05-22T21:38:29Z

Exporter Build : SUCCESS

Build number : 1739
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6709/

0xc0170 added the needs: review label Apr 23, 2018

0xc0170 requested review from a user and jamesbeyond April 23, 2018 15:49

0xc0170 approved these changes Apr 26, 2018

View reviewed changes

ghost approved these changes Apr 26, 2018

View reviewed changes

jamesbeyond approved these changes Apr 26, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Apr 26, 2018

0xc0170 added needs: work and removed needs: CI labels Apr 26, 2018

cmonr added needs: CI and removed needs: work labels Apr 27, 2018

0xc0170 added needs: work and removed needs: CI labels Apr 27, 2018

0xc0170 force-pushed the feature-watchdog branch from 64dbd53 to 29d6dca Compare May 4, 2018 18:02

fkjagodzinski force-pushed the test_update-feature-watchdog branch from 58bebab to d856248 Compare May 7, 2018 08:29

0xc0170 added needs: CI and removed needs: work labels May 7, 2018

0xc0170 removed the ready for merge label May 8, 2018

cmonr added needs: review and removed needs: work labels May 21, 2018

ghost approved these changes May 21, 2018

View reviewed changes

cmonr added needs: CI and removed needs: review labels May 21, 2018

0xc0170 force-pushed the feature-watchdog branch from 29d6dca to 2b01e51 Compare May 22, 2018 11:10

fkjagodzinski added 2 commits May 22, 2018 14:28

Tests: Watchdog: Update test case teardown

8679119

Added a mechanism which will prevent an initialised watchdog from resetting the device during final greentea communication. This allows testing watchdog timeouts as short as 50 ms.

Tests: Watchdog: Decrease default timeout to 100 ms

1ef4621

fkjagodzinski force-pushed the test_update-feature-watchdog branch from e5b67f6 to 1ef4621 Compare May 22, 2018 12:31

cmonr added ready for merge and removed needs: CI labels May 22, 2018

cmonr merged commit a471244 into ARMmbed:feature-watchdog May 22, 2018

cmonr removed the ready for merge label May 22, 2018

fkjagodzinski deleted the test_update-feature-watchdog branch May 25, 2018 10:02

fkjagodzinski mentioned this pull request May 10, 2019

Feature-watchdog: missing commits #10559

Closed

fkjagodzinski mentioned this pull request Jun 6, 2019

Bring back the missing watchdog commits #10777

Merged

Update watchdog tests -- allow shorter timeouts #6709

Update watchdog tests -- allow shorter timeouts #6709

Uh oh!

Conversation

fkjagodzinski commented Apr 23, 2018

Description

Pull request type

Uh oh!

jamesbeyond left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Apr 26, 2018

Uh oh!

0xc0170 commented Apr 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbed-ci commented Apr 26, 2018

Triggering tests

Uh oh!

fkjagodzinski commented Apr 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbed-ci commented Apr 26, 2018

Uh oh!

mbed-ci commented Apr 27, 2018

Uh oh!

0xc0170 commented Apr 27, 2018

Uh oh!

fkjagodzinski commented May 7, 2018

Uh oh!

cmonr commented May 7, 2018

Uh oh!

mbed-ci commented May 7, 2018

Triggering tests

Uh oh!

mbed-ci commented May 7, 2018

Uh oh!

mbed-ci commented May 7, 2018

Uh oh!

fkjagodzinski commented May 15, 2018

Uh oh!

fkjagodzinski commented May 18, 2018

Uh oh!

cmonr commented May 21, 2018

Uh oh!

cmonr commented May 21, 2018

Uh oh!

mbed-ci commented May 22, 2018

Uh oh!

fkjagodzinski commented May 22, 2018

Uh oh!

0xc0170 commented May 22, 2018

Uh oh!

0xc0170 commented May 22, 2018

Uh oh!

fkjagodzinski commented May 22, 2018

Uh oh!

0xc0170 commented May 22, 2018

Uh oh!

mbed-ci commented May 22, 2018

Triggering tests

Uh oh!

mbed-ci commented May 22, 2018

Uh oh!

mbed-ci commented May 22, 2018

Uh oh!

Uh oh!

0xc0170 commented Apr 26, 2018 •

edited

Loading

fkjagodzinski commented Apr 26, 2018 •

edited

Loading