Bring back the missing watchdog commits #10777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fkjagodzinski, thank you for your changes. |
fkjagodzinski
force-pushed
the
fix-watchdog-missing_commits
branch
2 times, most recently
from
d918078 to
b95ceec
Compare
Added a mechanism which will prevent an initialised watchdog from resetting the device during final greentea communication. This allows testing watchdog timeouts as short as 50 ms.
Skip test cases with unsupported timeout values.
fkjagodzinski
force-pushed
the
fix-watchdog-missing_commits
branch
from
b95ceec to
c5ad70c
Compare
|
|
|
@ARMmbed/mbed-os-maintainers this PR is ready for the CI. |
jamesbeyond
approved these changes
Jun 14, 2019
0xc0170
approved these changes
Jun 14, 2019
0xc0170
added
needs: CI
release-version: feature branch
and removed
needs: review
labels
|
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
|
@ARMmbed/mbed-os-maintainers, #10839 is waiting for this PR to be merged. |
|
Hi @ARMmbed/mbed-os-maintainers, CI are successful, possible to merge this to feature branch ? 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bring back commits that were (incorrectly) dropped during one of
feature-watchdogrebases.Fixes #10559.
Original patch descriptions in #6709 and #7021.
NOTE: Marking this as a draft -- let's wait until #10645 is merged.Pull request type
Reviewers
@0xc0170 @jamesbeyond
Release Notes