Watchdog API update #10645

fkjagodzinski · 2019-05-23T14:12:43Z

Description

Bring changes from #10066 to feature-watchdog branch. Original description below:

Watchdog refactoring to multithreaded thread.
-Added API to register muliple threads to watchdog drivers
-Watchdog timeout reconfigures everytime whenever new register thread with longer timeout period
-New APIs for watchdog
wd_register(const osThreadId_t tid, const uint32_t timeout) to register to watchdog
wd_unregister(const osThreadId_t tid) to unregister to watchdog
kick(const osThreadId_t tid) to refresh the watchdog

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@rajkan01 @0xc0170 @donatieng @jeromecoutant @jamesbeyond

Release Notes

fkjagodzinski · 2019-05-23T14:20:49Z

I assume all the review comments of the original PR (#10066) have been addressed. The purpose of this PR is to re-run the CI tests after rebasing to current feature-watchdog.

ciarmcom · 2019-05-23T15:00:48Z

@fkjagodzinski, thank you for your changes.
@donatieng @0xc0170 @jamesbeyond @rajkan01 @ARMmbed/mbed-os-maintainers please review.

jamesbeyond

The changes already got reviewed, in #10066 , should be good.
We open this new PR only because Raj's on long holiday, we want to get this PR going and merged

mbed-ci · 2019-05-23T20:42:38Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

0xc0170 · 2019-05-23T20:45:33Z

The feature branch needs a rebase to get python3 fix (causing the failures here).

fkjagodzinski · 2019-05-24T11:31:05Z

The feature branch needs a rebase to get python3 fix (causing the failures here).

OK, a rebased feature-watchdog branch is in #10657 . This PR has to wait until #10657 passes all CI tests.

-Added API to register muliple threads to watchdog drivers -Watchdog timeout reconfigures everytime whenever new register thread with longer timeout period -New APIs for watchdog wd_register(const osThreadId_t tid, const uint32_t timeout) to register to watchdog wd_unregister(const osThreadId_t tid) to unregister to watchdog kick(const osThreadId_t tid) to refresh the watchdog

- mbed_watchdog_mgr has interface name mbed_wdog_manager_start(),mbed_wdog_manager_stop(),mbed_wdog_manager_kick() - HwWatchdog is going to attach with LowPowerTIcker for periodic callback functionality - mbed_wdog_manager_start() will either get start either by BL/RTOS Aps,it reads the timeout value specified via macro and macro gets defined in target.json file. - mbed_wdog_manager_start() internally configure below HAL hw watchdog with timeout specified via target.json - mbed_wdog_manager_start() internally divide the timeout(specified in target.json) by the 2 and attach LowPowerTicker with periodic callback of hw_kick() - mbed_wdog_manager_start() internally create one instance of sw watchdog class,to access the static list data structure of sw watchdog class - mbed_wdog_manager_kick() function periodically get called and refresh the hw watchdog to avoid watchdog reset - converted C++ code into C based APIs - added boolean to control watchdog start and stop - Added detach from ticker on stop API

-SW watchdog has interface name start(),stop(),kick() Sw watchdog internally has static list and shared across multiple instance of SW watchdog - Sw watchdog initialize timeout value,unique string via constructor whenever threads created sw watchdog object -Threads make sure pass proper timeout value,Unique string while creating the instance. -start() called by components(BLE,WIFI etc.,),it adds the entry into static list with few details current count ,etc., -kick() called by registered components(BLE,WIFI etc.) to reset current count to zero. -is_alive - interface API to mbed_watchdog_manager -implementation optimization

- Added Hw watchdog periodic kick calls software watchdog is_alive check

-Added the unit test case for testing Hw watchdog -Added the supported stubs files

-Added the mock class function to mock mbed_assert_internal -Added the unit test case to test start,kick,stop -Modified the interface api name from is_alive to process -added the unit test cases for process

- Changed the process into static method - used the singletonptr for creating the low power ticker instance - Added the mbed stub into cmake build for cellularnonipsocket,loramacrypto

-Modified the device dont have support of lp ticker will ticker for watchdog callback register

-Created global instance of either LowPowerTicker or Ticker

fkjagodzinski · 2019-06-03T14:58:14Z

OK, I rebased all commits to the current feature-watchdog (f4e6966).

This PR is ready for the CI.

jamesbeyond · 2019-06-04T07:42:20Z

@ARMmbed/mbed-os-maintainers please start CI if possible

0xc0170 · 2019-06-04T09:28:36Z

CI started

mbed-ci · 2019-06-04T10:11:19Z

Test run: FAILED

Summary: 6 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_mbed2-build-IAR
jenkins-ci/mbed-os-ci_mbed2-build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR

0xc0170 · 2019-06-04T10:20:32Z

Internal CI error, restarted

jamesbeyond · 2019-06-05T08:56:38Z

Can we have CI start on this again please? @ARMmbed/mbed-os-maintainers

0xc0170 · 2019-06-05T08:59:46Z

As soon as RC2 is completed, we can !

0xc0170 · 2019-06-06T07:55:34Z

CI restarted

0xc0170 · 2019-06-06T11:17:23Z

I had to abort the CI job, we are experiencing internal errors. investigating

mbed-ci · 2019-06-06T11:17:55Z

Test run: FAILED

Summary: 6 of 7 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_mbed2-build-IAR
jenkins-ci/mbed-os-ci_mbed2-build-ARM
jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR

0xc0170 · 2019-06-07T12:27:41Z

CI started

mbed-ci · 2019-06-07T14:15:16Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

Update the watchdog timing requirements: 1. The watchdog should trigger at, or after the timeout value. 2. The watchdog should trigger before twice the timeout value.

fkjagodzinski · 2019-06-11T09:25:35Z

I couldn't reproduce recent CI failures locally. Both:

NUCLEO_F429ZI-IAR.tests-mbed_platform-watchdog_mgr_reset
NUCLEO_F746ZG-ARMC6.tests-mbed_platform-watchdog_mgr_reset

failed the same assertion

:95::FAIL: Watchdog did not reset the device as expected.

which means 850 ms was not long enough for the watchdog to fire. As long as the watchdog fires before 1600 ms mark (twice the requested timeout) it's OK with new timing requirements (#8857 (comment)). The patch that updates watchdog timing tests is supposed to be merged after this PR, so to keep the history of this PR clean, I updated only the failed tests-mbed_platform-watchdog_mgr_reset.

@0xc0170 , this is ready for another CI run.

jamesbeyond · 2019-06-11T12:49:04Z

Hi @ARMmbed/mbed-os-maintainers, could you tag this PR for mbed-os 5.13.1? becasue this is expected to be delivered by then at least

SeppoTakalo · 2019-06-11T13:12:37Z

Functionality change can only be published in 5.14, not in patch release.

jamesbeyond · 2019-06-11T13:45:09Z

Functionality change can only be published in 5.14, not in patch release.

@SeppoTakalo
Yes, in principle it is, but this case might be an exception. @JanneKiiskila might be able to give some valid excuses for this exception.
But anyway, We'd need to have this PR landed on the master by 5.13.1 release time frame.

jamesbeyond · 2019-06-12T14:27:49Z

Seems all the tests are passed, can we merge this PR to feature branch ?

jamesbeyond · 2019-06-12T14:28:14Z

Seems all the tests are passed, can we merge this PR to feature branch ?

@ARMmbed/mbed-os-maintainers

0xc0170 · 2019-06-13T12:54:49Z

Let's get this moving along on the feature branch 👍

jeromecoutant mentioned this pull request May 23, 2019

STM32H7: WATCHDOG and RESET_REASON support #10466

Merged

ciarmcom requested review from 0xc0170, donatieng, jamesbeyond, rajkan01 and a team May 23, 2019 15:00

ciarmcom added the needs: review label May 23, 2019

jamesbeyond approved these changes May 23, 2019

View reviewed changes

0xc0170 force-pushed the feature-watchdog branch from 348e578 to f4e6966 Compare June 3, 2019 11:38

rajkan01 and others added 16 commits June 3, 2019 15:23

HW Watchdog and SW watchdog interface

3ea9521

- Added Hw watchdog periodic kick calls software watchdog is_alive check

Hw Watchdog UnitTest cases

eb98c38

-Added the unit test case for testing Hw watchdog -Added the supported stubs files

SW watchdog unittest cases

47030cd

-Added the mock class function to mock mbed_assert_internal -Added the unit test case to test start,kick,stop -Modified the interface api name from is_alive to process -added the unit test cases for process

fix: Fixing rebased created bugs

43c2647

Fix for the Ci build issue

f94eb3c

fix for spell check and header file

3c0cd62

fix for astyle

cd26a74

Incorporated the Reivew Comments

696638a

Incorporated the Reivew Comments

f672974

Update Watchdog

dfe4b53

- Changed the process into static method - used the singletonptr for creating the low power ticker instance - Added the mbed stub into cmake build for cellularnonipsocket,loramacrypto

Added the ticker support

33793e7

-Modified the device dont have support of lp ticker will ticker for watchdog callback register

Fixed the unittest case failure

c41d803

Fix for Problem copying the instance from BSS to stack

dc9fbfa

-Created global instance of either LowPowerTicker or Ticker

fkjagodzinski force-pushed the rajkan01-new_watchdog_api branch from 7a0abd1 to 19272b7 Compare June 3, 2019 14:36

0xc0170 added the release-version: feature branch label Jun 4, 2019

fkjagodzinski mentioned this pull request Jun 6, 2019

Bring back the missing watchdog commits #10777

Merged

Tests: Update Watchdog Manager test

98708d1

Update the watchdog timing requirements: 1. The watchdog should trigger at, or after the timeout value. 2. The watchdog should trigger before twice the timeout value.

0xc0170 approved these changes Jun 13, 2019

View reviewed changes

0xc0170 added ready for merge and removed needs: review labels Jun 13, 2019

0xc0170 merged commit e3bcf0c into ARMmbed:feature-watchdog Jun 13, 2019

0xc0170 removed the ready for merge label Jun 13, 2019

fkjagodzinski deleted the rajkan01-new_watchdog_api branch June 13, 2019 13:40

fkjagodzinski mentioned this pull request Jun 19, 2019

Feature watchdog v1 rb #10066

Closed

Watchdog API update #10645

Watchdog API update #10645

Uh oh!

Conversation

fkjagodzinski commented May 23, 2019

Description

Pull request type

Reviewers

Release Notes

Uh oh!

fkjagodzinski commented May 23, 2019

Uh oh!

ciarmcom commented May 23, 2019

Uh oh!

jamesbeyond left a comment

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented May 23, 2019

Test run: FAILED

Uh oh!

0xc0170 commented May 23, 2019

Uh oh!

fkjagodzinski commented May 24, 2019

Uh oh!

fkjagodzinski commented Jun 3, 2019

Uh oh!

jamesbeyond commented Jun 4, 2019

Uh oh!

0xc0170 commented Jun 4, 2019

Uh oh!

mbed-ci commented Jun 4, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Jun 4, 2019

Uh oh!

jamesbeyond commented Jun 5, 2019

Uh oh!

0xc0170 commented Jun 5, 2019

Uh oh!

0xc0170 commented Jun 6, 2019

Uh oh!

0xc0170 commented Jun 6, 2019

Uh oh!

mbed-ci commented Jun 6, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Jun 7, 2019

Uh oh!

mbed-ci commented Jun 7, 2019

Test run: FAILED

Uh oh!

fkjagodzinski commented Jun 11, 2019

Uh oh!

jamesbeyond commented Jun 11, 2019

Uh oh!

SeppoTakalo commented Jun 11, 2019

Uh oh!

jamesbeyond commented Jun 11, 2019

Uh oh!

jamesbeyond commented Jun 12, 2019

Uh oh!

jamesbeyond commented Jun 12, 2019

Uh oh!

0xc0170 commented Jun 13, 2019

Uh oh!

Uh oh!