Feature watchdog v1 rb #10066

rajkan01 · 2019-03-12T16:48:11Z

Watchdog refactoring to multithreaded thread.
-Added API to register muliple threads to watchdog drivers
-Watchdog timeout reconfigures everytime whenever new register thread with longer timeout period
-New APIs for watchdog
wd_register(const osThreadId_t tid, const uint32_t timeout) to register to watchdog
wd_unregister(const osThreadId_t tid) to unregister to watchdog
kick(const osThreadId_t tid) to refresh the watchdog

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mbed-os-hal

Release Notes

ciarmcom · 2019-03-12T18:00:41Z

@rajkan01, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

rajkan01 · 2019-03-12T18:13:28Z

This branch created on top of the latest origin/feature-watchdog and cherry picked all watchdog related changes from of feature-watchdog-v1 from PR
#9243

0xc0170 · 2019-03-13T10:28:03Z

Travis is green (was restarted)

drivers/Watchdog.h

UNITTESTS/target_h/platform/mbed_power_mgmt.h

UNITTESTS/platform/mbed_watchdog_mgr/test_mbed_watchdog_mgr.cpp

drivers/Watchdog.h

donatieng

Hey Rajkumar, thanks - looks good! My main interrogations are around the mock watchdog class which has empty function bodies.

UNITTESTS/platform/mbed_watchdog_mgr/Watchdog.cpp

drivers/Watchdog.cpp

drivers/Watchdog.h

platform/mbed_watchdog_mgr.cpp

UNITTESTS/drivers/Watchdog/test_watchdog.cpp

0xc0170

just 2 questions

platform/mbed_watchdog_mgr.h

platform/mbed_watchdog_mgr.cpp

rajkan01 · 2019-03-14T14:51:46Z

Initially we thought, But later we realized process method called by mbed watchdog manager

platform/mbed_watchdog_mgr.h

donatieng

Looks good to me but I think it would make sense to make process() static and not have a "platform" watchdog instance. I know you and @c1728p9 had a chat about it so there might be a rationale I'm missing!

0xc0170 · 2019-03-15T20:25:39Z

CI started

mbed-ci · 2019-03-15T20:30:50Z

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_unittests

c1728p9 · 2019-03-18T13:59:33Z

I think it would make sense to make process() static and not have a "platform" watchdog instance.

@donatieng I agree, process() should be static.

platform/mbed_watchdog_mgr.cpp

ithinuel

LGTM

NirSonnenschein · 2019-03-25T10:59:14Z

restarted CI

mbed-ci · 2019-03-25T11:42:47Z

Test run: FAILED

Summary: 6 of 9 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARMC5
jenkins-ci/mbed-os-ci_mbed2-build-IAR8
jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR8
jenkins-ci/mbed-os-ci_build-ARMC6

…mbed-os into feature-watchdog-v1-rb

jamesbeyond · 2019-04-24T14:19:13Z

targets/targets.json

@@ -7133,7 +7138,8 @@
        "macros_remove": ["MBEDTLS_CONFIG_HW_SUPPORT"],
        "overrides": {
            "lf_clock_src": "NRF_LF_SRC_RC"
-        }
+        },
+		"device_has_remove": ["RESET_REASON"]


Why not just remove RESET_REASON from MCU_NRF52840 ?

This reverts commit 3148e54.

…RF52_DK" This reverts commit c7768e5.

adbridge · 2019-05-01T11:58:24Z

@jamesbeyond @fkjagodzinski can you please re-review the latest updates ?

adbridge · 2019-05-07T15:04:39Z

CI restarted after last changes

mbed-ci · 2019-05-07T21:43:58Z

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 11
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_dynamic-memory-usage
jenkins-ci/mbed-os-ci_greentea-test

fkjagodzinski · 2019-05-08T15:22:49Z

Python3 had an issue with TESTS/host_tests/rtc_reset.py which is not part of this PR.

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/mbed_os_tools-0.0.8-py3.6.egg/mbed_os_tools/test/host_tests_runner/host_test_default.py", line 306, in run_test
    self.test_supervisor.setup()
  File "/builds/ws/mbed-os-ci_greentea-test@3/mbed-os/TESTS/host_tests/rtc_reset.py", line 43, in setup
    generator.next()
AttributeError: 'generator' object has no attribute 'next'

0xc0170 · 2019-05-10T07:55:31Z

CI started

0xc0170 · 2019-05-10T07:55:55Z

CI restarted (py3 should be fixed)

mbed-ci · 2019-05-10T12:05:33Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 12
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

fkjagodzinski · 2019-05-10T13:43:57Z

Same Python 3 issue again. We forgot to pull the changes from #10544. @rajkan01 could you cherry-pick that patch?

rajkan01 · 2019-05-10T14:00:12Z

@0xc0170 filip mentioned some more pyton3 fixes missed and needs rebase to master, Could you please rebase ARMMbed:feature-watchdog branch so that I can rebase this branch aginst feature-watchdog-v1-rb to resolve python3 issue

0xc0170 · 2019-05-12T19:29:51Z

There are multiple conflicts (targets.json mainly). I rebased the feature-watchdog branch - conflicts were easy to fix - I've noticed we need to clean up targets.json file - again multiple device_has on one line conflicts.

For future - provide forked rebased branch.

fkjagodzinski · 2019-06-19T10:16:55Z

@rajkan01, @ARMmbed/mbed-os-maintainers, this can be closed now. All changes from this PR are now merged to feature-watchdog through #10645.

rajkan01 changed the base branch from master to feature-watchdog March 12, 2019 16:48

ciarmcom requested a review from a team March 12, 2019 18:00

ciarmcom added the needs: review label Mar 12, 2019

This was referenced Mar 12, 2019

Feature watchdog #9840

Closed

Watchdog refactoring #9243

Closed

0xc0170 requested review from a user March 13, 2019 10:28

0xc0170 requested changes Mar 13, 2019

View reviewed changes

drivers/Watchdog.h Show resolved Hide resolved

UNITTESTS/target_h/platform/mbed_power_mgmt.h Show resolved Hide resolved

UNITTESTS/platform/mbed_watchdog_mgr/test_mbed_watchdog_mgr.cpp Outdated Show resolved Hide resolved

drivers/Watchdog.h Show resolved Hide resolved

donatieng suggested changes Mar 13, 2019

View reviewed changes

0xc0170 added the release-version: feature branch label Mar 14, 2019

0xc0170 approved these changes Mar 14, 2019

View reviewed changes

platform/mbed_watchdog_mgr.h Show resolved Hide resolved

platform/mbed_watchdog_mgr.cpp Outdated Show resolved Hide resolved

ithinuel reviewed Mar 14, 2019

View reviewed changes

platform/mbed_watchdog_mgr.h Show resolved Hide resolved

c1728p9 approved these changes Mar 15, 2019

View reviewed changes

fkjagodzinski mentioned this pull request Mar 15, 2019

Add Watchdog Manager tests #9586

Closed

donatieng approved these changes Mar 15, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Mar 15, 2019

cmonr added needs: work and removed needs: CI labels Mar 15, 2019

ithinuel reviewed Mar 18, 2019

View reviewed changes

platform/mbed_watchdog_mgr.cpp Outdated Show resolved Hide resolved

ithinuel approved these changes Mar 25, 2019

View reviewed changes

Merge branch 'feature-watchdog-v1-rb' of https://github.com/rajkan01/…

ecd4187

…mbed-os into feature-watchdog-v1-rb

jamesbeyond reviewed Apr 24, 2019

View reviewed changes

rajkan01 added 4 commits April 24, 2019 15:20

Removed the watchdog for NRF52

3148e54

Revert "Removed the watchdog for NRF52"

19e9193

This reverts commit 3148e54.

Revert "Removed the Watchdog and Reset reason for MTB_LAIRD_BL654 & N…

6b6b3f2

…RF52_DK" This reverts commit c7768e5.

Removed the RESETREASON on unsupported MCU_NRF52840

fdc1be5

donatieng mentioned this pull request Apr 25, 2019

Silabs EFM32 watchdog timeout values #8857

Closed

adbridge removed the needs: preceding PR label May 1, 2019

adbridge added needs: review and removed needs: work labels May 1, 2019

0xc0170 mentioned this pull request May 2, 2019

STM32H7: WATCHDOG and RESET_REASON support #10466

Merged

fkjagodzinski approved these changes May 6, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels May 6, 2019

0xc0170 added needs: work and removed needs: CI labels May 13, 2019

fkjagodzinski mentioned this pull request May 23, 2019

Watchdog API update #10645

Merged

0xc0170 force-pushed the feature-watchdog branch from 348e578 to f4e6966 Compare June 3, 2019 11:38

0xc0170 closed this Jun 25, 2019

Feature watchdog v1 rb #10066

Feature watchdog v1 rb #10066

Uh oh!

Conversation

rajkan01 commented Mar 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request type

Reviewers

Release Notes

Uh oh!

ciarmcom commented Mar 12, 2019

Uh oh!

rajkan01 commented Mar 12, 2019

Uh oh!

0xc0170 commented Mar 13, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

donatieng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rajkan01 commented Mar 14, 2019 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

donatieng left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Mar 15, 2019

Uh oh!

mbed-ci commented Mar 15, 2019

Test run: FAILED

Uh oh!

c1728p9 commented Mar 18, 2019

Uh oh!

Uh oh!

ithinuel left a comment

Choose a reason for hiding this comment

Uh oh!

NirSonnenschein commented Mar 25, 2019

Uh oh!

mbed-ci commented Mar 25, 2019

Test run: FAILED

Uh oh!

jamesbeyond Apr 24, 2019

Choose a reason for hiding this comment

Uh oh!

adbridge commented May 1, 2019

Uh oh!

adbridge commented May 7, 2019

Uh oh!

mbed-ci commented May 7, 2019

Test run: FAILED

Uh oh!

fkjagodzinski commented May 8, 2019

Uh oh!

0xc0170 commented May 10, 2019

Uh oh!

0xc0170 commented May 10, 2019

Uh oh!

mbed-ci commented May 10, 2019

Test run: FAILED

Uh oh!

fkjagodzinski commented May 10, 2019

Uh oh!

rajkan01 commented Mar 12, 2019 •

edited

Loading

rajkan01 commented Mar 14, 2019 via email •

edited

Loading

donatieng left a comment •

edited

Loading