Skip to content

Add Watchdog Manager tests #9586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fkjagodzinski
Copy link
Member

@fkjagodzinski fkjagodzinski commented Feb 1, 2019

Description

After the Watchdog driver update from #9243 #10066 the greentea tests also need an update:

  • remove tests-mbed_drivers-watchdog*,
  • add tests-mbed_platform-watchdog_mgr_reset.

Please note, this PR needs #10066 merged first to work.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@c1728p9 @rajkan01

@ciarmcom ciarmcom requested review from c1728p9, rajkan01 and a team February 1, 2019 18:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 1, 2019

@fkjagodzinski, thank you for your changes.
@c1728p9 @rajkan01 @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Feb 14, 2019

@c1728p9 @rajkan01 Please rereview.

@cmonr
Copy link
Contributor

cmonr commented Feb 14, 2019

@kegilbert Where's the error in this travis-ci/doxy-spellcheck job?

@cmonr
Copy link
Contributor

cmonr commented Feb 20, 2019

@fkjagodzinski Please fix drivers/Watchdog.h, which has a misspelling of succesfully

@kegilbert
Copy link
Contributor

@fkjagodzinski
Copy link
Member Author

Spelling fixed. ✔️

Filip Jagodzinski added 2 commits April 10, 2019 18:48
The Watchdog driver has been updated making these tests incompatible
with the new API. The Watchdog driver functionality is tested with the
unit tests located in UNITTESTS/drivers/Watchdog/ .
@fkjagodzinski fkjagodzinski force-pushed the test_update-watchdog_mgr branch from acddd2a to 8087c3d Compare April 10, 2019 16:49
@fkjagodzinski
Copy link
Member Author

Minor update:

  • rebased the code to current feature-watchdog,
  • replaced the wait_ms() calls with wait() inside critical sections.

The Watchdog driver has been updated making this test incompatible
with the new API. Use HAL API instead.
@mbed-ci
Copy link

mbed-ci commented Apr 16, 2019

Test run: FAILED

Summary: 3 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@fkjagodzinski
Copy link
Member Author

rajkan01#1 has been merged and Watchdog Manager tests are now included in #10066.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants