Target support for Infineon's XMC 4XXX family. #6730

mbed-Infineon-XMC · 2018-04-24T13:26:47Z

Description

Add target support for Infineon's XMC 4XXX MCU familiy.

Tested with the XMC 4500 Relax Kit development board and the ARM GCC toolchain.
Tested serveral examples which are available here: https://github.com/mbed-Infineon-XMC

Pull request type

[ ] Fix
[ ] Refactor
[x] New target
[ ] Feature
[ ] Breaking change

0xc0170 · 2018-04-24T14:14:15Z

@mbed-Infineon-XMC Hi, thanks for the contribution ! We are going to review this soon.

Can you look at the travis failure?

Tested with the XMC 4500 Relax Kit development board and the ARM GCC toolchain.

Can you attach the test results here? We recommend testing all 3 toolchains

0xc0170 · 2018-04-25T09:15:39Z

Please ignore PR head for now (not related to this pull request). But travis still fails after the last updates.

0xc0170 · 2018-04-25T09:17:51Z

targets/TARGET_Infineon/TARGET_XMC4XXX/TARGET_XMC4500/PinNames.h

+    SW2     = P1_15,
+    USBTX   = P0_5,
+    USBRX   = P0_4,
+#endif


why is this protected with relax kit ?

I assume this file is generic for MCU family and this is the addition for a target that has this specific definitions?

0xc0170 · 2018-04-25T09:18:36Z

targets/targets.json

@@ -4007,5 +4007,26 @@
        "detect_code": ["7013"],
        "release_versions": ["5"],
        "bootloader_supported": true
-    }
+    },
+	"XMC_XXXX": {


misaligned line?

0xc0170 · 2018-04-25T09:19:09Z

targets/targets.json

+		"macros_add": ["XMC4500_F100x1024", "XMC4500_Relax_Kit", "XMC_ETH_PHY_KSZ8031RNL", "USE_LWIP"],
+		"features_add": ["LWIP"],
+        "OUTPUT_EXT": "hex",
+		"device_name": "XMC4500"


can you fix alignment for XMC4500, line 4030, 4028 and 4027

0xc0170 · 2018-04-25T09:20:32Z

targets/TARGET_Infineon/TARGET_XMC4XXX/flash_api.c

+ */
+int32_t flash_program_page(flash_t *obj, uint32_t address, const uint8_t *data, uint32_t size){
+
+    XMC_FLASH_ProgramPage((uint32_t *)address, (uint32_t *)data);


XMC_FLASH function do not return anything , that these functions here always return 0

Function should always return 0. The low level function 'XMC_FLASH_programPage()' is a void function so I get no meaningful return value.
I know it's not a good pratice... However, I do not want to make any changes in the low level hardware library provided by Infineon. (XMC Lib)

0xc0170 · 2018-04-25T09:21:20Z

targets/TARGET_Infineon/TARGET_XMC4XXX/flash_api.c

+ */
+int32_t flash_init(flash_t *obj){
+
+    return 0;


does not need any init? neither free?

Same as i 'flash_program_page'. Flash driver not need any initialization!

0xc0170 · 2018-04-25T09:21:37Z

targets/TARGET_Infineon/TARGET_XMC4XXX/flash_api.c

+ *
+ * @param obj The flash object
+ * @return 0 for success, -1 for error
+ */


why are doxygen doc being copied to the implementation?

I will remove the doxygen doc in all files!

0xc0170 · 2018-04-25T09:23:13Z

targets/TARGET_Infineon/TARGET_XMC4XXX/rtc_api.c

+/** Initialize the RTC peripheral
+ *
+ */
+void rtc_init(void){


{ new line for function body, al lfunctions in this file should be updated

0xc0170 · 2018-04-25T09:23:45Z

targets/TARGET_Infineon/TARGET_XMC4XXX/sleep_api.c

+//    // Configure system during SLEEP state
+//    XMC_SCU_CLOCK_SetSleepConfig(XMC_SCU_CLOCK_SLEEP_MODE_CONFIG_SYSCLK_FPLL); //TODO: why pll clock is divided by 2
+//
+//    // Make sure that SLEEPDEEP bit is cleared


why sleep and deepsleep is empty?

the dead code should be removed

0xc0170 · 2018-04-25T09:30:22Z

targets/TARGET_Infineon/TARGET_XMC4XXX/i2c_api.c

+/* pin configuration for i2c sdc */
+XMC_GPIO_CONFIG_t i2c_scl_pin_cfg =
+{
+        .output_strength = XMC_GPIO_OUTPUT_STRENGTH_MEDIUM


8 spaces instead of 4?

see https://os.mbed.com/docs/v5.8/reference/style.html

mbed-Infineon-XMC · 2018-04-25T11:34:01Z

@0xc0170 Hi, thanks for reviewing the source code. I will fix these issues...

I'm new with Travis CI, is there a way to execute the travis tests on my local workstation?
It's hard for me to understand the travis log output and what those travis tests are exactly doing.

Thanks

0xc0170 · 2018-04-25T11:37:14Z

I'm new with Travis CI, is there a way to execute the travis tests on my local workstation?
It's hard for me to understand the travis log output and what those travis tests are exactly doing.

I reviewed them. Based on the errors, I would start with fixing the alignment in the targets.json file that I pointed above in my review. One of the CI failures is on the line 4032 as I noticed.

you can run them locally. There's .travis.yaml that contains the commands that travis executes. You can reproduce those locally (sometimes they contain some travis specific variables that you might need to replace with known values).

0xc0170 · 2018-04-26T09:11:23Z

Travis is now green 👍

Can you answer my questions above?

0xc0170 · 2018-04-27T09:41:53Z

targets/TARGET_Infineon/tools/RingBuff.h

+ * limitations under the License.
+ */
+
+// library provided by https://github.com/wizard97/Embedded_RingBuf_CPP


As this is taken from there, should this file b e unde the same license, MIT ? We provide circular bufferin platform folder, is not sufficient or?

Where is class this used?

OK... I will use the Circular Buffer implementation which is already available in mbed-os/platform.
Have overlooked this class :)

0xc0170 · 2018-04-27T09:43:12Z

targets/TARGET_Infineon/tools/RingBuff.h

+#define MBED_OS_CIRCULAR_BUFFER_H_
+
+#include "mbed.h"
+#include "rtos.h"


include what is needed , rtos and mbed header files are for an application space. This would cause inclusion of unnecessary files

0xc0170 · 2018-05-03T15:11:52Z

@mbed-Infineon-XMC Looking at the USB. why is it in targets? are those files used anywhere? I would assume not, thus could be removed. And USB support should come as separate PR.

There is feature usb branch, that is bringing USB support.

mbed-Infineon-XMC · 2018-05-06T18:27:35Z

@0xc0170 I removed the USB functionality...
I will add USB support for the XMC familiy at a later time to the USB feature branch!

0xc0170 · 2018-05-07T08:11:05Z

/morph build

mbed-ci · 2018-05-07T08:49:39Z

Build : SUCCESS

Build number : 1925
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6730/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-07T10:43:47Z

Test : SUCCESS

Build number : 1746
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6730/1746

mbed-ci · 2018-05-07T11:19:57Z

Exporter Build : SUCCESS

Build number : 1570
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6730/

0xc0170 · 2018-05-07T11:32:47Z

/morph mbed2-build

cmonr · 2018-05-07T15:49:30Z

@ashok-rao We'll wait a day or two since you were at GEC. Otherwise, it's ready to go!

ashok-rao · 2018-05-07T18:48:51Z

Thanks @cmonr , will look at this tomorrow!

cmonr · 2018-05-08T01:11:36Z

@mbed-Infineon-XMC In the meanwhile, did you ever answer @0xc0170's request to post test results?

ashok-rao · 2018-05-08T11:15:50Z

targets/TARGET_Infineon/TARGET_XMC4XXX/TARGET_XMC4500/PinNames.h

+
+    USBTX   = P0_5,
+    USBRX   = P0_4,
+


@mbed-Infineon-XMC , what about other peripherals? Can you please add pin maps for any other peripherals that are brought out like SPI, I2C..?

USBTX and USBRX are useful because they are needed for the standard serial output.
Do not think that it make sense to declare default pin maps for I2C, SPI etc..
The application programmer must always now what he has connected to a specific pin.
In my view this makes only sense for development boards where Led's, Buttons or other peripehrals are fix connected. As i see, other target implementations have a similar style!
How do you think about that?

Isn't the XMC4500 going to be supplied as a development board? Or is this going to be a build only target in Mbed OS and the HW implementation is left to the user? Could you please clarify @mbed-Infineon-XMC . If there is a board with this MCU, then the peripheral pins must be defined here for application code to use.. something like: FileSystem sd(SPI_MOSI, SPI_MISO....) that needs the peripheral pins defined here to be used later in main.cpp ..

ashok-rao · 2018-05-08T16:04:30Z

targets/targets.json

+    "XMC_XXXX": {
+        "inherits": ["Target"],
+        "extra_labels": ["Infineon", "XMCLib"],
+        "supported_toolchains": ["GCC_ARM", "ARM"],


No support for IAR? if yes, you may want to add linker scripts for IAR as well.
@0xc0170 : Is IAR support mandatory or optional?

IAR support is mandatory, as without it tests and export builds will fail with IAR.

For reference: #6043 (comment)

@mbed-Infineon-XMC ..Could you please add IAR support as well. You will need to add the linker scripts too under ../device/TOOLCHAIN_IAR/

ARM compiler also not supported yet!
I will add support for IAR and ARM in the next days.
Should the Exporter & build test not fail if there is no support for all 3 toolchains?

@mbed-Infineon-XMC : The Mbed Enabled requirement is to have support for all 3 toolchains. The CI systems also test the targets against these 3 toolchains. So, if any 1/3 is not present, it will fail :-)

cmonr · 2018-05-23T01:08:28Z

@mbed-Infineon-XMC Fyi, if IAR and ARM compilers aren't supported, they'll fail hte ci-morph-test and ci-morph-exporter tests.

cmonr · 2018-05-29T16:05:59Z

@mbed-Infineon-XMC @ashok-rao Closing this PR due to lack of activity.

Feel free to reopen once updates are available.

hackdino added 2 commits April 24, 2018 11:41

Add support for Infineon's XMC 4XXX family

2486763

Remove typo

fc353af

0xc0170 added the needs: review label Apr 24, 2018

0xc0170 added the scope: new-target label Apr 24, 2018

hackdino added 4 commits April 24, 2018 20:48

Change device name in targets.json

cafd0a1

Change targets.json

1eeaaab

Change targets.json

6d69604

Add Infineon support in build_travis.py

4a8dd85

0xc0170 added needs: work and removed needs: review labels Apr 25, 2018

0xc0170 requested changes Apr 25, 2018

View reviewed changes

hackdino added 3 commits April 25, 2018 19:05

Remove tabs

ca1440c

Remove last comma

99a036d

Remove device name

80d85d7

hackdino added 4 commits April 26, 2018 21:18

Add target for the XMC4500 RELAX KIT board.

9747a5b

Remove 8 spaces and replace with 4.

696f1dc

Remove doxygen doc and apply new line for function body.

f26474f

Remove sleep & deep_sleep functionality.

73a655a

cmonr added needs: review and removed needs: work labels Apr 27, 2018

0xc0170 requested changes Apr 27, 2018

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Apr 27, 2018

hackdino added 2 commits April 28, 2018 21:01

Relocate RingBuff.h to VirtualSerial folder.

8f27513

Replace RingBuff implementation with mbed CircularBuffer.

46a815c

adbridge added needs: review and removed needs: work labels Apr 30, 2018

0xc0170 added needs: work and removed needs: review labels May 3, 2018

Remove USB functionality!

4527e65

0xc0170 previously approved these changes May 7, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels May 7, 2018

0xc0170 requested a review from ashok-rao May 7, 2018 08:11

cmonr added needs: review and removed needs: CI labels May 7, 2018

ashok-rao reviewed May 8, 2018

View reviewed changes

Remove ARM compiler support!

41a44d7

mbed-Infineon-XMC dismissed 0xc0170’s stale review via 41a44d7 May 8, 2018 20:16

cmonr added needs: work and removed needs: review labels May 10, 2018

cmonr closed this May 29, 2018

Target support for Infineon's XMC 4XXX family. #6730

Target support for Infineon's XMC 4XXX family. #6730

Uh oh!

Conversation

mbed-Infineon-XMC commented Apr 24, 2018

Description

Pull request type

Uh oh!

0xc0170 commented Apr 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Apr 25, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbed-Infineon-XMC commented Apr 25, 2018

Uh oh!

0xc0170 commented Apr 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Apr 26, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented May 3, 2018

Uh oh!

mbed-Infineon-XMC commented May 6, 2018

Uh oh!

0xc0170 commented May 7, 2018

Uh oh!

mbed-ci commented May 7, 2018

Triggering tests

Uh oh!

mbed-ci commented May 7, 2018

Uh oh!

mbed-ci commented May 7, 2018

Uh oh!

0xc0170 commented May 7, 2018

Uh oh!

cmonr commented May 7, 2018

Uh oh!

ashok-rao commented May 7, 2018

Uh oh!

cmonr commented May 8, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmonr May 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

0xc0170 commented Apr 24, 2018 •

edited

Loading

0xc0170 commented Apr 25, 2018 •

edited

Loading

cmonr May 8, 2018 •

edited

Loading