add support for the RAK811 #6043

ithinuel · 2018-02-08T17:46:43Z

Description

This adds support for the lora module RAK811.

This has been tested with our beloved blinky flashed with openocd.

Todo

Update python scripts to run tests

kivaisan · 2018-02-15T06:32:28Z

targets/TARGET_STM/TARGET_STM32L1/TARGET_MTB_RAK811/device/system_clock.c

+    RCC_OscInitStruct.OscillatorType      = RCC_OSCILLATORTYPE_HSI;
+    RCC_OscInitStruct.HSEState            = RCC_HSE_OFF;
+    RCC_OscInitStruct.HSIState            = RCC_HSI_ON;
+    // SYSCLK = 32 MHz ((16 MHz * 4) / 2)


HSI calibration value is missing. Add:
RCC_OscInitStruct.HSICalibrationValue = RCC_HSICALIBRATION_DEFAULT;

kivaisan · 2018-02-15T06:33:36Z

targets/TARGET_STM/TARGET_STM32L1/TARGET_MTB_RAK811/PinNames.h

+
+    ANT_CTX_PA  = PA_4,
+    ANT_CRX_RX  = PB_6,
+    ANT_CBT_HF  = PB_7,


Is ANT_CBT_HF a lora pin? Instead Lora needs:
RF_TCXO_EN = PH_1,

I have CBT_HF from : https://github.com/RAKWireless/RAK811_BreakBoard/blob/1d5483aef2c691640db747fb230ceeb96acb378b/src/boards/RAK811BreakBoard/board.h#L96
However I have no idea about what those pins are as I don't know (yet) lora at all.

kivaisan · 2018-02-19T11:51:47Z

This is now ok for our lora example application.

0xc0170 · 2018-02-19T12:57:33Z

NEED WORK

What does need work for this pull request?

ithinuel · 2018-02-19T13:08:59Z

As stated in the Todo list Update python scripts to run tests at least unless it's not mandatory.

ithinuel · 2018-02-19T13:21:15Z

Also @jeromecoutant are the modifications to spi_api.c and hal_tick_16b.c ok ?

jeromecoutant

Lots of pins are missing in the PeripheralPins.c file ?

jeromecoutant · 2018-02-19T13:47:04Z

targets/TARGET_STM/TARGET_STM32L1/spi_api.c

@@ -59,7 +59,9 @@ int spi_get_clock_freq(spi_t *obj) {
 			spi_hz = HAL_RCC_GetPCLK2Freq();
 			break;
 		case SPI_2:
-		case SPI_3:
+#ifdef SPI_3


There is no SPI_3 in STM32L151CB

ithinuel · 2018-02-19T14:27:58Z

@jeromecoutant that's because I only exposed the "usable" peripheral depending on what's actually wired in and out the module.

0xc0170 · 2018-02-21T14:37:40Z

As stated in the Todo list Update python scripts to run tests at least unless it's not mandatory.

When will be these added? Is it travis CI addition, any other?

cmonr · 2018-02-27T06:08:50Z

@ithinuel?

ithinuel · 2018-03-05T10:41:06Z

Sorry for the delay,
@0xc0170 : Indeed they all seem to be related to CI tests.
@cmonr @0xc0170 : I can't work on this anymore, I have to hand it over.

0xc0170 · 2018-03-12T14:35:42Z

Looking at the additions here. What we are missing are tests results.

@kivaisan Can you run tests for all 3 toolchains? or @ithinuel who could help

kivaisan · 2018-03-13T09:26:02Z

Here are the results with the latest mbed-os. Some problems with GCC and ARMCC

test_report_armcc.txt
test_report_gcc.txt
test_report_iar.txt

adbridge · 2018-03-21T16:04:33Z

@ashok-rao Are the PE team now taking responsibility for this port ??

ashok-rao · 2018-03-23T12:11:50Z

@adbridge .. sorry for late reply..this is still in discussion.. Will update as soon as I can. Thanks.

ithinuel · 2018-03-23T17:50:42Z

@ARMmbed/team-st-mcd

Could you please check the FLASHSIZE_BASE value as it reports 0x6280 on my platform ?

bcostm · 2018-03-26T07:43:13Z

The FLASHSIZE_BASE defined in the stm32l151xb.h file is correct:
#define FLASHSIZE_BASE ((uint32_t)0x1FF8004CU)

I have no idea why you have 0x6280 on your platform ?

ithinuel · 2018-03-26T10:20:02Z

@bcostm The only thing I know is that I have a STM32L151CBU6A and that I read with gdb :

(gdb) p (uint32_t)(*((uint16_t *)((uint32_t)0x1FF8004C)) * 1024)
$1 = 25821184

because :

(gdb) p /x *((uint16_t *)((uint32_t)0x1FF8004C))
$2 = 0x6280

ithinuel · 2018-03-26T12:50:40Z

My device ID is 0x10386429 which describes a Cat.2 device where only the LSB represents the Flash size, hence the 0x6280 being invalid.

However the HAL only provides a way to read 16bit.

And according to the reference manual, the HAL is probably also wrong for the devices where devid=0x436.

bcostm · 2018-03-26T13:43:08Z

I looked in the stm32l1xx_ll_utils.h file and there is a note in the LL_GetFlashSize function:

@note For DEV_ID = 0x429, only LSB part of F_SIZE: F_SIZE[7:0] is valid. The MSB part
F_SIZE[15:8] is reserved and must be ignored.

So I suppose your device is a 0x429 (last digits). The size is only on the 8 first bits and you read 0x6280
--> 0x80 = 128KB

ithinuel · 2018-03-26T14:01:59Z

I base my research on what STM32Cube has generated but it seems that the stm_hal in mbed is outdated compared to what STM32Cube "generates".

@ARMmbed/team-st-mcd How would you fix that issue ?

I'll try to backport the difference between stm32l151xb.h and stm32l151xba.h to our current version.

ithinuel · 2018-03-26T14:03:22Z

@bcostm Indeed, also uint32_t flash_get_size(const flash_t *obj) from flash_api.c directly uses FLASH_SIZE.

bcostm · 2018-03-26T14:53:18Z

it seems that the stm_hal in mbed is outdated compared to what STM32Cube "generates".

The update of the STM32L1 HAL driver in mbed is in our plan. We should do it in the coming weeks.

ithinuel · 2018-03-27T09:51:11Z

"Fixing" this issue raised another one in multithreaded access to the NVStore.
I disable the FLASH feature for now. If anyone needs this, they may need to address that issue first.

test_report_armc6.txt
test_report_gcc.txt
All tests pass

mbed-ci · 2018-03-27T16:14:42Z

Build : FAILURE

Build number : 1585
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6043/

ithinuel · 2018-03-27T16:17:21Z

@cmonr What kind of failure is that ?

cmonr · 2018-03-27T16:25:07Z

That is a completely new type of CI failure. Don't think it's PR related.

studavekar · 2018-03-27T16:30:45Z

@cmonr What kind of failure is that ?

From logs looks like support for IAR toolchian is missing

Traceback (most recent call last):
  File "/builds/ws/mbed-os-pipeline/tools/make.py", line 191, in <module>
    print(mcu_toolchain_matrix(platform_filter=options.general_filter_regex))
  File "/builds/ws/mbed-os-pipeline/tools/build_api.py", line 1264, in mcu_toolchain_matrix
    version_release_targets[version] = get_mbed_official_release(version)
  File "/builds/ws/mbed-os-pipeline/tools/build_api.py", line 288, in get_mbed_official_release
    raise InvalidReleaseTargetException(reason)
tools.utils.InvalidReleaseTargetException: Target 'MTB_RAK811' must support ALL of the folowing toolchains to be included in the mbed OS 5.0 official release: ARM, GCC_ARM, IAR
Currently it is only configured to support the following toolchains: ARM, GCC_ARM

cmonr · 2018-03-27T16:32:04Z

@ithinuel Looks like I spoke too soon. The build job failed before actually building anything.

The CI expects GCC_ARM, ARM, and IAR to be all supported toolchains.

studavekar · 2018-03-27T16:33:17Z

@ithinuel Looks like I spoke too soon. The build job failed before actually building anything.

The CI expects GCC_ARM, ARM, and IAR to be all supported toolchains.

@cmonr Is it mbed-os requirements to support all 3 toolchain ?

ithinuel · 2018-03-27T16:39:02Z

@cmonr @studavekar a lot of platform does not support all 3, non-exhaustive list :

SSCI824
LPC4337
TEENSY3_1
MTS_GAMBIT
DISCO_F401VC

studavekar · 2018-03-27T16:52:25Z

@cmonr @studavekar a lot of platform does not support all 3, non-exhaustive list :

SSCI824
LPC4337
TEENSY3_1
MTS_GAMBIT
DISCO_F401VC

Doesn't look like it shows up in the supported list. Or am I missing something?

➜  mbed-os git:(mbed-os-5.8.0-rc2) ✗ mbed target --supported | grep -i 'LPC4337\|SSCI824\|TEENSY3_1\|MTS_GAMBIT\|DISCO_F401VC\|K22f\|K64F'
| K22F                 | Supported | Supported | Supported | Supported | Supported | Supported |
| K64F                 | Supported | Supported | Supported | Supported | Supported | Supported |

ashok-rao · 2018-03-27T16:52:46Z

https://www.mbed.com/en/about-mbed/mbed-enabled/mbed-enabled-program-requirements/ .. all 3 toolchains MUST be supported for Mbed Enabled..

ithinuel · 2018-03-27T16:54:40Z

@ashok-rao Thank you, i'll add IAR then.

@studavekar they are in targets/targets.json

cmonr · 2018-03-28T04:04:39Z

/morph build

mbed-ci · 2018-03-28T05:20:25Z

Build : SUCCESS

Build number : 1603
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6043/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-03-28T09:30:04Z

Exporter Build : FAILURE

Build number : 1235
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6043/

mbed-ci · 2018-03-28T11:44:43Z

Test : FAILURE

Build number : 1389
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6043/1389

bcostm · 2018-03-28T12:13:21Z

Just a note concerning:

DISCO_F401VC
Doesn't look like it shows up in the supported list. Or am I missing something?

Only the GCC_ARM compiler is supported on this board because this board is not mbed enabled (you can see that the "release_versions" property in targets.json is not present). This explains why.

ithinuel · 2018-03-28T12:54:38Z

@bcostm Thanks ! I still have things to learn about targets.json :P

cmonr · 2018-03-28T18:41:45Z

/morph build

mbed-ci · 2018-03-28T19:17:02Z

Build : SUCCESS

Build number : 1622
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6043/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-03-28T21:55:43Z

Exporter Build : SUCCESS

Build number : 1251
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6043/

mbed-ci · 2018-03-29T08:13:48Z

Test : SUCCESS

Build number : 1404
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6043/1404

cmonr

LGTM

cmonr · 2018-03-30T00:28:55Z

targets/TARGET_STM/TARGET_STM32L1/TARGET_MTB_RAK811/device/system_clock.c

+{
+    if (SetSysClock_PLL_HSI() == 0) {
+        while(1) {
+            // [TODO] Put something here to tell the user that a problem occured...


I look forward to the day where this line is replaced on the other STM devices along with this.

cmonr added the needs: work label Feb 9, 2018

kivaisan reviewed Feb 15, 2018

View reviewed changes

jeromecoutant approved these changes Feb 19, 2018

View reviewed changes

0xc0170 added the scope: new-target label Feb 19, 2018

ithinuel added 2 commits March 23, 2018 10:19

add support for the RAK811

758f3b2

add RF_TXCO_EN on PH1 and set HSI calibration to its default value

495f8e4

ithinuel added 2 commits March 26, 2018 18:00

switch to stm32l151cb-a & work around flash size field width.

c316763

add the target to travis build script & sw4stm32 export script.

78d73a1

ithinuel dismissed cmonr’s stale review via 751d5a7 March 27, 2018 16:55

add IAR to the supported toolchain

85af9f9

theotherjimmy added needs: review and removed needs: CI labels Mar 29, 2018

cmonr approved these changes Mar 30, 2018

View reviewed changes

cmonr merged commit c8bd08f into ARMmbed:master Mar 30, 2018

ithinuel deleted the add-rak811 branch March 30, 2018 07:09

adbridge added release-version: 5.8.2 and removed needs: review labels Apr 9, 2018

cmonr mentioned this pull request May 8, 2018

Target support for Infineon's XMC 4XXX family. #6730

Closed

add support for the RAK811 #6043

add support for the RAK811 #6043

Uh oh!

Conversation

ithinuel commented Feb 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Todo

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kivaisan commented Feb 19, 2018

Uh oh!

0xc0170 commented Feb 19, 2018

Uh oh!

ithinuel commented Feb 19, 2018

Uh oh!

ithinuel commented Feb 19, 2018

Uh oh!

jeromecoutant left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ithinuel commented Feb 19, 2018

Uh oh!

0xc0170 commented Feb 21, 2018

Uh oh!

cmonr commented Feb 27, 2018

Uh oh!

ithinuel commented Mar 5, 2018

Uh oh!

0xc0170 commented Mar 12, 2018

Uh oh!

kivaisan commented Mar 13, 2018

Uh oh!

adbridge commented Mar 21, 2018

Uh oh!

ashok-rao commented Mar 23, 2018

Uh oh!

ithinuel commented Mar 23, 2018

Uh oh!

bcostm commented Mar 26, 2018

Uh oh!

ithinuel commented Mar 26, 2018

Uh oh!

ithinuel commented Mar 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bcostm commented Mar 26, 2018

Uh oh!

ithinuel commented Mar 26, 2018

Uh oh!

ithinuel commented Mar 26, 2018

Uh oh!

bcostm commented Mar 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ithinuel commented Mar 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbed-ci commented Mar 27, 2018

Uh oh!

ithinuel commented Mar 27, 2018

Uh oh!

cmonr commented Mar 27, 2018

Uh oh!

studavekar commented Mar 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Mar 27, 2018

Uh oh!

studavekar commented Mar 27, 2018

Uh oh!

ithinuel commented Mar 27, 2018

Uh oh!

ithinuel commented Feb 8, 2018 •

edited

Loading

ithinuel commented Mar 26, 2018 •

edited

Loading

bcostm commented Mar 26, 2018 •

edited

Loading

ithinuel commented Mar 27, 2018 •

edited

Loading

studavekar commented Mar 27, 2018 •

edited

Loading