Skip to content

Wise 1510 uart config #6803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Conversation

chuanga
Copy link
Contributor

@chuanga chuanga commented May 3, 2018

Description

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented May 4, 2018

@chuanga Can you please clean the history (there should be one commit only) ?

@cmonr cmonr requested a review from ithinuel May 7, 2018 16:02
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the commit history to be swashed into a single commit, since the change-set is small.

@ithinuel
Copy link
Member

ithinuel commented May 7, 2018

@cmonr I even think a simple git cherry-pick 1051e33 on top of master should work fine.
@chuanga you'd have to force push to the branch.
You can also fetch it from the branch on my fork.

@chuanga chuanga force-pushed the wise-1510-uart-config branch from 1051e33 to 6caf68b Compare May 25, 2018 06:21
@chuanga chuanga closed this May 25, 2018
@chuanga chuanga force-pushed the wise-1510-uart-config branch from 6caf68b to 2eac96e Compare May 25, 2018 08:20
@chuanga chuanga reopened this May 25, 2018
@chuanga
Copy link
Contributor Author

chuanga commented May 25, 2018

I tried to rebase and recommit changes. I hope this is now ok

@cmonr
Copy link
Contributor

cmonr commented May 31, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 31, 2018

Build : SUCCESS

Build number : 2203
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6803/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 31, 2018

@cmonr
Copy link
Contributor

cmonr commented May 31, 2018

Interesting. Looks like this was hit with a bug this PR is aiming to fix: #7070

Will rerun in the case that it happens to not show up again.
/morph test

@mbed-ci
Copy link

mbed-ci commented Jun 1, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 1, 2018

@adbridge adbridge merged commit 9986abe into ARMmbed:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants