Skip to content

set the tolerance to 5% if NO_SYSTICK is enabled #7070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2018
Merged

set the tolerance to 5% if NO_SYSTICK is enabled #7070

merged 1 commit into from
Jun 4, 2018

Conversation

ithinuel
Copy link
Member

@ithinuel ithinuel commented May 31, 2018

Description

Fixes the issue raised on CI on the NRF 51 device.
The value of 5% is chosen to match the tolerance applied to lp_tickers that are also often RTC-backed.

Related PR

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@adbridge
Copy link
Contributor

@ithinuel Looks like a possible real error on pr-head:

Build failures:

  * K64F::ARM::TESTS-MBED_DRIVERS-TIMER

        Building project timer (K64F, ARM)

        Scan: ARM

        Scan: timer

        Scan: FEATURE_LWIP

        Scan: FEATURE_STORAGE

        Compile [100.0%]: main.cpp

        [Error] main.cpp@415,0:  #19: extra text after expected end of number

        [Error] main.cpp@437,0:  #19: extra text after expected end of number

        [Error] main.cpp@458,0:  #19: extra text after expected end of number

        [Error] main.cpp@480,0:  #19: extra text after expected end of number

        [Error] main.cpp@509,0:  #19: extra text after expected end of number

        [Error] main.cpp@527,0:  #19: extra text after expected end of number

        [Error] main.cpp@611,0:  #19: extra text after expected end of number

        [Error] main.cpp@648,0:  #19: extra text after expected end of number

        [Error] main.cpp@675,0:  #19: extra text after expected end of number

        [Error] main.cpp@730,0:  #19: extra text after expected end of number

@adbridge adbridge requested a review from a team May 31, 2018 12:00
@cmonr
Copy link
Contributor

cmonr commented May 31, 2018

/morph build

@cmonr cmonr mentioned this pull request May 31, 2018
@mbed-ci
Copy link

mbed-ci commented Jun 1, 2018

Build : SUCCESS

Build number : 2214
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7070/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 1, 2018

Test : SUCCESS

Build number : 2007
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7070/2007

@mbed-ci
Copy link

mbed-ci commented Jun 1, 2018

@cmonr
Copy link
Contributor

cmonr commented Jun 2, 2018

/morph uvisor-test

@cmonr
Copy link
Contributor

cmonr commented Jun 2, 2018

/morph uvisor-test

1 similar comment
@cmonr
Copy link
Contributor

cmonr commented Jun 3, 2018

/morph uvisor-test

@maciejbocianski
Copy link
Contributor

This bug(test failures) likely arose when NRF51 us_ticker implementation was changed from rtc to timer based (9ef0083). Before both lp_ticker and us_ticker were rtc based

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2018

/morph uvisor-test

@c1728p9 c1728p9 mentioned this pull request Jun 4, 2018
@cmonr cmonr merged commit 583d77f into ARMmbed:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants