Reorganize SoftDevices for NRF52 series #6826

marcuschangarm · 2018-05-06T04:18:28Z

Description

New directory structure:

TARGET_SOFTDEVICE_COMMON
TARGET_SOFTDEVICE_S112
TARGET_SOFTDEVICE_S132_FULL (MBR + SoftDevice, default)
TARGET_SOFTDEVICE_S132_OTA (SoftDevice only, for firmware updates)
TARGET_SOFTDEVICE_S132_MBR (MBR only, for bootloader builds)
TARGET_SOFTDEVICE_S140_FULL (MBR + SoftDevice, default)
TARGET_SOFTDEVICE_S140_OTA (SoftDevice only, for firmware updates)
TARGET_SOFTDEVICE_S140_MBR (MBR only, for bootloader builds)
TARGET_SOFTDEVICE_NONE

The X_OTA and X_MBR binaries are obtained from the original x_FULL SoftDevice
by splitting it in an MBR part and a SoftDevice part. The MBR is needed for
the bootloader and the SoftDevice for firmware updates.

Build application without SoftDevice:

  "target_overrides": {
      "*": {
          "target.extra_labels_remove": ["SOFTDEVICE_COMMON", "SOFTDEVICE_X_FULL"],
          "target.extra_labels_add": ["SOFTDEVICE_NONE"]
      }
  }

Build application for firmware update using SoftDevice X:

  "target_overrides": {
      "*": {
          "target.extra_labels_remove": ["SOFTDEVICE_X_FULL"],
          "target.extra_labels_add": ["SOFTDEVICE_X_OTA"]
      }
  }

Build bootloader without SoftDevice X:

  "target_overrides": {
      "*": {
          "target.extra_labels_remove": ["SOFTDEVICE_X_FULL"],
          "target.extra_labels_add": ["SOFTDEVICE_X_MBR"]
      }
  }

Pull request type

[ ] Fix
[x] Refactor
[ ] New target
[ ] Feature
[x] Breaking change

0xc0170 · 2018-05-07T09:08:32Z

@marcuschangarm How this breaks the current apps? Can it be made backward compatible ?

marcuschangarm · 2018-05-07T18:07:37Z

Its not more breaking than the 5.9 stuff we've been doing! 😄
Just wanted to make sure it got tagged correctly.

cmonr · 2018-05-07T23:27:56Z

There sure are a bunch of new hex files and bootloaders. Would it be possible to comment in the commit message as to how they were generated?

cmonr · 2018-05-07T23:30:42Z

Build application without SoftDevice:

Shouldn't this be the default action for Nordic devices instead of needing to explicity add it to target_overrides?

marcuschangarm · 2018-05-08T17:18:05Z

Added:

The x_OTA and x_MBR binaries are obtained from the original x_FULL SoftDevice
by splitting it in an MBR part and a SoftDevice part. The MBR is needed for
the bootloader and the SoftDevice for firmware updates.

marcuschangarm · 2018-05-08T17:19:27Z

Build application without SoftDevice:

Shouldn't this be the default action for Nordic devices instead of needing to explicity add it to target_overrides?

That would be a deviation from what we have done since the first NRF51.

cmonr · 2018-05-08T18:12:43Z

/morph build

mbed-ci · 2018-05-08T18:18:10Z

Build : FAILURE

Build number : 1950
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6826/

cmonr · 2018-05-08T18:34:40Z

/morph build

mbed-ci · 2018-05-08T18:40:25Z

Build : FAILURE

Build number : 1951
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6826/

studavekar · 2018-05-08T20:18:35Z

/morph build

mbed-ci · 2018-05-08T20:52:30Z

Build : FAILURE

Build number : 1953
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6826/

cmonr · 2018-05-08T22:00:36Z

Looks like something different went wrong with the CI.

marcuschangarm · 2018-05-09T18:24:06Z

/morph build

mbed-ci · 2018-05-09T19:11:26Z

Build : FAILURE

Build number : 1967
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6826/

marcuschangarm · 2018-05-10T21:16:38Z

/morph build

mbed-ci · 2018-05-10T21:50:25Z

Build : SUCCESS

Build number : 1973
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6826/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-10T23:08:39Z

Test : FAILURE

Build number : 1784
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6826/1784

marcuschangarm · 2018-05-10T23:28:08Z

/morph test

mbed-ci · 2018-05-11T00:02:35Z

Exporter Build : FAILURE

Build number : 1624
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6826/

mbed-ci · 2018-05-11T00:42:25Z

Test : SUCCESS

Build number : 1785
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6826/1785

marcuschangarm · 2018-05-11T21:43:05Z

/morph build

mbed-ci · 2018-05-14T10:22:28Z

Exporter Build : FAILURE

Build number : 1644
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6826/

0xc0170 · 2018-05-14T10:34:45Z

The failure for export is the same one as previous one. We have seen it on master, was fixed a week ago. Can you test locally on your branch, or shall it be rebased (however CI merges this with the destination branch) so should not be there at all.

@theotherjimmy @studavekar Please look at this

studavekar · 2018-05-14T16:03:05Z

The failure for export is the same one as previous one. We have seen it on master, was fixed a week ago. Can you test locally on your branch, or shall it be rebased (however CI merges this with the destination branch) so should not be there at all.

@theotherjimmy @studavekar Please look at this

The fix #6713 for error startup_nrf52832.S: error: A3907U: Via file '.\build\startup_nrf52832._ia' command too long for buffer.

looks like still the commandline is too long to handle.

marcuschangarm · 2018-05-14T16:15:22Z

I'm undoing the nested folder structure and keeping the directories flat. The PR will be about adding the MBR and OTA binaries.

marcuschangarm · 2018-05-14T16:16:19Z

@donatieng

any chance you could add a README explaining how you split up the MBR/Softdevice?

Sure, I literally just copy pasted it in an intel hex editor.

marcuschangarm · 2018-05-14T16:23:06Z

@0xc0170

Note, with all these updates, we need to make sure the release notes contain sufficient details for these changes (how nrf52 update from the current minor release to the one that this is in - as there are quite changes and won't be that trivial, will it?).

I can collect a list with changes. The major changes have been to things that didn't work correctly to begin or to people that for some reason have linked directly to files in the SDK.

marcuschangarm · 2018-05-16T05:41:34Z

/morph build

mbed-ci · 2018-05-16T06:12:18Z

Build : SUCCESS

Build number : 2032
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6826/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-16T07:56:00Z

Test : FAILURE

Build number : 1838
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6826/1838

mbed-ci · 2018-05-16T11:33:29Z

Exporter Build : FAILURE

Build number : 1681
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6826/

marcuschangarm · 2018-05-16T18:00:37Z

/morph test
/morph export-build

marcuschangarm · 2018-05-16T19:38:41Z

/morph test

mbed-ci · 2018-05-16T19:49:36Z

Exporter Build : SUCCESS

Build number : 1686
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6826/

marcuschangarm · 2018-05-17T00:42:28Z

/morph test

mbed-ci · 2018-05-17T06:52:44Z

Test : SUCCESS

Build number : 1852
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6826/1852

New directory structure: * TARGET_SOFTDEVICE_COMMON * TARGET_SOFTDEVICE_S112 * TARGET_SOFTDEVICE_S132_FULL (MBR + SoftDevice, default) * TARGET_SOFTDEVICE_S132_OTA (SoftDevice only, for firmware updates) * TARGET_SOFTDEVICE_S132_MBR (MBR only, for bootloader builds) * TARGET_SOFTDEVICE_S140_FULL (MBR + SoftDevice, default) * TARGET_SOFTDEVICE_S140_OTA (SoftDevice only, for firmware updates) * TARGET_SOFTDEVICE_S140_MBR (MBR only, for bootloader builds) * TARGET_SOFTDEVICE_NONE The X_OTA and X_MBR binaries are obtained from the original x_FULL SoftDevice by splitting it in an MBR part and a SoftDevice part. The MBR is needed for the bootloader and the SoftDevice for firmware updates. Build application without SoftDevice: "target_overrides": { "*": { "target.extra_labels_remove": ["SOFTDEVICE_COMMON", "SOFTDEVICE_X_FULL"], "target.extra_labels_add": ["SOFTDEVICE_NONE"] } } Build application for firmware update using SoftDevice X: "target_overrides": { "*": { "target.extra_labels_remove": ["SOFTDEVICE_X_FULL"], "target.extra_labels_add": ["SOFTDEVICE_X_OTA"] } } Build bootloader without SoftDevice X: "target_overrides": { "*": { "target.extra_labels_remove": ["SOFTDEVICE_COMMON", "SOFTDEVICE_X_FULL"], "target.extra_labels_add": ["SOFTDEVICE_X_MBR"] } }

marcuschangarm · 2018-05-17T16:21:12Z

/morph build

mbed-ci · 2018-05-17T18:13:31Z

Build : SUCCESS

Build number : 2058
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6826/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

cmonr · 2018-05-18T02:50:18Z

/morph test
/morph export-build

mbed-ci · 2018-05-18T04:27:04Z

Exporter Build : SUCCESS

Build number : 1700
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6826/

mbed-ci · 2018-05-18T05:33:06Z

Test : SUCCESS

Build number : 1868
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6826/1868

0xc0170 added the needs: review label May 7, 2018

0xc0170 requested a review from donatieng May 7, 2018 09:02

cmonr added the release-version: 5.9.0-rc1 label May 7, 2018

cmonr added needs: work needs: review and removed needs: review needs: work labels May 8, 2018

marcuschangarm mentioned this pull request May 9, 2018

[NRF52] rng does not build for non softdevice target #6802

Closed

drahnr mentioned this pull request May 15, 2018

NRF52: compiling master without SoftDevice #6916

Closed

marcuschangarm dismissed stale reviews from 0xc0170 and cmonr via 388cd53 May 16, 2018 05:38

0xc0170 approved these changes May 18, 2018

View reviewed changes

0xc0170 added ready for merge and removed needs: review labels May 18, 2018

cmonr removed the ready for merge label May 21, 2018

cmonr merged commit 2fa6cb5 into ARMmbed:master May 21, 2018

marcuschangarm deleted the feature-ota branch May 25, 2018 17:59

Reorganize SoftDevices for NRF52 series #6826

Reorganize SoftDevices for NRF52 series #6826

Uh oh!

Conversation

marcuschangarm commented May 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

0xc0170 commented May 7, 2018

Uh oh!

marcuschangarm commented May 7, 2018

Uh oh!

cmonr commented May 7, 2018

Uh oh!

cmonr commented May 7, 2018

Uh oh!

marcuschangarm commented May 8, 2018

Uh oh!

marcuschangarm commented May 8, 2018

Uh oh!

cmonr commented May 8, 2018

Uh oh!

mbed-ci commented May 8, 2018

Uh oh!

cmonr commented May 8, 2018

Uh oh!

mbed-ci commented May 8, 2018

Uh oh!

studavekar commented May 8, 2018

Uh oh!

mbed-ci commented May 8, 2018

Uh oh!

cmonr commented May 8, 2018

Uh oh!

marcuschangarm commented May 9, 2018

Uh oh!

mbed-ci commented May 9, 2018

Uh oh!

marcuschangarm commented May 10, 2018

Uh oh!

mbed-ci commented May 10, 2018

Triggering tests

Uh oh!

mbed-ci commented May 10, 2018

Uh oh!

marcuschangarm commented May 10, 2018

Uh oh!

mbed-ci commented May 11, 2018

Uh oh!

mbed-ci commented May 11, 2018

Uh oh!

marcuschangarm commented May 11, 2018

Uh oh!

mbed-ci commented May 14, 2018

Uh oh!

0xc0170 commented May 14, 2018

Uh oh!

studavekar commented May 14, 2018

Uh oh!

marcuschangarm commented May 14, 2018

Uh oh!

marcuschangarm commented May 14, 2018

Uh oh!

marcuschangarm commented May 14, 2018

Uh oh!

marcuschangarm commented May 16, 2018

Uh oh!

mbed-ci commented May 16, 2018

Triggering tests

Uh oh!

mbed-ci commented May 16, 2018

Uh oh!

mbed-ci commented May 16, 2018

Uh oh!

marcuschangarm commented May 16, 2018

Uh oh!

marcuschangarm commented May 16, 2018

Uh oh!

mbed-ci commented May 16, 2018

marcuschangarm commented May 6, 2018 •

edited

Loading