Skip to content

Drop include paths for ARM assembler #6713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

The arm assembler would include many, many include paths on the command
line corresponding to anywhere it's possible to locate a header file.
This caused the following problem in uvision:

assembling startup_nrf52832.S...
startup_nrf52832.S: error: A3907U: Via file
'.\build\startup_nrf52832._ia' command too long for buffer.

We work around this issue by dropping the include paths from the
assembler in both mbed compile and mbed export. This has the
advantage that it's consistent with IAR.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

cmonr
cmonr previously approved these changes Apr 23, 2018
@cmonr
Copy link
Contributor

cmonr commented Apr 23, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 23, 2018

Build : FAILURE

Build number : 1828
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6713/

@@ -394,7 +394,7 @@
<MiscControls>{{asm_flags}}</MiscControls>
<Define></Define>
<Undefine></Undefine>
<IncludePath>{{include_paths}}</IncludePath>
<IncludePath></IncludePath>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually reverts ebc9289 and solves the problem @hug-dev was having by updating the path in targets/TARGET_ARM_SSG/TARGET_CM3DS_MPS2/device/TOOLCHAIN_ARM_STD/startup_MPS2.S ? The include is still there, where does assembler finds it? - not clear to me.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 24, 2018

@hug-dev Please review

@hug-dev
Copy link
Contributor

hug-dev commented Apr 24, 2018

This is fine for me, as long as the preprocessor is called on the assembly file. I don't see the structure of files changing anytime soon so this is fine using relative path.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 26, 2018

Please review the build failures (similar are in jenkins CI)

 I was extending an object-local one instead of a call-local one
@theotherjimmy
Copy link
Contributor Author

That should fix it.

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2018

Build : SUCCESS

Build number : 1881
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6713/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants