-
Notifications
You must be signed in to change notification settings - Fork 3k
Drop include paths for ARM assembler #6713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph build |
Build : FAILUREBuild number : 1828 |
@@ -394,7 +394,7 @@ | |||
<MiscControls>{{asm_flags}}</MiscControls> | |||
<Define></Define> | |||
<Undefine></Undefine> | |||
<IncludePath>{{include_paths}}</IncludePath> | |||
<IncludePath></IncludePath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hug-dev Please review |
This is fine for me, as long as the preprocessor is called on the assembly file. I don't see the structure of files changing anytime soon so this is fine using relative path. |
Please review the build failures (similar are in jenkins CI) |
I was extending an object-local one instead of a call-local one
That should fix it. /morph build |
Build : SUCCESSBuild number : 1881 Triggering tests/morph test |
Test : SUCCESSBuild number : 1695 |
Exporter Build : SUCCESSBuild number : 1530 |
Description
The arm assembler would include many, many include paths on the command
line corresponding to anywhere it's possible to locate a header file.
This caused the following problem in uvision:
We work around this issue by dropping the include paths from the
assembler in both
mbed compile
andmbed export
. This has theadvantage that it's consistent with IAR.
Pull request type