Skip to content

Implementation of unified EMAC driver for Renesas mbed boards #6834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2018
Merged

Implementation of unified EMAC driver for Renesas mbed boards #6834

merged 1 commit into from
May 17, 2018

Conversation

TomoYamanaka
Copy link
Contributor

@TomoYamanaka TomoYamanaka commented May 8, 2018 •
edited
Loading

Description

Based on the driver so far, Renesas implemented the emac driver for GR-PEACH and VK-RZ/A1H.

The Greentea test netsocket and emac test passed. Test results are here.

test_all_GCC_GR-PEACH.txt
test_emac_GCC_GR-PEACH.txt

Pull request type

[ ] Fix
[x] Refactor
[ ] New target
[] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested review from kjbracey and mikaleppanen May 8, 2018 09:16
kjbracey
kjbracey reviewed May 8, 2018
View reviewed changes
Copy link
Contributor

@kjbracey kjbracey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, just a little multicast tweak.

targets/TARGET_RENESAS/TARGET_RZ_A1XX/ethernet_api.c Outdated
tsu_ten_tmp |= (1 << cnt);
break;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlikely to happen, but if you run out of room in the 32-entry table, you should do "set all multicast". You can't leave the caller unable to receive the group they asked for.

@kjbracey
Copy link
Contributor

kjbracey commented May 9, 2018

feature-emac has just been rebased - can you rebase this please?

@TomoYamanaka
Copy link
Contributor Author

Ok. I will update my code in based on your above comment and rebase my commit after that.

@TomoYamanaka
Copy link
Contributor Author

TomoYamanaka commented May 11, 2018 •
edited
Loading

@kjbracey-arm

Although I rebased my commit to 942209e, I faced the compile error only IAR.

@TomoYamanaka
Copy link
Contributor Author

TomoYamanaka commented May 11, 2018 •
edited
Loading

@kjbracey-arm

Sorry, I have sent you an unfinished message.

Although I rebased my commit to 942209e, I faced the compile error only at IAR.
It seem that ARMCC and GCC is no problem.
The error message is here:

Compiling was successful if it was the environment I sended PR (before rebase).
Could you check the problem ?

The command that I run is here:
mbed test --compile --run -m <target> -t IAR -v -n tests-network-emac --app-config TESTS/network/emac/template_mbed_app.txt

@TomoYamanaka
Copy link
Contributor Author

@kjbracey-arm

Sorry to bother you again.

It is seems that the above phenomenon occured by a mistake of my environment and test order.
I will withdraw the my 2 comments.

@TomoYamanaka
Implementation of unified EMAC driver for Renesas mbed boards
3a2a0c9 
Implementation of unified EMAC driver for Renesas mbed boards

Based on the driver so far, Renesas implemented the emac driver for GR-PEACH and VK-RZ/A1H.
The mainly changes is below.
- Add the connection part with LWIP according to the unified emac specification.
- Add three new multicast functions(add, remove, set_all).

The Greentea test netsocket and emac test passed.
@TomoYamanaka
Copy link
Contributor Author

TomoYamanaka commented May 11, 2018 •
edited
Loading

I rebased my commit with reflected the above comment regarding multicast.

@kjbracey kjbracey mentioned this pull request May 15, 2018
Merged
@kjbracey kjbracey merged commit 3a2a0c9 into ARMmbed:feature-emac May 17, 2018
@TomoYamanaka TomoYamanaka deleted the feature-emac_pre branch July 12, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjbracey kjbracey kjbracey approved these changes

@mikaleppanen mikaleppanen mikaleppanen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomoYamanaka @kjbracey @mikaleppanen @0xc0170