Skip to content

Feature-emac combined merge #6903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 17, 2018
Merged

Feature-emac combined merge #6903

merged 9 commits into from
May 17, 2018

Conversation

kjbracey
Copy link
Contributor

@kjbracey kjbracey commented May 15, 2018

Description

Pull in 2 EMAC drivers and DNS changes into feature-emac

Combines 3 approved PRs:

Combined to accelerate CI testing.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

cyliangtw and others added 9 commits May 10, 2018 11:52
Implementation of unified EMAC driver for Renesas mbed boards

Based on the driver so far, Renesas implemented the emac driver for GR-PEACH and VK-RZ/A1H.
The mainly changes is below.
- Add the connection part with LWIP according to the unified emac specification.
- Add three new multicast functions(add, remove, set_all).

The Greentea test netsocket and emac test passed.
- Added non-blocking DNS interface to network interface and
  network stack.
- Added caching of DNS replies.
- Added a network stack function to get DNS addresses from stack.
- Added call and call_in hooks to onboard network stack to
  allow calling functions from onboard stack context.
- Added support to call and call_in functions to LWIP and
  Nanostack.
- Disabled LWIP DNS translator with the exception of DNS
  address storage used in DNS address get.
- Changed call_in/call methods of the stack to callback provided by the stack
- Specified what are limitations for operations that are made in callback
- Added pure virtual class DNS that defines DNS operations
- Added cancel operation and unique ID to DNS request used in cancel
- Added DNS configuration options to netsocket/mbed_lib.json for retries,
  response wait time and cache size
- Changed host name to use dynamic memory in DNS query list and cache,
  set maximum length for the name to 255 bytes.
- Added mutex to asynchronous DNS
- Reworked retries: there is now total retry count and a server specific count
- Ignores invalid incoming UDP socket messages (DNS header is not valid), and retries DNS query
- Reworked DNS module asynchronous operation functions
- Corrected other review issues (nothrow new, missing free, missing mutex unlock etc.)
- Serialized the sending of multiple async DNS queries since limits on event
message box sizes
- Added timer function that supervises the total time used to make DNS query
and triggers socket timeouts
- Changed nsapi_error_t to new nsapi_value_or_error_t on interface headers
- Corrected wording of gethostbyname_async return values
- Clarified .json options
- Added a new data type for socket callback that can be used from interrupts
- Corrected variable limits to use INT32_MAX etc. defines
- Changed mallocs to new
- Optimized variable sizes on DNS_QUERY definition
- Changed mutexes to platform mutexes
- Removed not needed null check from delete
- Changed nsapi_dns_call_in_set() to use call_in_callback_cb_t and
added prototype to header
…y-merge

* pr6751:
  Changed mutexes, delete and DNS call in callback set
  Corrected more defects
  Corrected defects - Changed call_in/call methods of the stack to callback provided by the stack - Specified what are limitations for operations that are made in callback - Added pure virtual class DNS that defines DNS operations - Added cancel operation and unique ID to DNS request used in cancel - Added DNS configuration options to netsocket/mbed_lib.json for retries,   response wait time and cache size - Changed host name to use dynamic memory in DNS query list and cache,   set maximum length for the name to 255 bytes. - Added mutex to asynchronous DNS - Reworked retries: there is now total retry count and a server specific count - Ignores invalid incoming UDP socket messages (DNS header is not valid), and retries DNS query - Reworked DNS module asynchronous operation functions - Corrected other review issues (nothrow new, missing free, missing mutex unlock etc.)
  Added non-blocking DNS functionality to network interface

* pr6834:
  Implementation of unified EMAC driver for Renesas mbed boards

* pr6874:
  [M487/NUC472] Fix tx frame length and remove GPL license
  [M487/NUC472] Support DHCP & TCP sample, also remove legacy emac
  [M487/NUC472] Support new EMAC feature, built OK
@kjbracey
Copy link
Contributor Author

/morph build

@mbed-ci
Copy link

mbed-ci commented May 15, 2018

Build : SUCCESS

Build number : 2020
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6903/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 15, 2018

@mbed-ci
Copy link

mbed-ci commented May 16, 2018

@kjbracey
Copy link
Contributor Author

/morph test

@mbed-ci
Copy link

mbed-ci commented May 16, 2018

@studavekar
Copy link
Contributor

Test : FAILURE
Build number : 1843
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6903/1843

Have re-started the please ignore the above failure

@mbed-ci
Copy link

mbed-ci commented May 16, 2018

@kjbracey
Copy link
Contributor Author

/morph test

@mbed-ci
Copy link

mbed-ci commented May 17, 2018

@kjbracey kjbracey merged commit 38e28dc into feature-emac May 17, 2018
@kjbracey kjbracey deleted the feature-emac-15May-merge branch May 17, 2018 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants