Skip to content

Nuvoton: Feature emac on M487/NUC472 #6874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2018

Conversation

cyliangtw
Copy link
Contributor

@cyliangtw cyliangtw commented May 11, 2018

Description

Support feature emac on NUMAKER_PFM_M487/NUC472 boards.
It could pass both of network-eamc and netsocket tests in ARMCC, GCC & IAR after applied #6851
Please refer to the attached logs. Just show snippet of GCC log as below:

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
mbedgt: test suite report:
+--------------------------+------------------+------------------------------------+--------+--------------------+-------------+
| target                   | platform_name    | test suite                         | result | elapsed_time (sec) | copy_method |
+--------------------------+------------------+------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | tests-netsocket-connectivity       | OK     | 19.96              | default     |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | tests-netsocket-gethostbyname      | OK     | 18.38              | default     |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | tests-netsocket-ip_parsing         | OK     | 14.06              | default     |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | tests-netsocket-socket_sigio       | OK     | 23.16              | default     |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | tests-netsocket-tcp_echo           | OK     | 18.69              | default     |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | tests-netsocket-tcp_hello_world    | OK     | 16.95              | default     |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | tests-netsocket-udp_dtls_handshake | OK     | 16.81              | default     |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | tests-netsocket-udp_echo           | OK     | 26.02              | default     |
+--------------------------+------------------+------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 8 OK

+--------------------------+------------------+--------------------+---------------------------+--------+--------+--------+--------------------+
| target                   | platform_name    | test suite         | test case                 | passed | failed | result | elapsed_time (sec) |
+--------------------------+------------------+--------------------+---------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | tests-network-emac | EMAC broadcast            | 1      | 0      | OK     | 10.25              |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | tests-network-emac | EMAC initialize           | 1      | 0      | OK     | 1.84               |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | tests-network-emac | EMAC memory               | 1      | 0      | OK     | 206.16             |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | tests-network-emac | EMAC multicast filter     | 1      | 0      | OK     | 8.08               |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | tests-network-emac | EMAC unicast              | 1      | 0      | OK     | 4.26               |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | tests-network-emac | EMAC unicast burst        | 1      | 0      | OK     | 48.03              |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | tests-network-emac | EMAC unicast frame length | 1      | 0      | OK     | 5.36               |
+--------------------------+------------------+--------------------+---------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 7 OK
mbedgt: completed in 299.92 sec

@samchuarm

nuc472_netsocket_iar.txt
nuc472_network_emac_armcc.txt
nuc472_network_emac_gcc.txt
nuc472_network_emac_iar.txt
m487_netsocket_armcc.txt
m487_netsocket_gcc.txt
m487_netsocket_iar.txt
m487_network_emac_armcc.txt
m487_network_emac_gcc.txt
m487_network_emac_iar.txt
nuc472_netsocket_arm.txt
nuc472_netsocket_gcc.txt


bool NUMAKER_EMAC::get_hwaddr(uint8_t *addr) const
{
mbed_mac_address((char *)addr);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can implement "set_hwaddr", and don't have a firm idea of a specific address for this interface, the "get_hwaddr" function should return false to say "I don't have my own ID".

The stack is expected to come up with a MAC itself (probably by calling mbed_mac_address) if the interface has no ID chip of its own.

This will do for now though

@kjbracey
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented May 15, 2018

Build : SUCCESS

Build number : 2018
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6874/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@kjbracey kjbracey merged commit 2f190c8 into ARMmbed:feature-emac May 17, 2018
@cyliangtw cyliangtw deleted the feature-emac branch September 23, 2019 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants