Skip to content

Updated emac greentea tests #6851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2018
Merged

Updated emac greentea tests #6851

merged 2 commits into from
May 14, 2018

Conversation

mikaleppanen
Copy link

Description

  • Improved markdown
  • Set tests to fail if CTP echo server is not present

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Updated emac greentea tests
6e7cac9 
- Improved markdown
- Set tests to fail if CTP echo server is not present
@mikaleppanen
Copy link
Author

Disabled also "printf("cable connected\r\n\r\n");" traces could result problems with greentea tracing/test case execution.

@0xc0170 0xc0170 requested review from kjbracey and AnotherButler May 9, 2018 13:44
@maclobdell
Copy link
Contributor

maclobdell commented May 9, 2018 •
edited
Loading

I just tested this on two K64F. Everything passing now.

+--------------+---------------+--------------------+---------------------------+--------+--------+--------+--------------------+
| target       | platform_name | test suite         | test case                 | passed | failed | result | elapsed_time (sec) |
+--------------+---------------+--------------------+---------------------------+--------+--------+--------+--------------------+
| K64F-GCC_ARM | K64F          | tests-network-emac | EMAC broadcast            | 1      | 0      | OK     | 10.29              |
| K64F-GCC_ARM | K64F          | tests-network-emac | EMAC initialize           | 1      | 0      | OK     | 1.89               |
| K64F-GCC_ARM | K64F          | tests-network-emac | EMAC memory               | 1      | 0      | OK     | 293.97             |
| K64F-GCC_ARM | K64F          | tests-network-emac | EMAC multicast filter     | 1      | 0      | OK     | 62.1               |
| K64F-GCC_ARM | K64F          | tests-network-emac | EMAC unicast              | 1      | 0      | OK     | 4.28               |
| K64F-GCC_ARM | K64F          | tests-network-emac | EMAC unicast burst        | 1      | 0      | OK     | 53.9               |
| K64F-GCC_ARM | K64F          | tests-network-emac | EMAC unicast frame length | 1      | 0      | OK     | 5.9                |
+--------------+---------------+--------------------+---------------------------+--------+--------+--------+--------------------+

@maclobdell maclobdell mentioned this pull request May 9, 2018
Closed
Copy edit README.md
22e4c34 
Copy edit changes to README.md, mostly for active voice, consistent tense across docs and style.
@cyliangtw cyliangtw mentioned this pull request May 11, 2018
Merged
M-ichae-l added a commit to M-ichae-l/mbed-os that referenced this pull request May 14, 2018
@M-ichae-l
add-rtl8195am-feature-emac
1eaac1a 
rtl8195am feature emac implementation.
coding style fix.
Updated emac greentea tests ARMmbed#6851.
@0xc0170
Copy link
Contributor

0xc0170 commented May 14, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 14, 2018

Build : SUCCESS

Build number : 1996
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6851/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 14, 2018

Test : SUCCESS

Build number : 1807
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6851/1807

@mbed-ci
Copy link

mbed-ci commented May 14, 2018

Exporter Build : SUCCESS

Build number : 1649
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6851/

@cmonr cmonr removed the needs: CI label May 14, 2018
@cmonr cmonr merged commit d95acbc into ARMmbed:feature-emac May 14, 2018
@M-ichae-l M-ichae-l mentioned this pull request May 15, 2018
Merged
M-ichae-l added a commit to M-ichae-l/mbed-os that referenced this pull request May 16, 2018
@M-ichae-l
rebase for feacture_emac
4f529ad 
fix the conflicts with ARMmbed#6851.
kjbracey added a commit that referenced this pull request May 18, 2018
@kjbracey
LPC546XX: Correct Ethernet MAC address write
ba31be0 
Patch to LPC546XX SDK code - write the low Ethernet MAC address
register last, as that synchronises the update.

Without this change, the ENET_SetMacAddr call only seems to work prior
to MAC initialisation, causing problems for the new mbed OS EMAC system,
which expects it to be changable later.

Updated emac greentea tests #6851.
0xc0170 pushed a commit that referenced this pull request May 20, 2018
@kjbracey @0xc0170
LPC546XX: Correct Ethernet MAC address write
205948c 
Patch to LPC546XX SDK code - write the low Ethernet MAC address
register last, as that synchronises the update.

Without this change, the ENET_SetMacAddr call only seems to work prior
to MAC initialisation, causing problems for the new mbed OS EMAC system,
which expects it to be changable later.

Updated emac greentea tests #6851.
kjbracey added a commit that referenced this pull request May 22, 2018
@kjbracey
LPC546XX: Correct Ethernet MAC address write
34ff2d9 
Patch to LPC546XX SDK code - write the low Ethernet MAC address
register last, as that synchronises the update.

Without this change, the ENET_SetMacAddr call only seems to work prior
to MAC initialisation, causing problems for the new mbed OS EMAC system,
which expects it to be changable later.

Updated emac greentea tests #6851.
kjbracey added a commit that referenced this pull request May 23, 2018
@kjbracey
LPC546XX: Correct Ethernet MAC address write
97b9980 
Patch to LPC546XX SDK code - write the low Ethernet MAC address
register last, as that synchronises the update.

Without this change, the ENET_SetMacAddr call only seems to work prior
to MAC initialisation, causing problems for the new mbed OS EMAC system,
which expects it to be changable later.

Updated emac greentea tests #6851.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjbracey kjbracey kjbracey approved these changes

@AnotherButler AnotherButler AnotherButler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mikaleppanen @maclobdell @0xc0170 @mbed-ci @kjbracey @AnotherButler @cmonr