Skip to content

tools: Add explicit target for NVStore example #6919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2018

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented May 15, 2018

Description

Realized with this PR (#6879) that nvstore was being compiled and tested against all targets. Limited example building for K64F, since example only calls out K64F.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr cmonr requested review from geky and davidsaada May 15, 2018 17:51
@cmonr cmonr changed the title Added explicit target for NVStore Added explicit target for NVStore example May 15, 2018
@cmonr
Copy link
Contributor Author

cmonr commented May 15, 2018

@davidsaada If there are other targets that are explicitly supported, please let us know (similar to this: b61912c).

@ARMmbed/mbed-os-maintainers This could also be why export tests have taken a bit longer, since this example is currently being built against all exported targets instead of a subset.

Copy link
Contributor

@davidsaada davidsaada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@geky geky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if David's happy

@0xc0170 0xc0170 changed the title Added explicit target for NVStore example tools: Add explicit target for NVStore example May 16, 2018
@cmonr
Copy link
Contributor Author

cmonr commented May 16, 2018

/morph build

@cmonr
Copy link
Contributor Author

cmonr commented May 17, 2018

Build was stuck trying to start on a node that was never brought online...

@cmonr
Copy link
Contributor Author

cmonr commented May 17, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 17, 2018

Build : SUCCESS

Build number : 2041
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6919/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 17, 2018

@mbed-ci
Copy link

mbed-ci commented May 17, 2018

@cmonr
Copy link
Contributor Author

cmonr commented May 17, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 17, 2018

@cmonr cmonr merged commit 73eebae into ARMmbed:master May 18, 2018
@cmonr cmonr removed the needs: CI label May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants