Add devicekey example to examples list

[adbridge]

Description

This PR adds the mbed-os-example-devicekey to the list of examples.
This can only go in after the device key feature has been merged.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

[0xc0170]

Looks fine to me. I requested @yossi2le to confirm this is valid (please review features/targets) for this example

[yossi2le]

Looks fine to me also. DeviceKey should support all targets and has no dependencies in spacial features.

[davidsaada]

Looks good to me.

[cmonr]

/morph build

[mbed-ci]

Build : FAILURE

Build number : 2139
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7003/

[cmonr]

@adbridge @davidsaada @yossi2le Please take a look at the failures.

Judging by the patterns and taking a quick look, it looks like there might be a minimum size requirement of some sort.

[cmonr]

The quickest way to resolve this would probably be to explicitly list the devices that this example supports by adding them into the '"targets" : []` array.

[cmonr]

@dannybenor

[adbridge]

If one of you devicekey experts can list the supported targets I can add them to the target list.

[geky]

At minimum I believe this can include K64F:
#6919

[cmonr]

@yossi2le Is Flash iAP a requirement for this example to work?

If so, I know of at least two devices that will not work with this example: #6925

[geky]

@cmonr yes:

• https://github.com/ARMmbed/mbed-os/blob/master/features/device_key/source/DeviceKey.h#L23 - Depends on NVSTORE_ENABLED
• https://github.com/ARMmbed/mbed-os/blob/master/features/nvstore/source/nvstore.h#L21 - Depends on DEVICE_FLASH

[yossi2le]

@cmonr @adbridge @geky
Sorry for that. I thought the nvstore dependencies will be taken care of.
The target list should be the same as in nvstore example. checking it shows that the nvstore example target is only K64F :(.

[yossi2le]

@geky, @cmonr , @adbridge
Reflecting on it again I need your opinion. The nvstore is depends on DEVICE_FLASH and where we have nvstore we can have device key. While device key example is binded to nvstore it actually may run on more platforms. Looking on the build which fails we also have lots of devices that pass and device key will work on those. What do you think?

This is the list of device that passed the build.

ARCH_PRO, B96B_F446VE, DELTA_DFBM_NQ620, DISCO_F413ZH, DISCO_F429ZI, DISCO_F469NI, DISCO_F746NG, DISCO_F769NI, DISCO_L072CZ_LRWAN1, DISCO_L475VG_IOT01A, DISCO_L476VG, DISCO_L496AG, EFM32GG_STK3700, EFM32LG_STK3600, EFM32PG12_STK3402, EFM32PG_STK3401, EFM32WG_STK3800, EV_COG_AD3029LZ, EV_COG_AD4050LZ, FF1705_L151CC, FF_LPC546XX, HEXIWEAR, K64F, K66F, K82F, KL46Z, KW24D, LPC1768, LPC1769, LPC54114, LPC546XX, MBED_CONNECT_ODIN, MTB_ADV_WISE_1510, MTB_ADV_WISE_1530, MTB_ADV_WISE_1570, MTB_LAIRD_BL652, MTB_MTS_XDOT, MTB_MURATA_ABZ, MTB_MXCHIP_EMW3166, MTB_UBLOX_NINA_B1, MTB_UBLOX_ODIN_W2, MTB_USI_WM_BN_BM_22, NRF52840_DK, NRF52_DK, NUCLEO_F070RB, NUCLEO_F072RB, NUCLEO_F091RC, NUCLEO_F103RB, NUCLEO_F207ZG, NUCLEO_F303RE, NUCLEO_F303ZE, NUCLEO_F401RE, NUCLEO_F410RB, NUCLEO_F411RE, NUCLEO_F412ZG, NUCLEO_F413ZH, NUCLEO_F429ZI, NUCLEO_F439ZI, NUCLEO_F446RE, NUCLEO_F446ZE, NUCLEO_F746ZG, NUCLEO_F756ZG, NUCLEO_F767ZI, NUCLEO_L073RZ, NUCLEO_L152RE, NUCLEO_L432KC, NUCLEO_L433RC_P, NUCLEO_L476RG, NUCLEO_L486RG, NUCLEO_L496ZG, NUCLEO_L496ZG_P, NUMAKER_PFM_M453, NUMAKER_PFM_M487, NUMAKER_PFM_NUC472, RBLAB_BLENANO2, REALTEK_RTL8195AM, RO359B, SILICA_SENSOR_NODE, STEVAL_3DP001V1, TB_SENSE_1, TB_SENSE_12, TMPM46B, UBLOX_C027, UBLOX_C030_N211, UBLOX_C030_R410M, UBLOX_C030_U201, UBLOX_EVA_NINA, UBLOX_EVK_NINA_B1, UBLOX_EVK_ODIN_W2, UBRIDGE, USI_WM_BN_BM_22, VBLUNO52, XDOT_L151CC,

[geky]

Sounds like we should add those devices as targets for NVStore and DeviceKey? @adbridge, @cmonr, thoughts?

[cmonr]

It's fine by me if all of those are listed as example targets for both examples.

[yossi2le]

Nvstore is actually suppose to work on all platforms which has DEVICE_FLASH and where there is nvstore there is also device key. With that said @davidsaada is the nvstore example owner so I can't speak on is behalf

[cmonr]

Let's do this. In order to get this in for 5.9, and keep it in line with what exists right now, we'll just add the K64F as a target.

I have a feeling that the features: [] array is suppose to contain DEVICE_FLASH, but with less than a day before code freeze, I'd much prefer to go the route of getting this in in a known way, and having a 'fix' PR come in later.

Since @adbridge is afk, I'll resubmit this PR, only adding the K64F as a target.

[cmonr]

Made the change without a new PR :D

@geky @0xc0170 @adbridge @yossi2le @davidsaada All good?

[cmonr]

Going to restart CI.

/morph build

[yossi2le]

I absolutely agree. @cmonr thx.

[mbed-ci]

Build : SUCCESS

Build number : 2143
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7003/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Test : SUCCESS

Build number : 1937
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7003/1937

[mbed-ci]

Exporter Build : SUCCESS

Build number : 1771
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7003/

[0xc0170]

@yossi2le Need an action to review features/targets for this one.

[yossi2le]

I don't know why but I don't have permission to do so. The approve dialog is missing. I will ask @davidsaada to do so.

[adbridge]

@yossi2le @cmonr Thanks for that list. The targets list in the example file wasn't generally designed to have that many targets in it (though it still should work). I agree with @cmonr that just adding K64F for now is the right way forward and then we need to look at this more carefully for 5.9.1.