Skip to content

fix realtek_rtl8195am IPv6 build fails update #7055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

M-ichae-l
Copy link
Contributor

@M-ichae-l M-ichae-l commented May 30, 2018

Description

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

remove the "dhcps.h" and "dhcps.c" files
edit "wifi_conf.c" "wifi_conf.h" and "rtw_emac.cpp" to fix compile error
coding style fix
rebase from master branch
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From our workflow Handbook: "In particular, separate code formatting and style changes from functional changes. "

Can you separate these 2 ?

@M-ichae-l
Copy link
Contributor Author

@0xc0170
OK, Lets close this PR. I have created a new PR with only functional changes.
Please refer to #7056.

@0xc0170
Copy link
Contributor

0xc0170 commented May 30, 2018

@M-ichae-l Thanks, will review. It was enough to split the commit (style changes separate commit).

@0xc0170 0xc0170 closed this May 30, 2018
@M-ichae-l M-ichae-l deleted the fix-realtek_rtl8195am-IPv6-build-fails-update branch June 25, 2018 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants