Skip to content

fix realtek_rtl8195am IPv6 build fails #6974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

M-ichae-l
Copy link
Contributor

Description

  • remove the "dhcps.h" and "dhcps.c" files
  • edit "wifi_conf.c" and "rtw_emac.cpp" to fix compile error
  • coding style fix

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

SeppoTakalo
SeppoTakalo previously approved these changes May 22, 2018
Copy link
Contributor

@kjbracey kjbracey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can take any ethernet-related changes into master at the moment while feature-emac is pending.

@M-ichae-l
Copy link
Contributor Author

@kjbracey-arm
OK. We will check again after the feature-emac merged with master. Thank you.

Hasnain Virk and others added 21 commits May 24, 2018 15:54
Metadata APIs should return an error if the stack is not initialized yet.
General stability improvements are performed.
A flag is added if a Class C RX2 window is open.
We shouldn't open it again if its already opened.

TX_CRYPTO_ERROR is renamed to CRYPTO_ERROR.
Keeping TX_CRYPTO_ERROR for backwards compatibility.
Merge feature-emac branch into master
…ager-dev

BLE privacy, signing, persistent security database
Standardized Error Handling and Error Codes
Define the HAL API header for the Hardware CRC module. This set of functions
allows hardware acceleration of a subset of CRC algorithms for supported
platforms by providing access to the hardware CRC module of certain platforms.

The API is defined as four separate functions:

  - hal_crc_is_supported(polynomial)

    Indicates to the caller if the specific CRC polynomial is supported.

  - hal_crc_compute_partial_start(const uint32_t polynomial)

    Initializes the hardware CRC module with the given polynomial.

  - hal_crc_compute_partial(*data, size)

    Writes an array of bytes to the CRC module to be appended to the calculation

  - hal_crc_get_result()

    Applies the final transformations to the data and returns the result to the
    caller.
- Move CRC polynomial enum into HAL layer, so it's accessible from platform
  implementations

- Add enum to CRC class to indicate which mode the CRC class should use:
  HARDWARE, TABLE, or BITWISE

- Add calls to HAL Hardware CRC API to each of the compute functions when the
  class is in HARDWARE mode.

- Add missing constructor call to template constructor, and remove const from
  delegating constructor.
- Add support for all currently defined polynomials
- Add 'CRC' flag to targets.json for K64F profile
@SeppoTakalo
Copy link
Contributor

@M-ichae-l Any update on this? EMAC has now been merged in and IPv6 build is still broken.

Please rebase/update your changes on top of master.

Cruz Monrreal and others added 16 commits May 29, 2018 10:36
…onnect

Cellular: Fixed con-disc sequence can now be called multiple times.
…2_Expansion_Header

EFM32PG12_STK3402 - Correct wrong Expansion-Header pin namings
EFM32: make mbed_rtx.h depend of families instead of targets
…t-abi

Fixed float-abi linker option for CCES exporter.
Add STM32L433RC to IAR exporter definitions
Fix array overflow in gpio configuration code for NRF5x
Cellular: Fix AT URC handler not to dismiss incoming chars
Fix redeclaration of type name "bool_t" for Renesas
tests-mbed_hal-common_tickers: Fix increment test case implementation
Corrected asynchronous DNS functionality
remove the "dhcps.h" and "dhcps.c" files
edit "wifi_conf.c" and "rtw_emac.cpp" to fix compile error
coding style fix
rebase for master branch
coding style fix
@M-ichae-l
Copy link
Contributor Author

@SeppoTakalo
I have just rebased the branch and updated some files.

@M-ichae-l
Copy link
Contributor Author

M-ichae-l commented May 30, 2018

It is looks like that the rebase has made too much commits. So I have created a new PR for rebase and update. We can close this PR.
Please refer to #7056

@SeppoTakalo
Copy link
Contributor

@M-ichae-l Please close this PR as it is now replaced with #7055

@M-ichae-l M-ichae-l closed this May 30, 2018
@M-ichae-l M-ichae-l deleted the fix-realtek_rtl8195am-IPv6-build-fails branch May 30, 2018 10:49
M-ichae-l added a commit to M-ichae-l/mbed-os that referenced this pull request May 30, 2018
fix for ARMmbed#6909
    -remove the "dhcps.h" and "dhcps.c" files
    -edit "wifi_conf.c" "wifi_conf.h" and "rtw_emac.cpp" to fix compile error
rebase for ARMmbed#6974
adbridge pushed a commit that referenced this pull request Jun 4, 2018
fix for #6909
    -remove the "dhcps.h" and "dhcps.c" files
    -edit "wifi_conf.c" "wifi_conf.h" and "rtw_emac.cpp" to fix compile error
rebase for #6974
adbridge pushed a commit that referenced this pull request Jun 4, 2018
fix for #6909
    -remove the "dhcps.h" and "dhcps.c" files
    -edit "wifi_conf.c" "wifi_conf.h" and "rtw_emac.cpp" to fix compile error
rebase for #6974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.