Skip to content

Fix Greentea test failed with device_key and CRC #7066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix Greentea test failed with device_key and CRC #7066

wants to merge 2 commits into from

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented May 31, 2018

Description

This PR fixes Greentea test failed with device_key and CRC

  1. mbed-os-tests-mbed_drivers-crc
  2. mbed-os-features-device_key-tests-device_key-functionality

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

ccli8 added 2 commits May 31, 2018 14:33
@ccli8
Fix Greentea test code with device_key
965d3be 
Fix stack corrupted in mbed-os-features-device_key-tests-device_key-functionality/
Device Key - derived key wrong key type.
@ccli8
Fix mbed_crc_ctor is missing in some MbedCRC constructor
02c5d48 
This error leaves MbedCRC/_mode uninitialized and may cause mbed-os-tests-mbed_drivers-crc/
Test SD CRC polynomials failed.
@adbridge
Copy link
Contributor

@ccli8 These are tests for different functional areas, can you please split them into separate PRs. Thanks

@cmonr
Copy link
Contributor

cmonr commented May 31, 2018

@ccli8 This PR can be retooled as one of the two.

Thank you for splitting the commits though!

This was referenced Jun 1, 2018
Closed
Merged
@ccli8
Copy link
Contributor Author

ccli8 commented Jun 1, 2018

@adbridge As commented, I split this PR into two and will close this one.
#7080
#7081

@ccli8 ccli8 closed this Jun 1, 2018
@sg- sg- removed the needs: work label Jun 1, 2018
@ccli8 ccli8 deleted the nuvoton_fix_devicekey_crc branch June 1, 2018 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccli8 @adbridge @cmonr @sg-