Skip to content

Fix mbed_crc_ctor is missing in some MbedCRC constructor #7081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2018
Merged

Fix mbed_crc_ctor is missing in some MbedCRC constructor #7081

merged 1 commit into from
Jun 5, 2018

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Jun 1, 2018

Description

This fixes the error which leaves MbedCRC/_mode uninitialized and may cause mbed-os-tests-mbed_drivers-crc/Test SD CRC polynomials failed.

Related PR

#7066

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@ccli8
Fix mbed_crc_ctor is missing in some MbedCRC constructor
f51d036 
This error leaves MbedCRC/_mode uninitialized and may cause mbed-os-tests-mbed_drivers-crc/
Test SD CRC polynomials failed.
@ccli8 ccli8 mentioned this pull request Jun 1, 2018
Closed
@cmonr cmonr requested a review from deepikabhavnani June 1, 2018 02:17
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 4, 2018

Build : SUCCESS

Build number : 2230
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7081/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 4, 2018

Test : SUCCESS

Build number : 2022
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7081/2022

@mbed-ci
Copy link

mbed-ci commented Jun 4, 2018

Exporter Build : SUCCESS

Build number : 1858
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7081/

@0xc0170 0xc0170 merged commit 74aec93 into ARMmbed:master Jun 5, 2018
@ccli8 ccli8 deleted the nuvoton_fix_crc branch June 6, 2018 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@deepikabhavnani deepikabhavnani deepikabhavnani approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccli8 @0xc0170 @mbed-ci @deepikabhavnani @cmonr