Skip to content

Add support for EFM32GG11 #7079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2018
Merged

Conversation

stevew817
Copy link
Contributor

Description

Adding in support for EFM32GG11 - STK3701 (https://www.silabs.com/products/development-tools/mcu/32-bit/efm32-giant-gecko-gg11-starter-kit) as a target, now that the EMAC changes have made their way to master.

What's supported with this PR

  • Core mbed-os support (ADC/serial/SPI/I2C/tickless/PWM/GPIO/RTC/lowpower timer)
  • mbedTLS hardware acceleration support (AES-128/256, SHA-1/2, ECC secp192/224/256, TRNG)
  • Ethernet (EMAC driver)

Missing board features

  • SD slot is not supported, since it is hardwired to the chip's SDIO peripheral. mbed-os does not support SDIO AFAIK.
  • On-board SPI flash is hardwired to the chip's QSPI peripheral. This functionality needs the QSPI HAL in order to be ported. @0xc0170 do you have a timeline for that addition?

Test results

Test results

Pull request type

[ ] Fix
[ ] Refactor
[X] New target
[ ] Feature
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2018

Travis doxygen failure is related to the docs , please review.

@0xc0170 0xc0170 requested review from a team June 4, 2018 12:41
@stevew817 stevew817 force-pushed the feature/EFM32GG11-OS5.9 branch from 6908a18 to da991ad Compare June 4, 2018 15:22
@stevew817
Copy link
Contributor Author

@0xc0170 fixed :)

0xc0170
0xc0170 previously requested changes Jun 6, 2018
@@ -0,0 +1,25 @@
#ifndef SL_EMAC_CONFIG_H
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license missing here

@@ -0,0 +1,22 @@
#ifndef SL_ETH_HW_H
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing license here

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 13, 2018

On-board SPI flash is hardwired to the chip's QSPI peripheral. This functionality needs the QSPI HAL in order to be ported. @0xc0170 do you have a timeline for that addition?

cc @bulislaw

@bulislaw
Copy link
Member

bulislaw commented Jun 13, 2018

Hope we can get it in for 5.10. Let me try again to get the things moving.

@stevew817 stevew817 force-pushed the feature/EFM32GG11-OS5.9 branch from da991ad to 8439754 Compare June 14, 2018 09:16
@stevew817
Copy link
Contributor Author

@0xc0170 Licenses are now correctly applied

@cmonr cmonr dismissed 0xc0170’s stale review June 14, 2018 15:26

Licenses updated.

@cmonr
Copy link
Contributor

cmonr commented Jun 19, 2018

Man is this a feature-filled target.

@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-tls
Thoughts on at least sections of this PR?

SeppoTakalo
SeppoTakalo previously approved these changes Jun 19, 2018
0xc0170
0xc0170 previously approved these changes Jun 19, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 20, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 20, 2018

Build : FAILURE

Build number : 2398
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7079/

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 21, 2018

Please review the latest test results - fails to find malloc.h file?

@KariHaapalehto
Copy link
Contributor

KariHaapalehto commented Jun 21, 2018

Failing seems to happen with USI_WM_BN_BM_22-target, which is meant to be base target for MTB_USI_WM_BN_BM_22 and MTB_ADV_WISE_1530.
MTB_USI_WM_BN_BM_22 and MTB_ADV_WISE_1530 are inheriting USI_WM_BN_BM_22,
so USI_WM_BN_BM_22 is not meant to be real target. I'll add the:
"public": false
to target.json

@stevew817 stevew817 force-pushed the feature/EFM32GG11-OS5.9 branch from f393cd2 to 7aeacfa Compare July 11, 2018 16:10
@stevew817
Copy link
Contributor Author

Well, that was an unfortunate surprise. I guess having the PR open for this long does make it prone to master being a very moving target.

Rebased to master and fixed. Should be passing now. @cmonr

@stevew817 stevew817 force-pushed the feature/EFM32GG11-OS5.9 branch from 7aeacfa to da377c6 Compare July 11, 2018 16:13
@cmonr
Copy link
Contributor

cmonr commented Jul 11, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 11, 2018

Build : SUCCESS

Build number : 2576
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7079/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 11, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 12, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 12, 2018

Test errors not related, we will investigate

@cmonr
Copy link
Contributor

cmonr commented Jul 12, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Jul 13, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 13, 2018

Full rebuild needed

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 13, 2018

Build : SUCCESS

Build number : 2596
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7079/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 13, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 13, 2018

@cmonr
Copy link
Contributor

cmonr commented Jul 19, 2018

Damn it. Because this was closed and re-opened, the PR lost the release tag, and we brought it in without one, meaning it missed the 5.9.3 release...

At least now it'll be in 5.9.4.
@ARMmbed/mbed-os-maintainers we missed one :/

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
@amq
Copy link
Contributor

amq commented Feb 9, 2019

@stevew817 do you also plan to add support for CAN?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.