Silicon Labs: Add support for hardware CRC #7479

stevew817 · 2018-07-11T16:38:55Z

Description

Adding in support for the mbed CRC API, such that CRC calculations can be accelerated by hardware on EFM32PG, EFR32MG and EFM32GG11.

Test results:

mbedgt: checking for GCOV data...
mbedgt: mbed-host-test-runner: stopped and returned 'OK'
mbedgt: test on hardware with target id: 204100ED0001B6F4D6B5856F
mbedgt: test suite 'tests-mbed_hal-crc' .............................................................. OK in 26.53 sec
	test case: 'test: CRC calculation - multi input.' ............................................ OK in 0.00 sec
	test case: 'test: CRC calculation - single input.' ........................................... OK in 0.00 sec
	test case: 'test: hal_crc_compute_partial() - invalid parameters.' ........................... OK in 0.02 sec
	test case: 'test: hal_crc_is_supported() - invalid parameter.' ............................... OK in 0.00 sec
	test case: 'test: re-configure without getting the result.' .................................. OK in 0.00 sec
	test case: 'test: supported polynomials.' .................................................... OK in 0.00 sec
mbedgt: test case summary: 6 passes, 0 failures
mbedgt: all tests finished!
mbedgt: shuffle seed: 0.5187645681
mbedgt: test suite report:
+---------------------+---------------+--------------------+--------+--------------------+-------------+
| target              | platform_name | test suite         | result | elapsed_time (sec) | copy_method |
+---------------------+---------------+--------------------+--------+--------------------+-------------+
| TB_SENSE_12-GCC_ARM | TB_SENSE_12   | tests-mbed_hal-crc | OK     | 26.53              | default     |
+---------------------+---------------+--------------------+--------+--------------------+-------------+
mbedgt: test suite results: 1 OK
mbedgt: test case report:
+---------------------+---------------+--------------------+-------------------------------------------------------+--------+--------+--------+--------------------+
| target              | platform_name | test suite         | test case                                             | passed | failed | result | elapsed_time (sec) |
+---------------------+---------------+--------------------+-------------------------------------------------------+--------+--------+--------+--------------------+
| TB_SENSE_12-GCC_ARM | TB_SENSE_12   | tests-mbed_hal-crc | test: CRC calculation - multi input.                  | 1      | 0      | OK     | 0.0                |
| TB_SENSE_12-GCC_ARM | TB_SENSE_12   | tests-mbed_hal-crc | test: CRC calculation - single input.                 | 1      | 0      | OK     | 0.0                |
| TB_SENSE_12-GCC_ARM | TB_SENSE_12   | tests-mbed_hal-crc | test: hal_crc_compute_partial() - invalid parameters. | 1      | 0      | OK     | 0.02               |
| TB_SENSE_12-GCC_ARM | TB_SENSE_12   | tests-mbed_hal-crc | test: hal_crc_is_supported() - invalid parameter.     | 1      | 0      | OK     | 0.0                |
| TB_SENSE_12-GCC_ARM | TB_SENSE_12   | tests-mbed_hal-crc | test: re-configure without getting the result.        | 1      | 0      | OK     | 0.0                |
| TB_SENSE_12-GCC_ARM | TB_SENSE_12   | tests-mbed_hal-crc | test: supported polynomials.                          | 1      | 0      | OK     | 0.0                |
+---------------------+---------------+--------------------+-------------------------------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 6 OK
mbedgt: completed in 28.72 sec

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

cmonr

LGTM. Will wait for one other before starting CI

screamerbg · 2018-07-12T07:06:06Z

LGTM

mprse

Implementation consistent with the requirements.

ashok-rao

LGTM! Thanks @stevew817

0xc0170 · 2018-07-12T08:58:56Z

/morph build

mbed-ci · 2018-07-12T10:28:25Z

Build : SUCCESS

Build number : 2583
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7479/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-07-12T12:33:16Z

Exporter Build : SUCCESS

Build number : 2225
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7479/

mbed-ci · 2018-07-12T20:08:36Z

Test : SUCCESS

Build number : 2335
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7479/2335

deepikabhavnani · 2018-07-12T21:01:49Z

targets/TARGET_Silicon_Labs/TARGET_EFM32/crc_api.c

+
+bool hal_crc_is_supported(const crc_mbed_config_t *config)
+{
+    //GPCRC supports any 16-bit poly, but only the CCITT 32-bit poly


Looks good to me, just one query / concern, GPCRC_PRESENT will always be present for all targets?
In case DEVICE_CRC is true and GPCRC_PRESENT is not defined hal_crc_is_supported should return false and rest of the API's should just return.

DEVICE_CRC is a target-specific definition through targets.json, while GPCRC_PRESENT is a Silicon Labs CMSIS define. If a device doesn't have a GPCRC engine, then we don't add the CRC capability to its entry in targets.json.

The reason for still having the DEVICE_CRC define is to allow people to turn off CRC acceleration if they should want to do so.

stevew817 · 2018-07-16T09:09:29Z

Rebased on master and added CRC capability to EFM32GG11 as well, now that #7079 was merged.

cmonr · 2018-07-16T14:35:11Z

/morph build

mbed-ci · 2018-07-16T16:37:31Z

Build : SUCCESS

Build number : 2614
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7479/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-07-16T19:24:46Z

Test : SUCCESS

Build number : 2364
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7479/2364

stevew817 · 2018-07-17T08:59:27Z

@0xc0170 Is the exporter really still 'in progress' after 16 hours?

0xc0170 · 2018-07-17T09:05:31Z

Completed but not reported back, restarting

/morph export-build

stevew817 · 2018-07-18T12:35:52Z

@0xc0170 Still nothing...

cmonr · 2018-07-18T13:42:12Z

That's weird. I've never seen the pipeline get stuck like that...

/morph export-build

Should be <2h now.

stevew817 · 2018-07-18T19:46:19Z

@cmonr No dice...

mbed-ci · 2018-07-18T20:17:38Z

Exporter Build : FAILURE

Build number : 2272
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7479/

stevew817 · 2018-07-18T20:35:16Z

Oh goodness, looks like either someone needs to make a call to Sweden or implement better resource management for CI resources...

cmonr · 2018-07-19T01:22:31Z

Sorry, but it looks like the CI is having a day...
We're looking into it, and hopefully people in the opposite timezone from me will be able to iron out issues to get this re-run.

cmonr · 2018-07-19T14:16:40Z

/morph export-build

mbed-ci · 2018-07-19T16:28:41Z

Exporter Build : SUCCESS

Build number : 2274
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7479/

Silicon Labs: Add support for hardware CRC

cmonr requested review from screamerbg and ashok-rao July 12, 2018 02:19

cmonr added the needs: review label Jul 12, 2018

cmonr requested a review from deepikabhavnani July 12, 2018 02:20

cmonr approved these changes Jul 12, 2018

View reviewed changes

mprse approved these changes Jul 12, 2018

View reviewed changes

ashok-rao approved these changes Jul 12, 2018

View reviewed changes

0xc0170 approved these changes Jul 12, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Jul 12, 2018

deepikabhavnani reviewed Jul 12, 2018

View reviewed changes

0xc0170 added needs: review and removed needs: CI labels Jul 13, 2018

Add implementation for CRC API

8649162

stevew817 force-pushed the feature/crc branch from 220e9a4 to 8649162 Compare July 16, 2018 09:09

deepikabhavnani approved these changes Jul 16, 2018

View reviewed changes

cmonr added needs: CI and removed needs: review labels Jul 16, 2018

cmonr added the release-version: 5.9.4 label Jul 19, 2018

cmonr merged commit 2188110 into ARMmbed:master Jul 19, 2018

0xc0170 removed the needs: CI label Jul 19, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7479 from SiliconLabs/feature/crc

20e395e

Silicon Labs: Add support for hardware CRC

Silicon Labs: Add support for hardware CRC #7479

Silicon Labs: Add support for hardware CRC #7479

Uh oh!

Conversation

stevew817 commented Jul 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

cmonr left a comment

Choose a reason for hiding this comment

Uh oh!

screamerbg commented Jul 12, 2018

Uh oh!

mprse left a comment

Choose a reason for hiding this comment

Uh oh!

ashok-rao left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jul 12, 2018

Uh oh!

mbed-ci commented Jul 12, 2018

Triggering tests

Uh oh!

mbed-ci commented Jul 12, 2018

Uh oh!

mbed-ci commented Jul 12, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stevew817 commented Jul 16, 2018

Uh oh!

cmonr commented Jul 16, 2018

Uh oh!

mbed-ci commented Jul 16, 2018

Triggering tests

Uh oh!

mbed-ci commented Jul 16, 2018

Uh oh!

stevew817 commented Jul 17, 2018

Uh oh!

0xc0170 commented Jul 17, 2018

Uh oh!

stevew817 commented Jul 18, 2018

Uh oh!

cmonr commented Jul 18, 2018

Uh oh!

stevew817 commented Jul 18, 2018

Uh oh!

mbed-ci commented Jul 18, 2018

Uh oh!

stevew817 commented Jul 18, 2018

Uh oh!

cmonr commented Jul 19, 2018

Uh oh!

cmonr commented Jul 19, 2018

Uh oh!

mbed-ci commented Jul 19, 2018

Uh oh!

Uh oh!

stevew817 commented Jul 11, 2018 •

edited

Loading