-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32F76x: Add support of dual bank flash mode #7088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dhwalters423 Please review. Does this address the issue you reported? |
#ifdef MBED_CONF_TARGET_FLASH_DUAL_BANK | ||
if ((OBInit.USERConfig & OB_NDBANK_SINGLE_BANK) == OB_NDBANK_SINGLE_BANK) | ||
{ | ||
error("The Dual Bank mode option byte (nDBANK) must be enabled (box unchecked)\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SenRamakri with the latest changes to the error handling, can you review this error handling
67fbdb1
to
b79be41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review done.
Tests also verified on my side with single and dual configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you!
I was able to test this by cherry picking commit into Mbed OS 5.7.4, and running Simple Cloud Client 1.3 for the NUCLEO F767ZI: https://os.mbed.com/users/dwaltersARM/code/example-Ethernet-mbed-Cloud-connect/
I used the following sector layout for SOTP/RoT:
"app.sotp-section-1-address": "(0x081C0000)",
"app.sotp-section-1-size" : "(1281024)",
"app.sotp-section-2-address": "(0x081E0000)",
"app.sotp-section-2-size" : "(1281024)"
(sectors 22 and 23 on the 767ZI)
The RoT was inserted and preserved correctly while stored in those sectors.
We should be sure to document the process with ST-Link utility to switch the platforms into Dual Bank mode on the platform page: https://os.mbed.com/platforms/ST-Nucleo-F767ZI/
Thanks for the testing.
I will explain this in a WIKI page (in ST team area on mbed.org) as soon this PR is merged. |
/morph build |
Build : SUCCESSBuild number : 2265 Triggering tests/morph test |
Halting CI builds until RC3 PRs are completed. Will resume after. |
/morph test |
Exporter Build : SUCCESSBuild number : 1901 |
Test : SUCCESSBuild number : 2062 |
Looks good! |
Exporter Build : FAILUREBuild number : 1960 |
Description
This PR adds support of Dual Bank flash mode on NUCLEO_F767ZI and DISCO_F769NI platforms.
Fixes Issue #6955
Tested OK using tests-mbed_drivers-flashiap and tests-mbed_hal-flash tests.
Note
The Single Bank mode is selected by default on these 2 boards.
To enable the Dual Bank mode you have to:
Uncyclo page:
https://os.mbed.com/teams/ST/wiki/How-to-enable-flash-dual-bank
Pull request type