Release candidate 2 for mbed-os-5.9.0

TESTS/mbed_drivers/timer/main.cpp

@@ -45,9 +45,15 @@ extern uint32_t SystemCoreClock;
  * 1000 ms delay: tolerance = 20500 us
  *
  *  */
-#define DELTA_US(delay_ms) (500 + (delay_ms) * US_PER_MSEC / 50)
-#define DELTA_MS(delay_ms) (1 + ((delay_ms) * US_PER_MSEC / 50 / US_PER_MSEC))
-#define DELTA_S(delay_ms) (0.000500f + (((float)(delay_ms)) / MSEC_PER_SEC / 50))
+#ifdef NO_SYSTICK
+#define TOLERANCE 5
+#else
+#define TOLERANCE 2
+#endif
+
+#define DELTA_US(delay_ms) (500 + (delay_ms) * US_PER_MSEC  * TOLERANCE / 100)
+#define DELTA_MS(delay_ms) (1 + (delay_ms) * TOLERANCE / 100)
+#define DELTA_S(delay_ms) (0.000500f + ((float)(delay_ms)) * ((float)(TOLERANCE) / 100.f) / MSEC_PER_SEC)
 
 #define TICKER_FREQ_1MHZ 1000000
 #define TICKER_BITS 32

TESTS/mbed_hal/common_tickers/main.cpp

@@ -344,20 +344,34 @@ void ticker_increment_test(void)
     } else {  // high frequency tickers
 
         uint32_t num_of_cycles = NUM_OF_CYCLES;
+        const uint32_t repeat_count = 20;
+        const uint32_t max_inc_val = 100;
 
         uint32_t base_tick_count = count_ticks(num_of_cycles, 1);
         uint32_t next_tick_count = base_tick_count;
         uint32_t inc_val = 0;
+        uint32_t repeat_cnt = 0;
 
-        while (inc_val < 100) {
-
+        while (inc_val < max_inc_val) {
             next_tick_count = count_ticks(num_of_cycles + inc_val, 1);
 
             if (next_tick_count == base_tick_count) {
 
-                /* Same tick count, so increase num of cycles. */
-                inc_val++;
+                /* Same tick count, so repeat 20 times and than
+                 * increase num of cycles by 1.
+                 */
+                if (repeat_cnt == repeat_count) {
+                    inc_val++;
+                    repeat_cnt = 0;
+                }
+
+                repeat_cnt++;
             } else {
+                /* Check if we got 1 tick diff. */
+                if (next_tick_count - base_tick_count == 1 ||
+                    base_tick_count - next_tick_count == 1) {
+                    break;
+                }
 
                 /* It is possible that the difference between base and next
                  * tick count on some platforms is greater that 1, in this case we need
@@ -366,12 +380,8 @@ void ticker_increment_test(void)
                  */
                 num_of_cycles /= 2;
                 inc_val = 0;
+                repeat_cnt = 0;
                 base_tick_count = count_ticks(num_of_cycles, 1);
-
-                if (next_tick_count - base_tick_count == 1 ||
-                    base_tick_count - next_tick_count == 1) {
-                    break;
-                }
             }
         }
 

TESTS/mbed_platform/stats_sys/main.cpp

@@ -32,10 +32,6 @@ void test_sys_info()
     mbed_stats_sys_t stats;
     mbed_stats_sys_get(&stats);
 
-#if defined(MBED_VERSION)
-    TEST_ASSERT_NOT_EQUAL(0, stats.os_version);
-#endif
-
 #if defined(__CORTEX_M)
     TEST_ASSERT_NOT_EQUAL(0, stats.cpu_id);
 #endif

cmsis/RTE_Components.h

@@ -18,7 +18,9 @@
 
 #define CMSIS_device_header <cmsis.h>
 
+#if defined(MBED_CONF_RTOS_PRESENT)
 #include "mbed_rtx_conf.h"
+#endif
 #include "mbed_cmsis_conf.h"
 
 #endif

features/FEATURE_BLE/ble/generic/SecurityDb.h

@@ -584,28 +584,32 @@ class SecurityDb {
         WhitelistDbCb_t cb,
         ::Gap::Whitelist_t *whitelist
     ) {
-        for (size_t i = 0; i < get_entry_count() && i < whitelist->capacity; i++) {
+        for (size_t i = 0; i < get_entry_count() && whitelist->size < whitelist->capacity; i++) {
             entry_handle_t db_handle = get_entry_handle_by_index(i);
             SecurityDistributionFlags_t* flags = get_distribution_flags(db_handle);
 
             if (!flags) {
                 continue;
             }
 
+            SecurityEntryIdentity_t* identity = read_in_entry_peer_identity(db_handle);
+            if (!identity) {
+                continue;
+            }
+
+            memcpy(
+                whitelist->addresses[whitelist->size].address,
+                identity->identity_address.data(),
+                sizeof(BLEProtocol::AddressBytes_t)
+            );
+
             if (flags->peer_address_is_public) {
-                whitelist->addresses[i].type = BLEProtocol::AddressType::PUBLIC;
+                whitelist->addresses[whitelist->size].type = BLEProtocol::AddressType::PUBLIC;
             } else {
-                whitelist->addresses[i].type = BLEProtocol::AddressType::RANDOM_STATIC;
+                whitelist->addresses[whitelist->size].type = BLEProtocol::AddressType::RANDOM_STATIC;
             }
 
-            SecurityEntryIdentity_t* identity = read_in_entry_peer_identity(db_handle);
-            if (identity) {
-                memcpy(
-                    whitelist->addresses[i].address,
-                    identity->identity_address.data(),
-                    sizeof(BLEProtocol::AddressBytes_t)
-                );
-            }
+            whitelist->size++;
         }
 
         cb(whitelist);

features/FEATURE_BLE/source/generic/GenericSecurityManager.cpp

@@ -142,6 +142,9 @@ ble_error_t GenericSecurityManager::purgeAllBondingState(void) {
 ble_error_t GenericSecurityManager::generateWhitelistFromBondTable(Gap::Whitelist_t *whitelist) const {
     if (!_db) return BLE_ERROR_INITIALIZATION_INCOMPLETE;
     if (eventHandler) {
+        if (!whitelist) {
+            return BLE_ERROR_INVALID_PARAM;
+        }
         _db->generate_whitelist_from_bond_table(
             mbed::callback(eventHandler, &::SecurityManager::EventHandler::whitelistFromBondTable),
             whitelist

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NRF51/source/nRF5xGap.cpp

@@ -1266,7 +1266,7 @@ void nRF5xGap::on_connection(Gap::Handle_t handle, const ble_gap_evt_connected_t
         const resolving_list_entry_t* entry = get_sm().resolve_address(
             evt.peer_addr.addr
         );
-        MBED_ASSERT(entry == NULL);
+        MBED_ASSERT(entry != NULL);
 
         peer_addr_type = convert_identity_address(entry->peer_identity_address_type);
         peer_address = entry->peer_identity_address.data();

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NRF52/source/nRF5xCrypto.cpp

@@ -47,6 +47,7 @@ namespace vendor {
 namespace nordic {
 
 CryptoToolbox::CryptoToolbox() : _initialized(false) {
+    mbedtls_platform_setup(&_platform_context);
     mbedtls_entropy_init(&_entropy_context);
     mbedtls_ecp_group_init(&_group);
     int err = mbedtls_ecp_group_load(
@@ -59,6 +60,7 @@ CryptoToolbox::CryptoToolbox() : _initialized(false) {
 CryptoToolbox::~CryptoToolbox() {
     mbedtls_ecp_group_free(&_group);
     mbedtls_entropy_free(&_entropy_context);
+    mbedtls_platform_teardown(&_platform_context);
 }
 
 bool CryptoToolbox::generate_keys(

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NRF52/source/nRF5xCrypto.h

@@ -132,6 +132,7 @@ class CryptoToolbox : mbed::NonCopyable<CryptoToolbox> {
     void swap_endian(uint8_t* buf, size_t len);
 
     bool _initialized;
+    mbedtls_platform_context _platform_context;
     mbedtls_entropy_context _entropy_context;
     mbedtls_ecp_group _group;
 };

features/FEATURE_UVISOR/includes/uvisor/api/inc/uvisor_deprecation.h

@@ -18,7 +18,8 @@
 #define __UVISOR_DEPRECATION_H__
 
 #if defined(UVISOR_PRESENT) && UVISOR_PRESENT == 1
-#warning "Warning: You are using FEATURE_UVISOR, which is unsupported as of Mbed OS 5.9."
+#warning "Warning: uVisor is superseded by the Secure Partition Manager (SPM) defined in the ARM Platform Security Architecture (PSA). \
+          uVisor is deprecated as of Mbed OS 5.10, and being replaced by a native PSA-compliant implementation of SPM."
 #endif
 
 #endif  // __UVISOR_DEPRECATION_H__

platform/mbed_error.c

@@ -51,6 +51,7 @@ static mbed_error_ctx first_error_ctx = {0};
 static mbed_error_ctx last_error_ctx = {0};
 static mbed_error_hook_t error_hook = NULL;
 static void print_error_report(mbed_error_ctx *ctx, const char *);
+static mbed_error_status_t handle_error(mbed_error_status_t error_status, unsigned int error_value, const char *filename, int line_number);
 
 //Helper function to halt the system
 static void mbed_halt_system(void)
@@ -72,20 +73,23 @@ WEAK void error(const char* format, ...) {
     if (error_in_progress) {
         return;
     }
+
+    //Call handle_error/print_error_report permanently setting error_in_progress flag
+    handle_error(MBED_ERROR_UNKNOWN, 0, NULL, 0);
+    print_error_report(&last_error_ctx, "Fatal Run-time error");
     error_in_progress = 1;
 
 #ifndef NDEBUG
     va_list arg;
     va_start(arg, format);
     mbed_error_vfprintf(format, arg);
-    MBED_ERROR(MBED_ERROR_UNKNOWN, "Fatal Run-time Error");
     va_end(arg);
 #endif
     exit(1);
 }
 
 //Set an error status with the error handling system
-mbed_error_status_t handle_error(mbed_error_status_t error_status, const char *error_msg, unsigned int error_value, const char *filename, int line_number) 
+static mbed_error_status_t handle_error(mbed_error_status_t error_status, unsigned int error_value, const char *filename, int line_number) 
 {
     mbed_error_ctx current_error_ctx;
 
@@ -129,16 +133,10 @@ mbed_error_status_t handle_error(mbed_error_status_t error_status, const char *e
 
 #ifdef MBED_CONF_ERROR_FILENAME_CAPTURE_ENABLED
     //Capture filename/linenumber if provided
-    //Index for tracking error_filename 
-    int idx = 0;
-
-    if(NULL != filename) {
-        while(idx < MBED_CONF_MAX_ERROR_FILENAME_LEN && (filename[idx] != '\0')) {
-            current_error_ctx.error_filename[idx] = filename[idx];
-            idx++;
-        }
-        current_error_ctx.error_line_number = line_number;
-    }
+    //Index for tracking error_filename
+    memset(&current_error_ctx.error_filename, 0, MBED_CONF_MAX_ERROR_FILENAME_LEN);
+    strncpy(current_error_ctx.error_filename, filename, MBED_CONF_MAX_ERROR_FILENAME_LEN);
+    current_error_ctx.error_line_number = line_number;
 #endif
 
     //Capture the fist system error and store it
@@ -188,14 +186,14 @@ int mbed_get_error_count(void)
 //Sets a fatal error 
 mbed_error_status_t mbed_warning(mbed_error_status_t error_status, const char *error_msg, unsigned int error_value, const char *filename, int line_number) 
 {
-    return handle_error(error_status, error_msg, error_value, filename, line_number);
+    return handle_error(error_status, error_value, filename, line_number);
 }
 
 //Sets a fatal error 
 WEAK mbed_error_status_t mbed_error(mbed_error_status_t error_status, const char *error_msg, unsigned int error_value, const char *filename, int line_number) 
 {
     //set the error reported and then halt the system
-    if( MBED_SUCCESS != handle_error(error_status, error_msg, error_value, filename, line_number) )
+    if( MBED_SUCCESS != handle_error(error_status, error_value, filename, line_number) )
         return MBED_ERROR_FAILED_OPERATION;
 
     //On fatal errors print the error context/report
@@ -359,7 +357,7 @@ static void print_error_report(mbed_error_ctx *ctx, const char *error_msg)
     uint32_t error_code = MBED_GET_ERROR_CODE(ctx->error_status);
     uint32_t error_module = MBED_GET_ERROR_MODULE(ctx->error_status);
 
-    mbed_error_printf("\n\n++ MbedOS Error Info ++\nError Status: 0x%x Code: %d Entity: %d\nError Message: ", ctx->error_status, error_code, error_module);
+    mbed_error_printf("\n\n++ MbedOS Error Info ++\nError Status: 0x%x Code: %d Module: %d\nError Message: ", ctx->error_status, error_code, error_module);
 
     //Report error info based on error code, some errors require different 
     //error_vals[1] contains the error code
@@ -410,12 +408,10 @@ static void print_error_report(mbed_error_ctx *ctx, const char *error_msg)
         }
         mbed_error_printf(error_msg, NULL);
         mbed_error_printf("\nLocation: 0x%x", ctx->error_address);
-#ifdef MBED_CONF_ERROR_FILENAME_CAPTURE_ENABLED
-        if(NULL != error_ctx->error_filename) {
+#if defined(MBED_CONF_ERROR_FILENAME_CAPTURE_ENABLED) && !defined(NDEBUG)
+        if(NULL != ctx->error_filename) {
             //for string, we must pass address of a ptr which has the address of the string 
-            uint32_t *file_name = (uint32_t *)&error_ctx->error_filename[0];
-            mbed_error_printf("\nFile:%s", &file_name);
-            mbed_error_printf("+0x%x", ctx->error_line_number);
+            mbed_error_printf("\nFile:%s+%d", ctx->error_filename, ctx->error_line_number);
         }
 #endif 
 
@@ -429,7 +425,7 @@ static void print_error_report(mbed_error_ctx *ctx, const char *error_msg)
 #endif //TARGET_CORTEX_M
     }
 
-    mbed_error_printf("\n-- MbedOS Error Info --");
+    mbed_error_printf("\n-- MbedOS Error Info --\n");
 }
 
 

platform/mbed_error.h

@@ -143,12 +143,17 @@ typedef int mbed_error_status_t;
  *        Since this macro is a wrapper for mbed_warning API callers should process the return value from this macro which is the return value from calling mbed_error API.
  *
  */
-#ifdef MBED_CONF_ERROR_FILENAME_CAPTURE_ENABLED
-    #define MBED_WARNING1( error_status, error_msg, error_value )     mbed_warning( error_status, (const char *)error_msg, (uint32_t)error_value, (const char *)MBED_FILENAME, __LINE__ )
-    #define MBED_WARNING( error_status, error_msg )                   mbed_warning( error_status, (const char *)error_msg, (uint32_t)0          , (const char *)MBED_FILENAME, __LINE__ )
+#ifdef NDEBUG
+    #define MBED_WARNING1( error_status, error_msg, error_value )         mbed_warning( error_status, (const char *)NULL, (uint32_t)error_value, NULL, 0 )
+    #define MBED_WARNING( error_status, error_msg )                       mbed_warning( error_status, (const char *)NULL, (uint32_t)0,           NULL, 0 )    
 #else
-    #define MBED_WARNING1( error_status, error_msg, error_value )     mbed_warning( error_status, (const char *)error_msg, (uint32_t)error_value, NULL, 0 )
-    #define MBED_WARNING( error_status, error_msg )                   mbed_warning( error_status, (const char *)error_msg, (uint32_t)0,           NULL, 0 )    
+    #if defined(MBED_CONF_ERROR_FILENAME_CAPTURE_ENABLED)
+        #define MBED_WARNING1( error_status, error_msg, error_value )     mbed_warning( error_status, (const char *)error_msg, (uint32_t)error_value, (const char *)MBED_FILENAME, __LINE__ )
+        #define MBED_WARNING( error_status, error_msg )                   mbed_warning( error_status, (const char *)error_msg, (uint32_t)0          , (const char *)MBED_FILENAME, __LINE__ )
+    #else
+        #define MBED_WARNING1( error_status, error_msg, error_value )     mbed_warning( error_status, (const char *)error_msg, (uint32_t)error_value, NULL, 0 )
+        #define MBED_WARNING( error_status, error_msg )                   mbed_warning( error_status, (const char *)error_msg, (uint32_t)0,           NULL, 0 )    
+    #endif    
 #endif
 
 /**
@@ -170,13 +175,18 @@ typedef int mbed_error_status_t;
  *       Since this macro is a wrapper for mbed_error API callers should process the return value from this macro which is the return value from calling mbed_error API. 
  *
  */
-#ifdef MBED_CONF_ERROR_FILENAME_CAPTURE_ENABLED
-    #define MBED_ERROR1( error_status, error_msg, error_value )       mbed_error( error_status, (const char *)error_msg, (uint32_t)error_value, (const char *)MBED_FILENAME, __LINE__ )
-    #define MBED_ERROR( error_status, error_msg )                     mbed_error( error_status, (const char *)error_msg, (uint32_t)0          , (const char *)MBED_FILENAME, __LINE__ )
+#ifdef NDEBUG
+    #define MBED_ERROR1( error_status, error_msg, error_value )           mbed_error( error_status, (const char *)NULL, (uint32_t)error_value, NULL, 0 )
+    #define MBED_ERROR( error_status, error_msg )                         mbed_error( error_status, (const char *)NULL, (uint32_t)0          , NULL, 0 )
 #else
-    #define MBED_ERROR1( error_status, error_msg, error_value )       mbed_error( error_status, (const char *)error_msg, (uint32_t)error_value, NULL, 0 )
-    #define MBED_ERROR( error_status, error_msg )                     mbed_error( error_status, (const char *)error_msg, (uint32_t)0          , NULL, 0 )
-#endif         
+    #if defined(MBED_CONF_ERROR_FILENAME_CAPTURE_ENABLED)
+        #define MBED_ERROR1( error_status, error_msg, error_value )       mbed_error( error_status, (const char *)error_msg, (uint32_t)error_value, (const char *)MBED_FILENAME, __LINE__ )
+        #define MBED_ERROR( error_status, error_msg )                     mbed_error( error_status, (const char *)error_msg, (uint32_t)0          , (const char *)MBED_FILENAME, __LINE__ )
+    #else
+        #define MBED_ERROR1( error_status, error_msg, error_value )       mbed_error( error_status, (const char *)error_msg, (uint32_t)error_value, NULL, 0 )
+        #define MBED_ERROR( error_status, error_msg )                     mbed_error( error_status, (const char *)error_msg, (uint32_t)0          , NULL, 0 )
+    #endif    
+#endif
 
 //Error Type definition
 /** mbed_error_type_t definition

platform/mbed_stats.c

@@ -123,9 +123,6 @@ void mbed_stats_sys_get(mbed_stats_sys_t *stats)
     memset(stats, 0, sizeof(mbed_stats_sys_t));
 
 #if defined(MBED_SYS_STATS_ENABLED)
-#if defined(MBED_VERSION)
-    stats->os_version = MBED_VERSION;
-#endif
 #if defined(__CORTEX_M)
     stats->cpu_id = SCB->CPUID;
 #endif

targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52832/device/TOOLCHAIN_ARM_STD/nRF52832.sct

@@ -27,6 +27,11 @@ LR_IROM1 MBED_APP_START MBED_APP_SIZE {
   ER_IROM1 MBED_APP_START MBED_APP_SIZE {
    *.o (RESET, +First)
    *(InRoot$$Sections)
+   __start_sdh_soc_observers *(sdh_soc_observers) __stop_sdh_soc_observers
+   __start_sdh_stack_observers *(sdh_stack_observers) __stop_sdh_stack_observers
+   __start_sdh_req_observers *(sdh_req_observers) __stop_sdh_req_observers
+   __start_sdh_state_observers *(sdh_state_observers) __stop_sdh_state_observers
+   __start_sdh_ble_observers *(sdh_ble_observers) __stop_sdh_ble_observers
    .ANY (+RO)
   }
   RW_IRAM0 MBED_RAM0_START UNINIT MBED_RAM0_SIZE { ;no init section

targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52840/device/TOOLCHAIN_ARM_STD/nRF52840.sct

@@ -27,6 +27,11 @@ LR_IROM1 MBED_APP_START MBED_APP_SIZE {
   ER_IROM1 MBED_APP_START MBED_APP_SIZE {
    *.o (RESET, +First)
    *(InRoot$$Sections)
+   __start_sdh_soc_observers *(sdh_soc_observers) __stop_sdh_soc_observers
+   __start_sdh_stack_observers *(sdh_stack_observers) __stop_sdh_stack_observers
+   __start_sdh_req_observers *(sdh_req_observers) __stop_sdh_req_observers
+   __start_sdh_state_observers *(sdh_state_observers) __stop_sdh_state_observers
+   __start_sdh_ble_observers *(sdh_ble_observers) __stop_sdh_ble_observers   
    .ANY (+RO)
   }
   RW_IRAM0 MBED_RAM0_START UNINIT MBED_RAM0_SIZE { ;no init section

targets/TARGET_NXP/TARGET_LPC176X/TARGET_UBLOX_C027/ublox_low_level_api.c

@@ -42,6 +42,7 @@ void ublox_mdm_init(void)
     // Can't use wait_ms() as RTOS isn't initialised yet
     //wait_ms(50); // when USB cable is inserted the interface chip issues
     // Here's the code from the non-RTOS version
+    us_ticker_init();
     uint32_t start = us_ticker_read();
     while ((us_ticker_read() - start) < 50000);
 }