Skip to content

Release candidate 2 for mbed-os-5.9.0 #7122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jun 6, 2018
Merged

Conversation

adbridge
Copy link
Contributor

@adbridge adbridge commented Jun 5, 2018

No description provided.

mprse and others added 26 commits June 5, 2018 15:05
In case when base tick count is different than next tick count check first if the difference is equal to 1 tick (this is what we are looking for) if not then decrease the tick count.

Repeat counting process few times before incrementing the number of cycles in case when base tick count is equal to next tick count.
…. Corrected instance of hard-coded unix path separator.
Remove additional redundant libraries, that were accidently added in merges
… iteration over values. Py3 no longer supports dictionaries that self-modify their item lists during iteration.
…art of test that was incompatible with Py3 on Windows.
@adbridge
Copy link
Contributor Author

adbridge commented Jun 5, 2018

/morph build
/morph mbed2-release

@mbed-ci
Copy link

mbed-ci commented Jun 5, 2018

Build : SUCCESS

Build number : 2242
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7122/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 5, 2018

@studavekar
Copy link
Contributor

/morph mbed2-release

@studavekar
Copy link
Contributor

mbed2 release command has to only morph command in the comment for it to get triggered
/morph mbed2-release

@mbed-ci
Copy link

mbed-ci commented Jun 5, 2018

Build : SUCCESS

Build number : 2243
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7122/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-bot
Copy link

mbed-bot commented Jun 5, 2018

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph mbed2-release

Output

mbed Build Number: 106

Build failed!

@mbed-ci
Copy link

mbed-ci commented Jun 5, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 5, 2018

@cmonr
Copy link
Contributor

cmonr commented Jun 5, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 5, 2018

Build : SUCCESS

Build number : 2244
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7122/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 6, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 6, 2018

@cmonr
Copy link
Contributor

cmonr commented Jun 6, 2018

@TomoYamanaka @toyowata Do you think you could take a look at these issues today? It's not apparent because the last build didn't report properly, but the most recent ci-morph-mbed2-build job failed, with only the Cortex-A devices not building.

I've attached a few of the logs that have caused the failure. The failure is compiler agnostic, and appears to be rooted in a requirement on mbed_rtx_conf.h.

Reproduction of the error is actually quite simple. Checkin out this PR branch, and running the command in the logs results in the failure. For reference, the following is what I use whenever I need to check out a specific branch:

git clone https://github.com/ARMmbed/mbed-os
cd mbed-os

git fetch refs/pull/7122/head:pr7122
git checkout pr7122

Any help and/or insight y'all could provide would be helpful as we're trying to get this out ASAP. We have the extreme option of removing Mbed 2 support for the devices, but of course we'd like to avoid this if at all possible.

0xc0170 added 2 commits June 6, 2018 08:03
Notifier should be passed to build libs functions, otherwise it's
none and fails.

Missing notify object in toolchain also fixed.
it was removed recently, not used anymore
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 6, 2018

I've attached a few of the logs that have caused the failure. The failure is compiler agnostic, and appears to be rooted in a requirement on mbed_rtx_conf.h.

fixed on master. I changed the label version for the fix, should be here. And also another PR. We need to run release candidate script once more, should pick up 3 more commits. I can build with those 3 additional commits locally (tested few toolchains, RZ A1H, and few other targets).

@TomoYamanaka @toyowata Do you think you could take a look at these issues today? It's not apparent because the last build didn't report properly, but the most recent ci-morph-mbed2-build job failed, with only the Cortex-A devices not building.

Resolved on master, will be also here once we add 3 additional commits.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 6, 2018

@adbridge If we run release script, those 3 additional commits should be in.

See #7053 and #6914. However one commit from here is not yet on master (d743f7f), I'll try to add it to #7132

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 6, 2018

/morph build
/morph mbed2-release

@mbed-ci
Copy link

mbed-ci commented Jun 6, 2018

Build : SUCCESS

Build number : 2245
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7122/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 6, 2018

/morph mbed2-release

Update: I should have restarted build not release 😖 will fix

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 6, 2018

/morph mbed2-build

@mbed-bot
Copy link

mbed-bot commented Jun 6, 2018

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph mbed2-release

Output

mbed Build Number: 107

Build failed!

@adbridge
Copy link
Contributor Author

adbridge commented Jun 6, 2018

mbed2 still failing, several Nucleo boards.

04:02:05   * NUCLEO_F030R8::ARM::MBED
04:02:05         "/home/jenkins/build_node_4_2/workspace/bm_wrap/1698/mbed-os/targets/TARGET_STM/rtc_api.c", line 289: Warning:  #223-D: function "__HAL_RTC_WAKEUPTIMER_GET_IT" declared implicitly
04:02:05         "/home/jenkins/build_node_4_2/workspace/bm_wrap/1698/mbed-os/targets/TARGET_STM/rtc_api.c", line 293: Warning:  #223-D: function "__HAL_RTC_WAKEUPTIMER_CLEAR_FLAG" declared implicitly
04:02:05         "/home/jenkins/build_node_4_2/workspace/bm_wrap/1698/mbed-os/targets/TARGET_STM/rtc_api.c", line 309: Warning:  #223-D: function "__HAL_RTC_WAKEUPTIMER_EXTI_CLEAR_FLAG" declared implicitly
04:02:05         "/home/jenkins/build_node_4_2/workspace/bm_wrap/1698/mbed-os/targets/TARGET_STM/rtc_api.c", line 359: Warning:  #223-D: function "HAL_RTCEx_SetWakeUpTimer_IT" declared implicitly
04:02:05         "/home/jenkins/build_node_4_2/workspace/bm_wrap/1698/mbed-os/targets/TARGET_STM/rtc_api.c", line 359: Error:  #20: identifier "RTC_WAKEUPCLOCK_RTCCLK_DIV4" is undefined
04:02:05         "/home/jenkins/build_node_4_2/workspace/bm_wrap/1698/mbed-os/targets/TARGET_STM/rtc_api.c", line 380: Warning:  #223-D: function "HAL_RTCEx_DeactivateWakeUpTimer" declared implicitly
04:02:05         /home/jenkins/build_node_4_2/workspace/bm_wrap/1698/mbed-os/targets/TARGET_STM/rtc_api.c: 5 warnings, 1 error

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 6, 2018

@ARMmbed/team-st-mcd Please review above failure. I was able to reproduce this on master, a bug in rtc implementation, I am investigating.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 6, 2018

@ARMmbed/team-st-mcd Please review above failure. I was able to reproduce this on master, a bug in rtc implementation, I am investigating.

Tracking issue with details: #7140

@mbed-ci
Copy link

mbed-ci commented Jun 6, 2018

@jeromecoutant
Copy link
Collaborator

Hi
Please try #7143
Regards,

@studavekar
Copy link
Contributor

Test results : http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7122/2035

Comment from CI failed with following traceback hinting github server issue

Caused: org.kohsuke.github.HttpException: Server returned HTTP response code: -1, message: 'null' for URL: https://api.github.com/repos/ARMmbed/mbed-os/commits/c9338d180069087199744aa9fa4e9310737d8d95
	at org.kohsuke.github.Requester.parse(Requester.java:633)
	at org.kohsuke.github.Requester.parse(Requester.java:631)
	at org.kohsuke.github.Requester.parse(Requester.java:631)
	at org.kohsuke.github.Requester.parse(Requester.java:594)
	at org.kohsuke.github.Requester._to(Requester.java:272)
	at org.kohsuke.github.Requester.to(Requester.java:234)
	at org.kohsuke.github.GHRepository.getCommit(GHRepository.java:944)
	at org.jenkinsci.plugins.pipeline.githubstatusnotification.GitHubStatusNotificationStep$Execution.run(GitHubStatusNotificationStep.java:377)
Caused: java.lang.IllegalArgumentException: The specified commit does not exist in the specified repository
	at org.jenkinsci.plugins.pipeline.githubstatusnotification.GitHubStatusNotificationStep$Execution.run(GitHubStatusNotificationStep.java:379)
	at org.jenkinsci.plugins.pipeline.githubstatusnotification.GitHubStatusNotificationStep$Execution.run(GitHubStatusNotificationStep.java:355)
	at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1$1.call(AbstractSynchronousNonBlockingStepExecution.java:47)
	at hudson.security.ACL.impersonate(ACL.java:260)
	at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1.run(AbstractSynchronousNonBlockingStepExecution.java:44)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)

@0xc0170 0xc0170 merged commit 4aa2bf6 into mbed-os-5.9 Jun 6, 2018
@theotherjimmy theotherjimmy deleted the 5.9-release-candidate branch June 20, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.