build: fix notifier typo and passing to builds API #6914

0xc0170 · 2018-05-15T15:32:27Z

Description

Notifier should be passed to build libs functions, otherwise it's none and fails. To get this in, I would like first to have tests failing for mbed 2 builds to confirm this is fixing it (tested locally, it does build now).

@jeromecoutant This should fix the issue you reported few minutes ago.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

cmonr

LGTM

jeromecoutant · 2018-05-16T12:17:44Z

Hi Martin

This should fix the issue you reported few minutes ago

LGTM, Thx

jeromecoutant · 2018-05-16T12:19:31Z

Oups... I made a too quick answer...

$ python tools/build.py -m NUCLEO_F030R8 -t ARM
...
'ARM_STD' object has no attribute 'info'
Build failures:

Notifier should be passed to build libs functions, otherwise it's none and fails. Missing notify object in toolchain also fixed.

0xc0170 · 2018-05-16T12:31:17Z

Fixed, I noticed few self.info in toolchains init file. Fixed now, they invoke it via self.notify.info

jeromecoutant · 2018-05-16T14:57:57Z

Seems correction is not complete...

python tools/singletest.py -M muts_test.json -i muts_compilation.json -V -j 4
Traceback (most recent call last):
File "tools/singletest.py", line 262, in
if (singletest_in_cli_mode(single_test)):
File "C:\github\mbed\tools\test_api.py", line 1547, in singletest_in_cli_mode
test_summary, shuffle_seed, test_summary_ext, test_suite_properties_ext, build_report, build_properties = single_test.execute()
File "C:\github\mbed\tools\test_api.py", line 651, in execute
self.execute_thread_slice(q, target, toolchains, clean, test_ids, self.build_report, self.build_properties)
File "C:\github\mbed\tools\test_api.py", line 390, in execute_thread_slice
build_profile=profile)
TypeError: build_mbed_libs() got an unexpected keyword argument 'verbose'

it was removed recently, not used anymore

0xc0170 · 2018-05-16T15:20:27Z

I was after fixing build problem, but as we are on the subject, lets fix the verbose argument that is not there anymore.

Pushed a new commit, removing verbose from build libs as it's not defined anymore

jeromecoutant · 2018-05-17T07:47:00Z

File "C:\github\mbed\tools\build_api.py", line 1028, in build_mbed_libs
notify.info("Building library %s (%s, %s)" %
AttributeError: 'NoneType' object has no attribute 'info'

0xc0170 · 2018-05-18T13:20:50Z

Thanks @jeromecoutant . What is the command ? I would like to reproduce the issue. None should not be passed to build functions as notify argument or this needs a bit refactoring.

waiting for @theotherjimmy

jeromecoutant · 2018-05-21T08:26:56Z

What is the command ?

python tools/singletest.py --auto --tc ARM -n MBED_2

theotherjimmy · 2018-05-21T15:25:26Z

tools/build.py

@@ -197,6 +197,7 @@
                            name=options.artifact_name,
                            build_profile=profile,
                            ignore=options.ignore,
+                            notify = notifier,


Spaces should be removed.

theotherjimmy · 2018-05-21T15:25:52Z

@0xc0170 Would you like me to fix singletest.py?

cmonr · 2018-06-04T22:35:28Z

@0xc0170 ^^^ ?

theotherjimmy · 2018-06-04T22:35:48Z

@cmonr Let's get this in. Singletest can come as another PR, if at all.

cmonr · 2018-06-04T22:44:01Z

/morph build

mbed-ci · 2018-06-05T00:35:00Z

Build : SUCCESS

Build number : 2239
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6914/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-06-05T03:00:33Z

Test : SUCCESS

Build number : 2028
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6914/2028

mbed-ci · 2018-06-05T03:57:07Z

Exporter Build : SUCCESS

Build number : 1863
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6914/

jeromecoutant · 2018-06-05T06:57:47Z

No..
This PR doesn't correct the issue

python tools/singletest.py -M muts_test.json -i muts_compilation.json -V -j 4 -n MBED_2
Traceback (most recent call last):
  File "tools/singletest.py", line 262, in <module>
    if (singletest_in_cli_mode(single_test)):
  File "C:\github\mbed\tools\test_api.py", line 1545, in singletest_in_cli_mode
    test_summary, shuffle_seed, test_summary_ext, test_suite_properties_ext, build_report, build_properties = single_test.execute()
  File "C:\github\mbed\tools\test_api.py", line 649, in execute
    self.execute_thread_slice(q, target, toolchains, clean, test_ids, self.build_report, self.build_properties)
  File "C:\github\mbed\tools\test_api.py", line 389, in execute_thread_slice
    build_profile=profile)
  File "C:\github\mbed\tools\build_api.py", line 1028, in build_mbed_libs
    notify.info("Building library %s (%s, %s)" %
AttributeError: 'NoneType' object has no attribute 'info'

0xc0170 · 2018-06-05T12:23:56Z

@theotherjimmy @cmonr If you can help with this one. I would close this and we fix the issues (@jeromecoutant confirmed even this does not completely fixes it). Thanks!

theotherjimmy · 2018-06-05T14:26:39Z

@0xc0170 Let's get this in as is and not block one fix waiting on another fix that will affect fewer users

theotherjimmy · 2018-06-05T14:34:38Z

@jeromecoutant see #7124

0xc0170 · 2018-06-06T07:13:40Z

Missing release version, I believe should be 5.9 rc2 - resolves build failures we saw there

0xc0170 added the needs: review label May 15, 2018

0xc0170 requested a review from theotherjimmy May 15, 2018 15:32

cmonr previously approved these changes May 15, 2018

View reviewed changes

0xc0170 dismissed cmonr’s stale review via 58d3de2 May 16, 2018 12:28

0xc0170 force-pushed the fix_build_notifier branch from 8628934 to 58d3de2 Compare May 16, 2018 12:28

build: fix notifier typo and passing to builds API

0bbfc61

Notifier should be passed to build libs functions, otherwise it's none and fails. Missing notify object in toolchain also fixed.

0xc0170 force-pushed the fix_build_notifier branch from 58d3de2 to 0bbfc61 Compare May 16, 2018 12:30

test: remove verbose from buil libs calls

9fd52e7

it was removed recently, not used anymore

theotherjimmy approved these changes May 21, 2018

View reviewed changes

theotherjimmy mentioned this pull request Jun 4, 2018

Duplicate linker files - unhelpful error message ARMmbed/mbed-cli#687

Closed

cmonr mentioned this pull request Jun 4, 2018

fix 'TerminalNotifier' spelling in build.py #7110

Closed

theotherjimmy added needs: CI and removed needs: review labels Jun 4, 2018

0xc0170 added needs: work and removed needs: CI labels Jun 5, 2018

theotherjimmy added ready for merge and removed needs: work labels Jun 5, 2018

theotherjimmy mentioned this pull request Jun 5, 2018

Tool: Use TerminalNotifier in singletest #7124

Merged

drahnr mentioned this pull request Jun 5, 2018

How to use custom linker script with mbed-cli? #7126

Closed

cmonr merged commit 4fcaa56 into ARMmbed:master Jun 5, 2018

0xc0170 added the release-version: 5.9.0-rc2 label Jun 6, 2018

0xc0170 mentioned this pull request Jun 6, 2018

Release candidate 2 for mbed-os-5.9.0 #7122

Merged

theotherjimmy removed the ready for merge label Jun 6, 2018

build: fix notifier typo and passing to builds API #6914

build: fix notifier typo and passing to builds API #6914

Uh oh!

Conversation

0xc0170 commented May 15, 2018

Description

Pull request type

Uh oh!

cmonr left a comment

Choose a reason for hiding this comment

Uh oh!

jeromecoutant commented May 16, 2018

Uh oh!

jeromecoutant commented May 16, 2018

Uh oh!

0xc0170 commented May 16, 2018

Uh oh!

jeromecoutant commented May 16, 2018

Uh oh!

0xc0170 commented May 16, 2018

Uh oh!

jeromecoutant commented May 17, 2018

Uh oh!

0xc0170 commented May 18, 2018

Uh oh!

jeromecoutant commented May 21, 2018

Uh oh!

theotherjimmy May 21, 2018

Choose a reason for hiding this comment

Uh oh!

theotherjimmy commented May 21, 2018

Uh oh!

cmonr commented Jun 4, 2018

Uh oh!

theotherjimmy commented Jun 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Jun 4, 2018

Uh oh!

mbed-ci commented Jun 5, 2018

Build : SUCCESS

Triggering tests

Uh oh!

mbed-ci commented Jun 5, 2018

Test : SUCCESS

Uh oh!

mbed-ci commented Jun 5, 2018

Exporter Build : SUCCESS

Uh oh!

jeromecoutant commented Jun 5, 2018 • edited by cmonr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Jun 5, 2018

Uh oh!

theotherjimmy commented Jun 5, 2018

Uh oh!

theotherjimmy commented Jun 5, 2018

Uh oh!

0xc0170 commented Jun 6, 2018

Uh oh!

Uh oh!

theotherjimmy commented Jun 4, 2018 •

edited

Loading

jeromecoutant commented Jun 5, 2018 •

edited by cmonr

Loading