-
Notifications
You must be signed in to change notification settings - Fork 3k
Tool: Use TerminalNotifier in singletest #7124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include this PR before next OS2 label
Thx
@jeromecoutant So this resolves your errors? |
Yes, I can make OS2 tests again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not certain if I left a comment here , github does not show it at the moment. @cmonr made one more additional commit to fix mbed 2 build, do we need to add it here or all good?
@0xc0170 See: #7132 (comment) Tl;dr: Nope. |
/morph build |
Build : SUCCESSBuild number : 2257 Triggering tests/morph test |
Test : SUCCESSBuild number : 2046 |
Exporter Build : SUCCESSBuild number : 1882 |
Description
According to #6914 comment thread, singletest did not get updated with the rest
of the tools in the notifier refactor. I thought this was because it's a
deprecated tool without users. We have a user, so we have a fix.
Pull request type