Skip to content

Tool: Use TerminalNotifier in singletest #7124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

According to #6914 comment thread, singletest did not get updated with the rest
of the tools in the notifier refactor. I thought this was because it's a
deprecated tool without users. We have a user, so we have a fix.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include this PR before next OS2 label
Thx

@theotherjimmy
Copy link
Contributor Author

@jeromecoutant So this resolves your errors?

@jeromecoutant
Copy link
Collaborator

Yes, I can make OS2 tests again
Thx

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not certain if I left a comment here , github does not show it at the moment. @cmonr made one more additional commit to fix mbed 2 build, do we need to add it here or all good?

@cmonr
Copy link
Contributor

cmonr commented Jun 6, 2018

@0xc0170 See: #7132 (comment)

Tl;dr: Nope.

@cmonr
Copy link
Contributor

cmonr commented Jun 6, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

Build : SUCCESS

Build number : 2257
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7124/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

@cmonr cmonr merged commit 7dc4848 into ARMmbed:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants