Skip to content

Cellular: Semaphore wasn't released in easycellular release build. #7195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2018
Merged

Cellular: Semaphore wasn't released in easycellular release build. #7195

merged 1 commit into from
Jun 15, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Jun 12, 2018

Description

Semaphore was released inside of MBED_ASSERT in EasyCellularConnection and so it was not released in release build.

@juhoeskeli please review.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

juhoeskeli
juhoeskeli approved these changes Jun 12, 2018
View reviewed changes
Copy link
Contributor

@juhoeskeli juhoeskeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

0xc0170
0xc0170 reviewed Jun 12, 2018
View reviewed changes
features/cellular/easy_cellular/EasyCellularConnection.cpp
@@ -42,7 +42,7 @@ bool EasyCellularConnection::cellular_status(int state, int next_state)

if (_target_state == state) {
tr_info("Target state reached: %s", _cellularConnectionFSM->get_state_string(_target_state));
MBED_ASSERT(_cellularSemaphore.release() == osOK);
(void)_cellularSemaphore.release();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, but we ignore the return value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we ignore it. There is nothing that can be done and no point doing if's just for printing semaphore release error which should never happen.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnttiKauppila Quick thoughts on the above response?

@cmonr
Copy link
Contributor

cmonr commented Jun 13, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 13, 2018

Build : SUCCESS

Build number : 2340
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7195/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 13, 2018

Exporter Build : SUCCESS

Build number : 1964
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7195/

@mbed-ci
Copy link

mbed-ci commented Jun 14, 2018

Test : SUCCESS

Build number : 2125
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7195/2125

@adbridge adbridge merged commit 3e2e6a7 into ARMmbed:master Jun 15, 2018
@jarvte jarvte deleted the fixing_easycellular_release_version branch June 15, 2018 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@juhoeskeli juhoeskeli juhoeskeli approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jarvte @cmonr @mbed-ci @0xc0170 @AnttiKauppila @juhoeskeli @adbridge