Skip to content

Cellular: Semaphore wasn't released in easycellular release build. #7195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Cellular: Semaphore wasn't released in easycellular release build. #7195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/cellular/easy_cellular/EasyCellularConnection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ bool EasyCellularConnection::cellular_status(int state, int next_state)

if (_target_state == state) {
tr_info("Target state reached: %s", _cellularConnectionFSM->get_state_string(_target_state));
MBED_ASSERT(_cellularSemaphore.release() == osOK);
(void)_cellularSemaphore.release();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, but we ignore the return value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we ignore it. There is nothing that can be done and no point doing if's just for printing semaphore release error which should never happen.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnttiKauppila Quick thoughts on the above response?

return false; // return false -> state machine is halted
}
return true;
Expand Down