Skip to content

Fix various USB warnings #7233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2018
Merged

Fix various USB warnings #7233

merged 1 commit into from
Jun 18, 2018

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Jun 15, 2018

Description

Fix USB warnings

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr
Copy link
Contributor

cmonr commented Jun 16, 2018

@c1728p9 You're going to want to take a look at the Travis CI failure, possibly getting @geky's help.

@c1728p9
Fix various USB warnings
c4862c1 
Fix the following warnings:
-[Warning] USBTester.cpp@45,0:  ARMmbed#1299-D: members and base-classes will
    be initialized in declaration order, not in member initialisation
    list order
-[Warning] USBTester.h@41,0:  ARMmbed#1300-D: ~USBTester inherits implicit
    virtual
-[Warning] USBAudio.cpp@345,0:  ARMmbed#1035-D: single-precision operand
    implicitly converted to double-precision
-[Warning] USBHID.cpp@29,0:  ARMmbed#1300-D: ~AsyncSend inherits implicit
    virtual
-[Warning] USBHID.cpp@61,0:  ARMmbed#1300-D: ~AsyncRead inherits implicit
    virtual
-[Warning] USBHID.cpp@93,0:  ARMmbed#1300-D: ~AsyncWait inherits implicit
    virtual
-[Warning] EndpointResolver.cpp@125,26: '<<' in boolean context, did
    you mean '<' ? [-Wint-in-bool-context]
@cmonr
Copy link
Contributor

cmonr commented Jun 18, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 18, 2018

Build : SUCCESS

Build number : 2372
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7233/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 18, 2018

Exporter Build : SUCCESS

Build number : 2005
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7233/

@cmonr
Copy link
Contributor

cmonr commented Jun 18, 2018

/morph uvisor-test

fkjagodzinski
fkjagodzinski approved these changes Jun 18, 2018
View reviewed changes
Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbed-ci
Copy link

mbed-ci commented Jun 18, 2018

Test : SUCCESS

Build number : 2161
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7233/2161

@cmonr cmonr merged commit 38a5685 into ARMmbed:feature-hal-spec-usb-device Jun 18, 2018
@0xc0170 0xc0170 removed the needs: CI label Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

@jeromecoutant jeromecoutant Awaiting requested review from jeromecoutant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@c1728p9 @cmonr @mbed-ci @fkjagodzinski @0xc0170