Skip to content

Cellular: added unit tests for new API functions (sim, power, base, device). #7273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Jun 20, 2018

Description

  • updated missing new functions to unit tests stubs
  • updated tests for better coverage
  • fixed run_tests.sh to allow running tests from different folder names than mbed-os

No code changes, only unit tests.

@AriParkkila @AnttiKauppila please review.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team June 20, 2018 10:30
AnttiKauppila
AnttiKauppila previously approved these changes Jun 20, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 22, 2018

updated missing new functions to unit tests stubs
updated tests for better coverage
fixed run_tests.sh to allow running tests from different folder names than mbed-os

16 file changed, description provided but commit message is just about "update". Can you add more details there?

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add details to the commit msg about changes introduced.

@jarvte jarvte force-pushed the update_cellular_unit_tests branch from b51303f to 9f68977 Compare June 26, 2018 06:14
@jarvte jarvte changed the title Cellular: updated unit tests. Cellular: added unit tests for new API functions (sim, power, base, device). Jun 26, 2018
@jarvte
Copy link
Contributor Author

jarvte commented Jun 26, 2018

@0xc0170 updated commit msg and rebased as same modifications were in other PR's which just got merged so now 12 changed files. Also some changes are still similar with the pr #7286

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 26, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 26, 2018

Build : SUCCESS

Build number : 2446
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7273/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 26, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 26, 2018

@cmonr
Copy link
Contributor

cmonr commented Jun 27, 2018

Hi @jarvte. We recently found an issue with the way Astyle in Travis CI was being setup such that it was always failing PRs. The PR will need to be rebased to get the fix which is now in master (#7338).

Once this PR is rebased, we'll prioritize getting it back into CI as soon as possible.

@cmonr
Copy link
Contributor

cmonr commented Jun 27, 2018

Ooor not...

sigh

At least we can merge this in.

@cmonr cmonr merged commit 0132e7c into ARMmbed:master Jun 27, 2018
@0xc0170 0xc0170 removed the needs: CI label Jun 27, 2018
@jarvte jarvte deleted the update_cellular_unit_tests branch June 27, 2018 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants