Add cellular information tests #7286

jarvte · 2018-06-21T07:27:35Z

Description

added more unit tests for CellularInformation class
added greentea tests for CellularInformation class

Internal ref to defect: IOTCELL-945-947

@AriParkkila @AnttiKauppila please review

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

AriParkkila · 2018-06-21T11:16:53Z

features/cellular/TESTS/api/cellular_information/main.cpp

+{
+    CellularInformation *info = cellular.get_device()->open_information(&cellular_serial);
+
+    char buf[100];


Probably not good to take this from stack?

Changed to heap

AriParkkila · 2018-06-21T11:20:13Z

features/cellular/UNITTESTS/stubs/AT_CellularInformation_stub.cpp

+
+nsapi_error_t AT_CellularInformation::get_serial_number(char *buf, size_t buf_size, SerialNumberType type)
+{
+    return 0;


NSAPI_ERROR_OK makes more sense?

0xc0170 · 2018-06-25T07:25:02Z

/morph build

0xc0170 · 2018-06-25T07:28:02Z

/morph build

mbed-ci · 2018-06-25T08:59:10Z

Build : ABORTED

Build number : 2440
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7286/

0xc0170 · 2018-06-25T08:59:38Z

Aborted one job (browser failed to render earlier CI run for me thus triggered 2x)

0xc0170 · 2018-06-25T09:13:17Z

/morph build

mbed-ci · 2018-06-25T10:44:31Z

Build : SUCCESS

Build number : 2443
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7286/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-06-25T11:56:35Z

Exporter Build : SUCCESS

Build number : 2074
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7286/

cmonr · 2018-06-25T15:16:07Z

@jarvte A rebase is needed. As soon as it's ready, we'll restart CI.

mbed-ci · 2018-06-25T15:20:09Z

Test : SUCCESS

Build number : 2222
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7286/2222

jarvte · 2018-06-26T06:06:53Z

@cmonr rebase done.

0xc0170 · 2018-06-26T07:21:31Z

/morph build

mbed-ci · 2018-06-26T08:58:20Z

Build : SUCCESS

Build number : 2445
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7286/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-06-26T10:26:29Z

Exporter Build : SUCCESS

Build number : 2076
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7286/

mbed-ci · 2018-06-26T11:18:52Z

Test : SUCCESS

Build number : 2224
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7286/2224

cmonr · 2018-06-27T01:27:59Z

Hi @jarvte. We recently found an issue with the way Astyle in Travis CI was being setup such that it was always failing PRs. The PR will need to be rebased to get the fix which is now in master (#7338).

Once this PR is rebased, we'll prioritize getting it back into CI as soon as possible.

cmonr · 2018-06-27T01:40:23Z

Ooor not...

sigh

At least we can merge this in.

0xc0170 added the needs: review label Jun 21, 2018

0xc0170 requested a review from a team June 21, 2018 07:49

AriParkkila previously approved these changes Jun 21, 2018

View reviewed changes

AnttiKauppila previously approved these changes Jun 25, 2018

View reviewed changes

jarvte dismissed stale reviews from AnttiKauppila and AriParkkila via c6e0c0c June 25, 2018 07:14

AriParkkila previously approved these changes Jun 25, 2018

View reviewed changes

0xc0170 previously approved these changes Jun 25, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Jun 25, 2018

AnttiKauppila previously approved these changes Jun 25, 2018

View reviewed changes

cmonr added needs: work release-version: 5.9.2 and removed needs: CI labels Jun 25, 2018

Teppo Järvelin added 3 commits June 26, 2018 09:05

Cellular: added more CellularInformation unit tests.

f848621

Cellular: added greentea tests for CellularInformation.

8624765

Cellular: review fixes for cellularinformation tests.

f64c84b

jarvte dismissed stale reviews from AnttiKauppila, 0xc0170, and AriParkkila via f64c84b June 26, 2018 06:06

jarvte force-pushed the add_cellular_information_tests branch from c6e0c0c to f64c84b Compare June 26, 2018 06:06

jarvte mentioned this pull request Jun 26, 2018

Cellular: added unit tests for new API functions (sim, power, base, device). #7273

Merged

AnttiKauppila approved these changes Jun 26, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Jun 26, 2018

0xc0170 approved these changes Jun 26, 2018

View reviewed changes

cmonr merged commit 8fab40a into ARMmbed:master Jun 27, 2018

0xc0170 removed the needs: CI label Jun 27, 2018

jarvte deleted the add_cellular_information_tests branch June 27, 2018 05:25

Add cellular information tests #7286

Add cellular information tests #7286

Uh oh!

Conversation

jarvte commented Jun 21, 2018

Description

Pull request type

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jun 25, 2018

Uh oh!

0xc0170 commented Jun 25, 2018

Uh oh!

mbed-ci commented Jun 25, 2018

Uh oh!

0xc0170 commented Jun 25, 2018

Uh oh!

0xc0170 commented Jun 25, 2018

Uh oh!

mbed-ci commented Jun 25, 2018

Triggering tests

Uh oh!

mbed-ci commented Jun 25, 2018

Uh oh!

cmonr commented Jun 25, 2018

Uh oh!

mbed-ci commented Jun 25, 2018

Uh oh!

jarvte commented Jun 26, 2018

Uh oh!

0xc0170 commented Jun 26, 2018

Uh oh!

mbed-ci commented Jun 26, 2018

Triggering tests

Uh oh!

mbed-ci commented Jun 26, 2018

Uh oh!

mbed-ci commented Jun 26, 2018

Uh oh!

cmonr commented Jun 27, 2018

Uh oh!

cmonr commented Jun 27, 2018

Uh oh!

Uh oh!