New target UNO_91H from RDA Microelectronics. #7309

kyliuxing · 2018-06-25T03:21:52Z

Description

New target UNO_91H from RDA Microelectronics.

Pull request type

[ ] Fix
[ ] Refactor
[x] New target
[ ] Feature
[ ] Breaking change

greentea logs are attached below:
Greentea_report.zip

kyliuxing · 2018-06-25T03:22:47Z

This PR inherit from #6508

0xc0170 · 2018-06-25T07:52:47Z

tools/targets/__init__.py

@@ -538,6 +538,65 @@ class RTL8195ACode:
    def binary_hook(t_self, resources, elf, binf):
        from tools.targets.REALTEK_RTL8195AM import rtl8195a_elf2bin
        rtl8195a_elf2bin(t_self, elf, binf)
+
+class RDATargetCode:


@theotherjimmy Please review this addition

0xc0170 · 2018-06-25T07:53:56Z

targets/TARGET_RDA/TARGET_UNO_91H/us_ticker.c

@@ -0,0 +1,174 @@
+/* mbed Microcontroller Library
+ * Copyright (c) 2006-2013 ARM Limited


These files should have 2018 only year there

I have already corrected them.

0xc0170 · 2018-06-25T07:56:10Z

targets/TARGET_RDA/TARGET_UNO_91H/sleep.c

+#endif
+
+    // set to sleep
+    hal_sleep();


Does this pass the sleep test (hal - sleep tests) ?

yes, we have passed greentea test

@kyliuxing Would you mind posting the results for all three compilers?

@cmonr I have added them.

0xc0170 · 2018-06-25T08:11:05Z

targets/TARGET_RDA/TARGET_UNO_91H/device/TOOLCHAIN_ARM_STD/TARGET_UNO_81C/RDA5981C.sct

+  ; 8_byte_aligned(31 vect * 4 bytes) =  8_byte_aligned(0x7C) = 0x80
+  ER_IRAMVEC RDA_IRAM_BASE EMPTY 0x80  {        ; Reserved for vectors
+  }
+  ; IRAM Size: Total(128KB) - Vector(128B) - Stack(2KB)


@bulislaw Stack 1kB for new devices?

kyliuxing · 2018-06-25T13:07:36Z

Change target name from UNO_81C to UNO_91H

theotherjimmy

Could you explain to me why you need the following files generated by your post-bulid script:

project.rcf
project_data.txt
project_dasm.txt

None of these are returned to the user by the online compiler.

kyliuxing · 2018-06-27T09:22:35Z

@theotherjimmy Rcf file is used for design verification , data and dasm can help track crash issue.

theotherjimmy · 2018-06-27T13:46:16Z

@kyliuxing We don't take post build scrits that "help track crash issues". Why is the RCF file needed by an arbitrary user?

theotherjimmy · 2018-06-27T13:47:34Z

Further, Disassembly can be done by GDB, Uvision, IAR and many other IDEs without the use of any specialized infrastructure. Ditto for data section dumping (which is already part of the map file).

kyliuxing · 2018-06-28T06:24:59Z

@theotherjimmy I have removed them

Scripts removed

0xc0170 · 2018-06-29T11:29:29Z

targets/TARGET_RDA/TARGET_UNO_91H/device/TOOLCHAIN_GCC_ARM/rda_retarget.c

@@ -0,0 +1,27 @@
+/* mbed Microcontroller Library - sbrkwrap
+ * Copyright (C) 2009-2018 ARM Limited. All rights reserved.


Can you edit this license to be as in other files

0xc0170 · 2018-06-29T11:31:19Z

targets/TARGET_RDA/TARGET_UNO_91H/lib/README.md

@@ -0,0 +1,5 @@
+libhal files in the subfolders are generated with toolchains:
+
+Arm Compiler 5 - version 5.06u1


👍

What license are these released with? Permissive Binary License?

@0xc0170 yes, I have added license.

0xc0170 · 2018-06-29T11:33:22Z

@ARMmbed/mbed-os-tls Please review TRNG addition

theotherjimmy · 2018-06-29T14:19:03Z

@kyliuxing Thanks! Now you're target will be trivial to get working in the online compiler.

yanesca · 2018-07-02T10:13:34Z

Can you please fix the reviewers? This needs to be reviewed by @mbed-os-crypto, not @mbed-os-tls.

0xc0170 · 2018-07-02T10:34:15Z

Can you please fix the reviewers? This needs to be reviewed by @mbed-os-crypto, not @mbed-os-tls.

Will do. Just to confirm for @ARMmbed/mbed-os-maintainers - TRNG belongs to the crypto team

kyliuxing · 2018-11-10T02:07:00Z

@0xc0170 Attachment Greentea_report.zip is already the latest GreenTea test results.Thanks!

cmonr · 2018-11-10T04:26:16Z

@kyliuxing The PR still needs a rebase to resolve the current conflicts.

kyliuxing · 2018-11-10T10:17:00Z

@cmonr done

cmonr · 2018-11-12T13:40:57Z

Weird. Can't seem to dismiss @jamesbeyond's comment.

@jamesbeyond The tests results look good, aside from missing IAR, but not going to block this PR being able to start CI on that.

@kyliuxing Will start when able. We're looking at a couple of things internally.

jamesbeyond · 2018-11-12T13:45:18Z

Hi @kyliuxing @cmonr , test results Look good to me. Thanks

0xc0170 · 2018-11-12T17:44:11Z

/morph build

mbed-ci · 2018-11-12T18:33:32Z

Build : SUCCESS

Build number : 3602
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7309/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-11-12T21:51:26Z

Exporter Build : SUCCESS

Build number : 3207
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7309/

mbed-ci · 2018-11-12T22:08:02Z

Test : FAILURE

Build number : 3379
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7309/3379

0xc0170 · 2018-11-14T08:20:27Z

/morph test

mbed-ci · 2018-11-14T10:01:11Z

Test : FAILURE

Build number : 3396
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7309/3396

0xc0170 · 2018-11-14T10:27:46Z

/morph test

mbed-ci · 2018-11-14T16:23:16Z

Test : FAILURE

Build number : 3400
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7309/3400

cmonr · 2018-11-14T16:58:50Z

Test failure is still unrelated to PR...
Will restart when able.

0xc0170 · 2018-11-15T14:14:04Z

Note: This PR is now a part of a rollup PR (#8753).

In order to expedite remaining CI testing, this PR has been bundled into the above rollup PR.

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

cmonr · 2018-11-15T22:30:58Z

Please ignore. I derped.

NirSonnenschein added the needs: review label Jun 25, 2018

0xc0170 requested a review from theotherjimmy June 25, 2018 07:52

0xc0170 requested changes Jun 25, 2018

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Jun 25, 2018

kyliuxing force-pushed the master branch from e503765 to b567879 Compare June 25, 2018 13:03

kyliuxing changed the title ~~New target UNO_81C from RDA Microelectronics.~~ New target UNO_91H from RDA Microelectronics. Jun 25, 2018

cmonr added the needs: preceding PR label Jun 25, 2018

theotherjimmy previously requested changes Jun 25, 2018

View reviewed changes

kyliuxing force-pushed the master branch from 8cb7c7e to 9a5fed3 Compare June 28, 2018 06:22

cmonr mentioned this pull request Jun 28, 2018

Add RDA's new target UNO_81C #6508

Closed

0xc0170 reviewed Jun 29, 2018

View reviewed changes

0xc0170 removed the needs: preceding PR label Jun 29, 2018

0xc0170 requested a review from a team June 29, 2018 11:33

0xc0170 added the component: security label Jun 29, 2018

0xc0170 requested a review from a team June 29, 2018 11:35

0xc0170 added the tracking label Jun 29, 2018

0xc0170 removed the request for review from a team July 2, 2018 10:34

0xc0170 requested a review from ashok-rao November 9, 2018 14:00

cmonr added the needs: work label Nov 9, 2018

New target UNO_91H from RDA Microelectronics.

6270642

kyliuxing force-pushed the master branch from f0bec59 to 6270642 Compare November 10, 2018 10:16

cmonr added needs: CI and removed needs: work labels Nov 12, 2018

jamesbeyond approved these changes Nov 12, 2018

View reviewed changes

0xc0170 added rollup PR release-version: 5.10.4 labels Nov 15, 2018

0xc0170 mentioned this pull request Nov 15, 2018

Rollup PR: Retest bundled PRs that experienced CI issues #8753

Merged

cmonr mentioned this pull request Nov 15, 2018

Rollup PR: Retest CI-troubled PRs targeted for 5.11 #8759

Closed

cmonr merged commit 6270642 into ARMmbed:master Nov 15, 2018

cmonr removed needs: CI rollup PR labels Nov 15, 2018

		@@ -0,0 +1,174 @@
		/* mbed Microcontroller Library
		* Copyright (c) 2006-2013 ARM Limited

		@@ -0,0 +1,27 @@
		/* mbed Microcontroller Library - sbrkwrap
		* Copyright (C) 2009-2018 ARM Limited. All rights reserved.

		@@ -0,0 +1,5 @@
		libhal files in the subfolders are generated with toolchains:

		Arm Compiler 5 - version 5.06u1

New target UNO_91H from RDA Microelectronics. #7309

New target UNO_91H from RDA Microelectronics. #7309

Uh oh!

Conversation

kyliuxing commented Jun 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

kyliuxing commented Jun 25, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kyliuxing commented Jun 25, 2018

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

kyliuxing commented Jun 27, 2018

Uh oh!

theotherjimmy commented Jun 27, 2018

Uh oh!

theotherjimmy commented Jun 27, 2018

Uh oh!

kyliuxing commented Jun 28, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jun 29, 2018

Uh oh!

theotherjimmy commented Jun 29, 2018

Uh oh!

yanesca commented Jul 2, 2018

Uh oh!

0xc0170 commented Jul 2, 2018

Uh oh!

kyliuxing commented Nov 10, 2018

Uh oh!

cmonr commented Nov 10, 2018

Uh oh!

kyliuxing commented Nov 10, 2018

Uh oh!

cmonr commented Nov 12, 2018

Uh oh!

jamesbeyond commented Nov 12, 2018

Uh oh!

0xc0170 commented Nov 12, 2018

Uh oh!

mbed-ci commented Nov 12, 2018

Triggering tests

Uh oh!

mbed-ci commented Nov 12, 2018

Uh oh!

mbed-ci commented Nov 12, 2018

Uh oh!

0xc0170 commented Nov 14, 2018

Uh oh!

mbed-ci commented Nov 14, 2018

Uh oh!

0xc0170 commented Nov 14, 2018

kyliuxing commented Jun 25, 2018 •

edited

Loading

cmonr commented Nov 15, 2018 •

edited

Loading