Skip to content

build_api script : separate PeripheralPins.o #7353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

jeromecoutant
Copy link
Collaborator

Description

This is done with @0xc0170 advice...
#7193 (comment)

Goal is to compile peripheral pins as separate object files in OS2

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cmonr
Copy link
Contributor

cmonr commented Jun 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 27, 2018

Build : SUCCESS

Build number : 2463
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7353/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

@cmonr cmonr merged commit 8baa8c5 into ARMmbed:master Jun 28, 2018
@cmonr
Copy link
Contributor

cmonr commented Jun 29, 2018

@jeromecoutant Doing a review of another PR, it dawned on me that this PR addition didn't update the comment block above. Would you mind submitting another PR with a comment addressing what PeripheralPins.o is?

(I know what and why, but it's more about keeping in line with the existing documentation.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants