Skip to content

build_api.py : add comment about separate_names #7370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2018
Merged

build_api.py : add comment about separate_names #7370

merged 1 commit into from
Jun 30, 2018

Conversation

jeromecoutant
Copy link
Collaborator

Description

Comment was forgotten :
#7353 (comment)

@cmonr

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from cmonr June 29, 2018 08:01
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 29, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 29, 2018

Build : SUCCESS

Build number : 2478
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7370/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 29, 2018

Exporter Build : SUCCESS

Build number : 2117
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7370/

@mbed-ci
Copy link

mbed-ci commented Jun 29, 2018

Test : SUCCESS

Build number : 2255
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7370/2255

cmonr
cmonr approved these changes Jun 30, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cmonr cmonr merged commit 72684e3 into ARMmbed:master Jun 30, 2018
@jeromecoutant jeromecoutant deleted the PR_PERIPPINO branch July 2, 2018 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeromecoutant @0xc0170 @mbed-ci @cmonr