Skip to content

Tools: Fix incrimental compile dep tracking #7646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2018

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Jul 30, 2018

Description

I recently introduced a general purpose function for creating command files.
This function used the hash in naming the file, but not in checking for
updates. This PR corrects the incrimental compile behavior of links.

In the process, I noticed that mbed_config.h changes every compile under
python 3. I'll be correcting that shortly. That should be resolved now

TODO

  • Fix incrimental flags for linker
  • Fix Python 3 mbed_config.h orering

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr cmonr self-requested a review July 30, 2018 16:59
@cmonr
Copy link
Contributor

cmonr commented Jul 31, 2018

Interesting to know that Py3 doesn't sort by default.

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2018

Build : SUCCESS

Build number : 2712
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7646/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 1, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 1, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 1, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 1, 2018

@cmonr cmonr merged commit 7f73a6d into ARMmbed:master Aug 1, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Tools: Fix incrimental compile dep tracking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants