Skip to content

Release candidate for mbed-os-5.9.5 #7753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 68 commits into from
Aug 13, 2018
Merged

Release candidate for mbed-os-5.9.5 #7753

merged 68 commits into from
Aug 13, 2018

Conversation

adbridge
Copy link
Contributor

No description provided.

@adbridge
Copy link
Contributor Author

/morph build

@adbridge
Copy link
Contributor Author

/morph mbed2-release

@mbed-ci
Copy link

mbed-ci commented Aug 10, 2018

Build : FAILURE

Build number : 2776
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7753/

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph mbed2-release

Output

mbed Build Number: 112

Build Prep failed!

Teppo Järvelin and others added 25 commits August 13, 2018 14:44
Decreased stack size from 24kB to 1kB (stack is used on boot-up/interrupt
handler). Increased heap size from 65kB to 89kB.

Change is related to issue #7137
where UBLOX_EVK_ODIN_W2 runs out of heap on WLAN.
The issue rose up when using ARMC6. A test case didn't initialize NetID
parameter for ABP while using connect(params) API. NetID is the first 7 bits
of the Device Address. It makes sense to actually remove the net-id parameter
from ABP settings as the stack can deduce it from device address. However, the ABP
structure is exposed in public APIs, so we can't really do that at the moment.
Simpler fix is to move the mask that helps us to extract first 7 bits of the device address
is exposed in lorawan_types.h and the user can use it to deduce correct net-id.
Fixes error: IOTCLT-2883 - Blockwise observations not completing
DEVICE_EMAC is defined only for boards with default Ethernet emac.
It is not defined for example for Realtek RTL8195AM board that
does not have Ethernet. Removed the check for device emac from emac
greentea tests.
This commit fixes some bugs from cancel_sending() method:
-  System crashed if method was called before initialization.
   Now LORAWAN_STATUS_NOT_INITIALIZED will be returned.
-  Method returned LORAWAN_STATUS_BUSY error when no send request was pending.
   LORAWAN_STATUS_OK should be returned in this case.
-  LORAWAN_STATUS_BUSY is now returned if backoff timer is just about to be
   dispatched (time_left returns 0).
- stm32f1xx hal V1.1.2
Although other venders implement this feature by using RTC, in my H/W(RZ_A1), I cannot use RTC because it does not satisfy the spec of LP Ticker (ms order and low frequency between 8 KHz and 64 KHz).
Therefore I implemented this feature by creating 1024 division by MTU2(Multi function Timer pulse Unit 2) in order to satisfy this spec.
As a result of investigating, the most unaffected channel among MTU2 placed on GR-PEACH and GR-LYCHEE was channel 3, so I use channel 3 for this feature.

- mbed_drv_cfg.h
  I added a macro of MTU2 channel to this file for commonalizing code for GR-PEACH and GR-LYCHEE, and referenced it's macro at us_ticker.c.
- targets.json
  I added a macro for enabling LP Ticker.
- mtu2.c mtu2.h
  I defined fuction of MTU2's clock supply and stop.
  Because MTU2 is utilized by pwm driver too, those function were referenced at lp_ticker driver and pwm driver.

- lp_ticker.c lp_ticker_init()
  In order to satisfy the LP Ticker spec, I implemented by creating 1024 division by MTU2.
  When an interrupt is required, it will be set with ticker_set_interrupt().

- lp_ticker.c lp_ticker_free()
  This function stops the counting and powerdown the lp_ticker.

- lp_ticker.c lp_read()
  This function returns the timer counter of MTU2.

- lp_ticker.c lp_ticker_set_interrupt()
  In order to satisfy specifications, I implemented lp_ticker_set_interrupt() function.

- lp_ticker.c lp_ticker_fire_interrupt()
  In order to satisfy spec, I implemented lp_ticker_fire_interrupt() function.
  Also I added GIC_EnableIRQ for allowing the interrupt at end of function.

- lp_ticker.c lp_ticker_get_info()
  To satisfy the spec, I implemented lp_ticker_get_info() function. The value of freq includes rounding off.
I added "lp_ticker_inited = 0" in lp_ticker_free() of lp_ticker.c, so
re-initialization will work.
Ignore TEST_GROUP by AStyle. As this uses macro, is not visible to formatter.
By default, it assumes it is a function and treats methods as blocks inside a
function (inlined {}). We ignore it.

We might just not format UNITTESTS in the future if we face similar issues
in the future.
0xc0170 and others added 18 commits August 13, 2018 14:44
Based on the https://www.keil.com/boards2/nxp/frdm_k22f/ - it contains xxx12 MCU.
However IAR 7.80 has only xxx5 version, thus leaving NXP added version as xxx5.
This fixes the failure for IAR regarding floating point.
As suggested by Russ Butler in mbed-os issue #7328, and until there is an
implementation of mbed-os issue #4408, we are implementing a workaround
at HAL level to check if there is any ongoing serial transfer (which happens
if HW FIFO is not yet empty).

In case a transfer is ongoing, we're not entering deep sleep and
return immediately.
Missing from common flags:
 * `-D__MICROLIB`
 * `--library_type=microlib`

This patch adds them
@adbridge
Copy link
Contributor Author

/morph build
/morph mbed2-release

@adbridge
Copy link
Contributor Author

Note one commit has been taken from #7646 (Although full PR is scheduled for 5.10)

@mbed-ci
Copy link

mbed-ci commented Aug 13, 2018

Build : SUCCESS

Build number : 2781
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7753/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 13, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 13, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 13, 2018

Going to retry this.
Issue already reported for failing test...

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 13, 2018

Test : SUCCESS

Build number : 2518
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7753/2518

@cmonr cmonr self-requested a review August 13, 2018 23:27
@cmonr cmonr merged commit f8b140f into mbed-os-5.9 Aug 13, 2018
@0xc0170 0xc0170 removed the needs: CI label Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.