Correct MTB_ADV_WISE_1530 led configuration #7686
Conversation
led configuration have been updated. Also minor update to MTB_MXCHIP_EMW3166 led configuration, led3 is now defined but not connected.
|
@SeppoTakalo, please review |
| @@ -201,6 +201,7 @@ typedef enum { | |||
| // Generic signals namings | |||
| LED1 = PB_2, | |||
| LED2 = PB_10, | |||
| LED3 = NC, | |||
There was a problem hiding this comment.
@KariHaapalehto : I'm not clear why is this required?
There was a problem hiding this comment.
It is not required, but all MTB's do have 3 different led's so I would like to identyfy that there is 3rd led available but it is not connected.
| "config": { | ||
| "led1": "PA_4", | ||
| "led2": "PC_12", | ||
| "led3": "NC" |
There was a problem hiding this comment.
same comment as above. why is led3 required if not connected? Also, this may not be for this particular PR, but looks like there is a naming issue here.. the parent target is "USI_xxx" (note: manf = USI), and ADV target inherits from it.. (note: manf = ADV). We may want to change this in the future.
There was a problem hiding this comment.
MTB has 3 leds, so all MTB targets should define those. But unfortunately all MCBs don't connect those leds, so those that don't need NC instead.
| "config": { | ||
| "led1": "PA_4", | ||
| "led2": "PC_12", | ||
| "led3": "NC" |
There was a problem hiding this comment.
MTB has 3 leds, so all MTB targets should define those. But unfortunately all MCBs don't connect those leds, so those that don't need NC instead.
|
Can this be merged? |
|
/morph build |
Build : SUCCESSBuild number : 2775 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2406 |
Test : SUCCESSBuild number : 2509 |
Correct MTB_ADV_WISE_1530 led configuration
mbed-os-example_blinky didn't work with MTB_ADV_WISE_1530, so led configuration have been updated. Also minor update to MTB_MXCHIP_EMW3166 led configuration, led3 is now
defined but not connected.
Description
mbed-os-example-blinky have been tested and verified with these 3 boards:
MTB_ADV_WISE_1530
MTB_USI_WM_BN_BM_22
MTB_MXCHIP_EMW
Pull request type