Skip to content

Correct MTB_ADV_WISE_1530 led configuration #7686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Correct MTB_ADV_WISE_1530 led configuration #7686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F412xG/TARGET_MTB_MXCHIP_EMW3166/PinNames.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ typedef enum {
// Generic signals namings
LED1 = PB_2,
LED2 = PB_10,
LED3 = NC,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KariHaapalehto : I'm not clear why is this required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not required, but all MTB's do have 3 different led's so I would like to identyfy that there is 3rd led available but it is not connected.

LED_RED = LED1,
LED_BLUE = LED2,
USER_BUTTON = PC_13,
Expand Down
14 changes: 13 additions & 1 deletion targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F412xG/TARGET_USI_WM_BN_BM_22/PinNames.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,12 +241,24 @@ typedef enum {


// Generic signals namings
#ifdef MBED_CONF_TARGET_LED1
LED1 = MBED_CONF_TARGET_LED1,
#else
LED1 = PA_7,
#endif
#ifdef MBED_CONF_TARGET_LED2
LED2 = MBED_CONF_TARGET_LED2,
#else
LED2 = PC_4,
#endif
#ifdef MBED_CONF_TARGET_LED3
LED3 = MBED_CONF_TARGET_LED3,
#else
LED3 = PC_11,
#endif
LED_RED = LED1,
LED_BLUE = LED2,
LED_GREEN = LED3,
LED_GREEN = LED3,
USER_BUTTON = PB_14,

// Standardized button names
Expand Down
5 changes: 5 additions & 0 deletions targets/targets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1200,6 +1200,11 @@
},
"MTB_ADV_WISE_1530": {
"inherits": ["USI_WM_BN_BM_22"],
"config": {
"led1": "PA_4",
"led2": "PC_12",
"led3": "NC"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above. why is led3 required if not connected? Also, this may not be for this particular PR, but looks like there is a naming issue here.. the parent target is "USI_xxx" (note: manf = USI), and ADV target inherits from it.. (note: manf = ADV). We may want to change this in the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MTB has 3 leds, so all MTB targets should define those. But unfortunately all MCBs don't connect those leds, so those that don't need NC instead.

},
"overrides": {
"stdio_uart_tx": "PB_10",
"stdio_uart_rx": "PC_11"
Expand Down