Skip to content

Rename text region in ARM linker file for Renesas & Realtek boards #7729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2018
Merged

Rename text region in ARM linker file for Renesas & Realtek boards #7729

merged 1 commit into from
Aug 9, 2018

Conversation

davidsaada
Copy link
Contributor

Description

Continuing the work from #7242, to name the text load region LR_IROM1. This is required for uniformity sake, claiming that this should be the region name for all boards (also mentioned in Handbook). Work is done here on few Renesas and Realtek boards.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

@davidsaada davidsaada mentioned this pull request Aug 8, 2018
Merged
@cmonr
Copy link
Contributor

cmonr commented Aug 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 9, 2018

Build : SUCCESS

Build number : 2768
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7729/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 9, 2018

Exporter Build : SUCCESS

Build number : 2398
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7729/

@mbed-ci
Copy link

mbed-ci commented Aug 9, 2018

Test : FAILURE

Build number : 2496
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7729/2496

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2018

Timeout

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 9, 2018

Test : SUCCESS

Build number : 2500
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7729/2500

@cmonr cmonr merged commit 7bcbb78 into ARMmbed:master Aug 9, 2018
@davidsaada davidsaada deleted the david_fix_arm_linker_script_renesas_realtek branch August 22, 2018 09:08
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7729 from davidsaada/david_fix_arm_linker_…
f8e1032 
…script_renesas_realtek

Rename text region in ARM linker file for Renesas & Realtek boards
M-ichae-l
M-ichae-l reviewed Sep 27, 2018
View reviewed changes
targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A/device/TOOLCHAIN_ARM_STD/rtl8195a.sct
@@ -55,7 +55,7 @@ LR_TCM 0x1FFF0000 0x10000 {
}
}

LR_DRAM 0x30000000 0x200000 {
LR_IROM1 0x30000000 0x200000 {

Copy link
Contributor

@M-ichae-l M-ichae-l Sep 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two regions (LR_DRAM & ER_IRAM) had re-named as one region (LR_IROM1). Are there any reasons? LR_DRAM is actually not a region that only has text. I wonder the name changes may cause further issues.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidsaada

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any suggestions?

@cmonr cmonr mentioned this pull request Jan 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@M-ichae-l M-ichae-l M-ichae-l left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@TomoYamanaka TomoYamanaka TomoYamanaka approved these changes

@tung7970 tung7970 Awaiting requested review from tung7970

Assignees
No one assigned
Labels
release-version: 5.9.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@davidsaada @cmonr @mbed-ci @0xc0170 @TomoYamanaka @M-ichae-l