Unittests: add ip4string.h header stub #8018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OPpuolitaival @0xc0170 review this. |
0xc0170
reviewed
Sep 6, 2018
UNITTESTS/target_h/ip4string.h
Outdated
|
|
||
| bool stoip4(const char *ip4addr, size_t len, void *dest) | ||
| { | ||
| } |
There was a problem hiding this comment.
to avoid warning, this should return something? (similar to ip4tos)
0xc0170
approved these changes
Sep 6, 2018
|
@0xc0170 all unit tests in master should now pass (unit tests for UDPSocket and TCPSocket were failing before). |
OPpuolitaival
approved these changes
Sep 10, 2018
|
We're going with #8086. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a missing ip4string.h header file into
UNITTESTS/target_hdirectory for tests to pass.Pull request type