Tools: Restrict toolchains reported by mbed compile -S to official ones #8249

theotherjimmy · 2018-09-25T17:39:43Z

Description

The mbed compile -S command is suposed to indicate what targets
support what toolchains. The command was printing out things that
don't make sense, like GCC_CR and things that make sense, but are
not offiially supported yet, like ARMC6. This PR fixes all of that.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

0xc0170

Isn't this available anywhere as a list (similar to other like allowed_features, etc): SUPPORTED_TOOLCHAINS ?I assume we check the validity for supported toolchains somwhere

bridadan · 2018-09-26T14:55:11Z

tools/build_api.py

-                    unique_supported_toolchains.append(toolchain)
-
-    return unique_supported_toolchains
+    return ["ARM", "uARM", "GCC_ARM", "IAR"]


To avoid creating a disconnect between the toolchain implementation, can we reference the keys present here instead:

mbed-os/tools/toolchains/__init__.py

Line 1112 in 1eab072

TOOLCHAIN_CLASSES = {

I realize ARM6 is in that list though. So that would mean just removing it from the list here by name, or adding a "supported" variable (or something similar) to the toolchain class and then filter on that here.

bridadan · 2018-09-26T15:00:23Z

Side note, there are quite a few targets in targets.json that still list GCC_CR as a supported toolchain. Is it safe to go ahead and remove that compiler from those targets? Looking at the our supported toolchain code it doesn't look like we support that compiler anymore anyway.

cmonr · 2018-09-28T16:26:25Z

Side note, there are quite a few targets in targets.json that still list GCC_CR as a supported toolchain. Is it safe to go ahead and remove that compiler from those targets? Looking at the our supported toolchain code it doesn't look like we support that compiler anymore anyway.

I would think it should be fine. Not even sure what GCC_CR is. @ARMmbed/mbed-os-test Thoughts?

bridadan · 2018-10-01T16:05:28Z

GCC_CR referred to a variant of GCC called "Code Red" that used to be used (I think with some NXP products, can't remember). Anyway, I don't think you can get the compiler anymore so I think it should be ok to remove. Probably better to move this to a separate issue.

0xc0170 · 2018-10-02T08:12:14Z

I would think it should be fine. Not even sure what GCC_CR is. @ARMmbed/mbed-os-test Thoughts?

Not valid anymore, can be removed.

theotherjimmy · 2018-10-03T17:48:10Z

@bridadan review please.

bridadan

OFFICILLY_SUPPORTED is misspelled :)

Also, can we just say supported or released? We don't currently have a distinction between official/unofficial right?

bridadan · 2018-10-03T18:13:04Z

tools/toolchains/__init__.py

@@ -48,6 +48,8 @@
 CPU_COEF = 1

 class mbedToolchain:
+    OFFICILLY_SUPPORTED = False


This is the mispelling

### Description The `mbed compile -S` command is suposed to indicate what targets support what toolchains. The command was printing out things that don't make sense, like `GCC_CR` and things that make sense, but are not offiially supported yet, like `ARMC6`. This PR fixes all of that. ### Pull request type [x] Fix [ ] Refactor [ ] Target update [ ] Functionality change [ ] Breaking change

cmonr · 2018-10-18T16:14:31Z

@bridadan Typo corrected.

@theotherjimmy Thoughts on doing s/OFFICIALLY_SUPPORTED/SUPPORTED/g?

Typo updated. Re-review requested.

cmonr · 2018-10-18T16:17:09Z

@bridadan I think the idea is that in the past, there's been confusion about compilers being enabled vs supported in the tools. The thought goes, being a bit more verbose about this helps makes this a bit clearer, and can help contextualize questions if/when they come up.

bridadan · 2018-10-19T14:54:56Z

I think the idea is that in the past, there's been confusion about compilers being enabled vs supported in the tools.

Yeah fair point, though I would think "enabled" would mean it's in the tools (an implementation exists) and "supported" would mean the flag is set. But if this helps clarify it more then I don't feel that strongly about it 😄

cmonr · 2018-10-19T16:00:23Z

/morph build

mbed-ci · 2018-10-19T17:42:42Z

Build : SUCCESS

Build number : 3409
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8249/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-19T18:48:34Z

Exporter Build : SUCCESS

Build number : 3037
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8249/

mbed-ci · 2018-10-19T19:41:20Z

Test : SUCCESS

Build number : 3207
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8249/3207

cmonr requested review from bridadan and cmonr September 26, 2018 03:28

cmonr added the needs: review label Sep 26, 2018

0xc0170 approved these changes Sep 26, 2018

View reviewed changes

bridadan suggested changes Sep 26, 2018

View reviewed changes

OPpuolitaival approved these changes Oct 2, 2018

View reviewed changes

bridadan mentioned this pull request Oct 2, 2018

Remove GCC_CR #8304

Merged

bridadan previously requested changes Oct 3, 2018

View reviewed changes

bridadan reviewed Oct 3, 2018

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Oct 4, 2018

theotherjimmy added 2 commits October 18, 2018 11:10

Track supported information within toolchain clasess

ec72ce7

cmonr force-pushed the official-tc-support branch from 5d2df3d to ec72ce7 Compare October 18, 2018 16:12

Corrected OFFICILLY_SUPPORTED typo

b957f60

cmonr added needs: review and removed needs: work labels Oct 18, 2018

cmonr approved these changes Oct 18, 2018

View reviewed changes

cmonr added needs: CI and removed needs: review labels Oct 19, 2018

cmonr added the release-version: 5.10.3 label Oct 19, 2018

cmonr merged commit c40d860 into ARMmbed:master Oct 19, 2018

cmonr removed the needs: CI label Oct 19, 2018

Tools: Restrict toolchains reported by mbed compile -S to official ones #8249

Tools: Restrict toolchains reported by mbed compile -S to official ones #8249

Uh oh!

Conversation

theotherjimmy commented Sep 25, 2018

Description

Pull request type

Uh oh!

0xc0170 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bridadan Sep 26, 2018

Choose a reason for hiding this comment

Uh oh!

bridadan commented Sep 26, 2018

Uh oh!

cmonr commented Sep 28, 2018

Uh oh!

bridadan commented Oct 1, 2018

Uh oh!

0xc0170 commented Oct 2, 2018

Uh oh!

theotherjimmy commented Oct 3, 2018

Uh oh!

bridadan left a comment

Choose a reason for hiding this comment

Uh oh!

bridadan Oct 3, 2018

Choose a reason for hiding this comment

Uh oh!

cmonr commented Oct 18, 2018

Uh oh!

cmonr commented Oct 18, 2018

Uh oh!

bridadan commented Oct 19, 2018

Uh oh!

cmonr commented Oct 19, 2018

Uh oh!

mbed-ci commented Oct 19, 2018

Build : SUCCESS

Triggering tests

Uh oh!

mbed-ci commented Oct 19, 2018

Exporter Build : SUCCESS

Uh oh!

mbed-ci commented Oct 19, 2018

Test : SUCCESS

Uh oh!

Uh oh!

0xc0170 left a comment •

edited

Loading