Remove GCC_CR #8304
Merged
Remove GCC_CR #8304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
approved these changes
Oct 5, 2018
|
As I can see, this is just a clean-up, as the toolchain itself was removed earlier as I recall ? |
|
@0xc0170 Yup, just a clean up! |
SenRamakri
approved these changes
Oct 5, 2018
cmonr
approved these changes
Oct 8, 2018
cmonr
reviewed
Oct 9, 2018
| @@ -118,4 +118,4 @@ def compare(t1, t2, target): | |||
|
|
|||
|
|
|||
| if __name__ == '__main__': | |||
| compare("GCC_CR", "LPC1768") | |||
| compare("ARM", "GCC_ARM", "LPC1768") | |||
There was a problem hiding this comment.
Wat. Why is LPC1768 even a parameter?
There was a problem hiding this comment.
This is an old script, I'm not 100% sure if this is used anymore. Maybe in the online compiler? So I just tried to get the parameters right. I think revisiting this script in the future would be a good idea though.
|
Build results can be found in the rolled-up PR: #8387 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This came out of the discussion from #8249. This removes the references to
GCC_CR(an old unsupported toolchain) from the tools. It does not touch device code (even though there are some references there).Pull request type