-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix astyle for tests folders #8365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Only 70 files, going to check where 585 files are |
0fe15b6
to
2a28afc
Compare
I'll keep components and features untouched , any other folder besides these 2 should comfort to astyle (excluding ignored folders). One file remaining there - Span.h that needs to be fixed, will fix separately |
Ready for review. I checked all the changes, looks fine to me, no functional changes.
133 files fixed ! |
Review open for anyone ! |
b3ee37a
to
2d1be60
Compare
Rebased (resolved conflict) , up for review |
70acab6
to
75cd3a8
Compare
Fixed empty function bodies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok to me
/morph build |
@cmonr one more review would be good to have |
Build : SUCCESSBuild number : 3450 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3072 |
Test : SUCCESSBuild number : 3242 |
@cmonr Waiting for your review, tests are all good |
External code thus ignored
Add storage to the filesystem paths
Deprecated feature
75cd3a8
to
6efa4f2
Compare
Rebase done, conflicts resolved (just one file), ready for CI /morph build |
Build : SUCCESSBuild number : 3460 Triggering tests/morph test |
Test : SUCCESSBuild number : 3251 |
Exporter Build : SUCCESSBuild number : 3082 |
This is sitting on top of files for 5.11 |
Description
Note, as this touches few areas, might be safer to get in once we get <100 PR. Most changes are in the tests folders so we should make sure remaining tests PR are small (=easy to resolve conflicts), or I'll do rebase rather for this PR after the PR's are in.
Small fixes for platform/rtos/drivers. With this PR, all folders besides folders features + components should be up to date with the style and any PR there with +files should be fixed.
Pull request type