Skip to content

Fix astyle for tests folders #8365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 25, 2018
Merged

Fix astyle for tests folders #8365

merged 16 commits into from
Oct 25, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Oct 10, 2018

Description

Note, as this touches few areas, might be safer to get in once we get <100 PR. Most changes are in the tests folders so we should make sure remaining tests PR are small (=easy to resolve conflicts), or I'll do rebase rather for this PR after the PR's are in.

Small fixes for platform/rtos/drivers. With this PR, all folders besides folders features + components should be up to date with the style and any PR there with +files should be fixed.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team October 10, 2018 16:33
@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 10, 2018

Passed, 585 files (-70 files)

Only 70 files, going to check where 585 files are

@0xc0170 0xc0170 force-pushed the fix_astyle_common2 branch from 0fe15b6 to 2a28afc Compare October 10, 2018 18:19
@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 10, 2018

I'll keep components and features untouched , any other folder besides these 2 should comfort to astyle (excluding ignored folders). One file remaining there - Span.h that needs to be fixed, will fix separately

@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 11, 2018

Ready for review. I checked all the changes, looks fine to me, no functional changes.

travis-ci/astyle — Passed, 522 files (-133 files)

133 files fixed !

@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 15, 2018

Review open for anyone !

@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 23, 2018

Rebased (resolved conflict) , up for review

@0xc0170 0xc0170 force-pushed the fix_astyle_common2 branch from 70acab6 to 75cd3a8 Compare October 23, 2018 12:58
@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 23, 2018

Fixed empty function bodies {} - new line as the style says

Copy link
Contributor

@NirSonnenschein NirSonnenschein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 24, 2018

/morph build

@0xc0170 0xc0170 requested a review from cmonr October 24, 2018 10:25
@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 24, 2018

@cmonr one more review would be good to have

@mbed-ci
Copy link

mbed-ci commented Oct 24, 2018

Build : SUCCESS

Build number : 3450
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8365/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 24, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 24, 2018

@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 24, 2018

@cmonr Waiting for your review, tests are all good

@0xc0170 0xc0170 force-pushed the fix_astyle_common2 branch from 75cd3a8 to 6efa4f2 Compare October 25, 2018 08:59
@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 25, 2018

This is no functional change, patch release should be OK. I'll do rebase shortly

Rebase done, conflicts resolved (just one file), ready for CI

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 25, 2018

Build : SUCCESS

Build number : 3460
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8365/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 25, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 25, 2018

@cmonr cmonr merged commit de6ba91 into ARMmbed:master Oct 25, 2018
@cmonr cmonr removed the needs: CI label Oct 25, 2018
@adbridge
Copy link
Contributor

adbridge commented Nov 2, 2018

This is sitting on top of files for 5.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants