-
Notifications
You must be signed in to change notification settings - Fork 3k
Add Laird BL654 as a new MTB target. #8375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi Ashok, The first change will likely cause some weird issues with the release process. When updating a branch, we recommend rebasing on top of an updated master branch. Something like the following:
Where |
Thanks @cmonr .. that's the exact process I follow, but I mixed things up this time around. What do you recommend we do with this PR now? I'm Ok to start afresh if that helps.. |
@ashok-rao Whatever is easier for you. You can modify this PR or open a new one, either is fine. |
SPI_SCK = SPI_PSELSCK0, | ||
SPI_CS = SPI_PSELSS0, | ||
|
||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xc0170 : Thanks. Because the SPIS pins are not brought out on the MCB/MTB .. I kept it there (in comments) so that it may help end users to add these if they decide to bring these pins out from the module on their respective boards..
Description
Adding Laird BL654 as a new MTB module target.
Pull request type
New Target.
Greentea: All tests passing on all 3 toolchains. Logs attached below.
BL654_ARMCC_GT_Pass_log.txt
BL654_GCC_GT_Pass_log.txt
BL654_IAR_GT_Pass_log.txt
@0xc0170 @cmonr : Can you please review? Please note that this target is not "physically" available in CI yet as it is a new MTB/MCB target. Also, the 1st commit was to bring my fork up-to-date with master of Mbed OS. Not sure if this would create any merge conflicts or not. Can you please check? Thanks.